dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: dri-devel@lists.freedesktop.org
Cc: Russell King <linux@arm.linux.org.uk>,
	kernel@pengutronix.de, Daniel Vetter <daniel.vetter@ffwll.ch>,
	Dan MacDonald <allcoms@gmail.com>
Subject: [PATCH v3 0/4] Fix DP busy wait and defer disabling overlay plane
Date: Tue, 28 Feb 2017 15:18:33 +0100	[thread overview]
Message-ID: <20170228141837.22949-1-p.zabel@pengutronix.de> (raw)

Hi,

third try. This time I've removed the drm_atomic_helper_wait_for_vblanks
call from imx_drm_commit_tail unless there are planes to be disabled.
Also the drm_atomic_helper_cleanup_planes call is removed, as that is
a no-op for CMA framebuffer based drivers.

This series fixes an issue with the IPU DC/DP/IDMAC disable sequence. The
interrupt waiting code didn't work as expected, sometimes causing busy waits
longer than the timeout in drm_atomic_helper_wait_for_vblanks, which would
cause crashes similar to the reported "imxdrm issue on SABRE Lite" [1].

[1] http://www.spinics.net/lists/dri-devel/msg132485.html

I could only reproduce the error when the overlay plane was involved, using
weston with the atomic modeset patchset to trigger it, so I'm not sure if this
fixes the issue above, too.

regards
Philipp

Lucas Stach (1):
  gpu: ipu-v3: remove IRQ dance on DC channel disable

Philipp Zabel (3):
  gpu: ipu-v3: add unsynchronised DP channel disabling
  drm/imx: don't wait for vblank and stop calling cleanup_planes in
    commit_tail
  drm/imx: add deferred plane disabling

 drivers/gpu/drm/imx/imx-drm-core.c | 20 +++++++++++--
 drivers/gpu/drm/imx/ipuv3-crtc.c   | 22 +++++++++++++-
 drivers/gpu/drm/imx/ipuv3-plane.c  | 25 +++++++++++-----
 drivers/gpu/drm/imx/ipuv3-plane.h  |  5 ++++
 drivers/gpu/ipu-v3/ipu-common.c    |  8 +++--
 drivers/gpu/ipu-v3/ipu-dc.c        | 61 +++-----------------------------------
 drivers/gpu/ipu-v3/ipu-dp.c        | 15 ++++------
 drivers/gpu/ipu-v3/ipu-prv.h       |  7 ++++-
 include/video/imx-ipu-v3.h         |  2 +-
 9 files changed, 83 insertions(+), 82 deletions(-)

-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2017-02-28 14:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 14:18 Philipp Zabel [this message]
2017-02-28 14:18 ` [PATCH v3 1/4] gpu: ipu-v3: remove IRQ dance on DC channel disable Philipp Zabel
2017-03-03 19:11   ` Dan MacDonald
2017-02-28 14:18 ` [PATCH v3 2/4] gpu: ipu-v3: add unsynchronised DP channel disabling Philipp Zabel
2017-02-28 14:18 ` [PATCH v3 3/4] drm/imx: don't wait for vblank and stop calling cleanup_planes in commit_tail Philipp Zabel
2017-03-07 17:57   ` Lucas Stach
2017-02-28 14:18 ` [PATCH v3 4/4] drm/imx: add deferred plane disabling Philipp Zabel
2017-03-07 18:00   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228141837.22949-1-p.zabel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=allcoms@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).