[PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

[PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

[Tomeu Vizoso]

Rotel RSX-1058 is a receiver with 4 HDMI inputs and a HDMI output, all
1.1.

When a sink that supports deep color is connected to the output, the
receiver will send EDIDs that advertise this capability, even if it
isn't possible with HDMI versions earlier than 1.3.

Currently the kernel is assuming that deep color is possible and the
sink displays an error.

This quirk will make sure that deep color isn't used with this
particular receiver.

Fixes: 7a0baa623446 ("Revert "drm/i915: Disable 12bpc hdmi for now"")
References: https://bugs.freedesktop.org/show_bug.cgi?id=99869
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 drivers/gpu/drm/drm_edid.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 24e7b282f16c..d994ccf94f88 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -148,6 +148,9 @@ static const struct edid_quirk {
 
 	/* Panel in Samsung NP700G7A-S01PL notebook reports 6bpc */
 	{ "SEC", 0xd033, EDID_QUIRK_FORCE_8BPC },
+
+	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI 1.1*/
+	{ "ETR", 13896, EDID_QUIRK_FORCE_8BPC },
 };
 
 /*
-- 
2.9.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

[Ville Syrjälä]

On Mon, Feb 20, 2017 at 04:25:45PM +0100, Tomeu Vizoso wrote:
> Rotel RSX-1058 is a receiver with 4 HDMI inputs and a HDMI output, all
> 1.1.
> 
> When a sink that supports deep color is connected to the output, the
> receiver will send EDIDs that advertise this capability, even if it
> isn't possible with HDMI versions earlier than 1.3.
> 
> Currently the kernel is assuming that deep color is possible and the
> sink displays an error.
> 
> This quirk will make sure that deep color isn't used with this
> particular receiver.
> 
> Fixes: 7a0baa623446 ("Revert "drm/i915: Disable 12bpc hdmi for now"")
> References: https://bugs.freedesktop.org/show_bug.cgi?id=99869
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Cc: stable@vger.kernel.org
Cc: Matt Horan <matt@matthoran.com>
Tested-by: Matt Horan <matt@matthoran.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99869
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/drm_edid.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 24e7b282f16c..d994ccf94f88 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -148,6 +148,9 @@ static const struct edid_quirk {
>  
>  	/* Panel in Samsung NP700G7A-S01PL notebook reports 6bpc */
>  	{ "SEC", 0xd033, EDID_QUIRK_FORCE_8BPC },
> +
> +	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI 1.1*/
> +	{ "ETR", 13896, EDID_QUIRK_FORCE_8BPC },
>  };
>  
>  /*
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

[Ville Syrjälä]

On Wed, Mar 01, 2017 at 04:07:02PM +0200, Ville Syrjälä wrote:
> On Mon, Feb 20, 2017 at 04:25:45PM +0100, Tomeu Vizoso wrote:
> > Rotel RSX-1058 is a receiver with 4 HDMI inputs and a HDMI output, all
> > 1.1.
> > 
> > When a sink that supports deep color is connected to the output, the
> > receiver will send EDIDs that advertise this capability, even if it
> > isn't possible with HDMI versions earlier than 1.3.
> > 
> > Currently the kernel is assuming that deep color is possible and the
> > sink displays an error.
> > 
> > This quirk will make sure that deep color isn't used with this
> > particular receiver.
> > 
> > Fixes: 7a0baa623446 ("Revert "drm/i915: Disable 12bpc hdmi for now"")
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=99869
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> 
> Cc: stable@vger.kernel.org
> Cc: Matt Horan <matt@matthoran.com>
> Tested-by: Matt Horan <matt@matthoran.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99869
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

And pushed to drm-misc-fixes. Thanks for the patch/testing/bug report
etc.

> 
> > ---
> >  drivers/gpu/drm/drm_edid.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index 24e7b282f16c..d994ccf94f88 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -148,6 +148,9 @@ static const struct edid_quirk {
> >  
> >  	/* Panel in Samsung NP700G7A-S01PL notebook reports 6bpc */
> >  	{ "SEC", 0xd033, EDID_QUIRK_FORCE_8BPC },
> > +
> > +	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI 1.1*/
> > +	{ "ETR", 13896, EDID_QUIRK_FORCE_8BPC },
> >  };
> >  
> >  /*
> > -- 
> > 2.9.3
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel