From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Subject: Re: [PATCH] docs-rst: automatically convert Graphviz and SVG images
Date: Thu, 2 Mar 2017 16:34:22 -0300
Message-ID: <20170302163422.2fbd1385@vento.lan>
References: <20170302151638.1882-2-daniel.vetter@ffwll.ch>
        <20170302154002.4552-1-daniel.vetter@ffwll.ch>
        <20170302150603.6c97765f@vento.lan>
        <D6F175B0-9687-45A0-A4B9-5D0F5DE07F40@darmarit.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Return-path: <linux-doc-owner@vger.kernel.org>
In-Reply-To: <D6F175B0-9687-45A0-A4B9-5D0F5DE07F40@darmarit.de>
Sender: linux-doc-owner@vger.kernel.org
To: Markus Heiser <markus.heiser@darmarit.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Linux Doc Mailing List <linux-doc@vger.kernel.org>, DRI Development <dri-devel@lists.freedesktop.org>, Jonathan Corbet <corbet@lwn.net>, Jani Nikula <jani.nikula@linux.intel.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: dri-devel@lists.freedesktop.org

Em Thu, 2 Mar 2017 20:06:39 +0100
Markus Heiser <markus.heiser@darmarit.de> escreveu:

> Hi Mauro,
> 
> > Tested here with the enclosed patch.  
> 
> great, big step forward making /media/Makefile smaller ...  thanks a lot!!!!
> 
> > It crashed:
> > Exception occurred:
> >  File "/devel/v4l/patchwork/Documentation/sphinx/kfigure.py", line 222, in dot2format
> >    sys.stderr.write(err)
> > TypeError: write() argument must be str, not bytes
> > The full traceback has been saved in /tmp/sphinx-err-_1vahbmg.log, if you want to report the issue to the developers.
> > Please also report this if it was a user error, so that a better error message can be provided next time.
> > A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
> > Documentation/Makefile.sphinx:69: recipe for target 'htmldocs' failed
> > make[1]: *** [htmldocs] Error 1
> > Makefile:1450: recipe for target 'htmldocs' failed
> > make: *** [htmldocs] Error 2
> > 
> > Weird enough, it produced a Documentation/output/media/uapi/v4l/pipeline.svg file.  
> 
> I guess that the dot command writes something to stderr. This is captured 
> by the extension and printed to stderr ...
> 
> +def dot2format(dot_fname, out_fname):
> ...
> +    exit_code = 42
> +    with open(out_fname, "w") as out:
> +        p = subprocess.Popen(
> +            cmd, stdout = out, stderr = subprocess.PIPE )
> +        nil, err = p.communicate()
> +
> +        sys.stderr.write(err)
> +
> +        exit_code = p.returncode
> +        out.flush()
> +    return bool(exit_code == 0)
> 
> >  File "/devel/v4l/patchwork/Documentation/sphinx/kfigure.py", line 222, in dot2format
> >    sys.stderr.write(err)
> > TypeError: write() argument must be str, not bytes  
> 
> Do we need this stderr output? For a first test, uncomment the 
> "sys.stderr.write(err)“ in line 222. Or, if we really need the
> stderr, try:
> 
> -        sys.stderr.write(err)
> +        sys.stderr.write(str(err))

Yes, this fixed. I actually did:

-        sys.stderr.write(err)
+        sys.stderr.write(str(err))
+        sys.stderr.write("\n")

It is now printing:
	b''

I added the \n print to avoid it to be mixed with the "writing output"
prints.

No idea how to make sense from it - but clearly, the error report
logic require some care ;-)

Thanks,
Mauro