From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm: Defer disabling the vblank IRQ until the next interrupt (for instant-off) Date: Wed, 15 Mar 2017 23:00:31 +0200 Message-ID: <20170315210031.GY31595@intel.com> References: <20170315204027.20160-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170315204027.20160-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Michel =?iso-8859-1?Q?D=E4nzer?= , dri-devel@lists.freedesktop.org, Laurent Pinchart , Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXIgMTUsIDIwMTcgYXQgMDg6NDA6MjVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIHZibGFuayBpbnN0YW50LW9mZiBzeXN0ZW1zLCB3ZSBjYW4gZ2V0IGludG8gYSBz aXR1YXRpb24gd2hlcmUgdGhlIGNvc3QKPiBvZiBlbmFibGluZyBhbmQgZGlzYWJsaW5nIHRoZSB2 YmxhbmsgSVJRIGFyb3VuZCBhIGRybVdhaXRWYmxhbmsgcXVlcnkKPiBkb21pbmF0ZXMuIEFuZCB3 aXRoIHRoZSBhZHZlbnQgb2YgZXZlbiBkZWVwZXIgaGFyZHdhcmUgc2xlZXAgc3RhdGUsCj4gdG91 Y2hpbmcgcmVnaXN0ZXJzIGJlY29tZXMgZXZlciBtb3JlIGV4cGVuc2l2ZS4gIEhvd2V2ZXIsIHdl IGtub3cgdGhhdCBpZgo+IHRoZSB1c2VyIHdhbnRzIHRoZSBjdXJyZW50IHZibGFuayBjb3VudGVy LCB0aGV5IGFyZSBhbHNvIHZlcnkgbGlrZWx5IHRvCj4gaW1tZWRpYXRlbHkgcXVldWUgYSB2Ymxh bmsgd2FpdCBhbmQgc28gd2UgY2FuIGtlZXAgdGhlIGludGVycnVwdCBhcm91bmQKPiBhbmQgb25s eSB0dXJuIGl0IG9mZiBpZiB3ZSBoYXZlIG5vIGZ1cnRoZXIgdmJsYW5rIHJlcXVlc3RzIHF1ZXVl ZCB3aXRoaW4KPiB0aGUgaW50ZXJydXB0IGludGVydmFsLgo+IAo+IEFmdGVyIHZibGFuayBldmVu dCBkZWxpdmVyeSwgdGhpcyBwYXRjaCBhZGRzIGEgc2hhZG93IG9mIG9uZSB2Ymxhbmsgd2hlcmUK PiB0aGUgaW50ZXJydXB0IGlzIGtlcHQgYWxpdmUgZm9yIHRoZSB1c2VyIHRvIHF1ZXJ5IGFuZCBx dWV1ZSBhbm90aGVyIHZibGFuawo+IGV2ZW50LiBTaW1pbGFybHksIGlmIHRoZSB1c2VyIGlzIHVz aW5nIGJsb2NraW5nIGRybVdhaXRWYmxhbmtzLCB0aGUKPiBpbnRlcnJ1cHQgd2lsbCBiZSBkaXNh YmxlZCBvbiB0aGUgSVJRIGZvbGxvd2luZyB0aGUgd2FpdCBjb21wbGV0aW9uLgo+IEhvd2V2ZXIs IGlmIHRoZSB1c2VyIGlzIHNpbXBseSBxdWVyeWluZyB0aGUgY3VycmVudCB2YmxhbmsgY291bnRl ciBhbmQKPiB0aW1lc3RhbXAsIHRoZSBpbnRlcnJ1cHQgd2lsbCBiZSBkaXNhYmxlZCBhZnRlciBl dmVyeSBJUlEgYW5kIHRoZSB1c2VyCj4gd2lsbCBlbmFibGVkIGl0IGFnYWluIG9uIHRoZSBmaXJz dCBxdWVyeSBmb2xsb3dpbmcgdGhlIElSUS4KPiAKPiB2MjogTWFyaW8gS2xlaW5lciAtCj4gQWZ0 ZXIgdGVzdGluZyB0aGlzLCBvbmUgbW9yZSB0aGluZyB0aGF0IHdvdWxkIG1ha2Ugc2Vuc2UgaXMg dG8gbW92ZQo+IHRoZSBkaXNhYmxlIGJsb2NrIGF0IHRoZSBlbmQgb2YgZHJtX2hhbmRsZV92Ymxh bmsoKSBpbnN0ZWFkIG9mIGF0IHRoZQo+IHRvcC4KPiAKPiBUdXJucyBvdXQgdGhhdCBpZiBoaWdo IHByZWNpc2lvbiB0aW1lc3RhbWluZyBpcyBkaXNhYmxlZCBvciBkb2Vzbid0Cj4gd29yayBmb3Ig c29tZSByZWFzb24gKGFzIGNhbiBiZSBzaW11bGF0ZWQgYnkgZWNobyAwID4KPiAvc3lzL21vZHVs ZS9kcm0vcGFyYW1ldGVycy90aW1lc3RhbXBfcHJlY2lzaW9uX3VzZWMpLCB0aGVuIHdpdGggeW91 cgo+IGRlbGF5ZWQgZGlzYWJsZSBjb2RlIGF0IGl0cyBjdXJyZW50IHBsYWNlLCB0aGUgdmJsYW5r IGNvdW50ZXIgd29uJ3QKPiBpbmNyZW1lbnQgYW55bW9yZSBhdCBhbGwgZm9yIGluc3RhbnQgcXVl cmllcywgaWUuIHdpdGggeW91ciBvdGhlcgo+ICJpbnN0YW50IHF1ZXJ5IiBwYXRjaGVzLiBDbGll bnRzIHdoaWNoIHJlcGVhdGVkbHkgcXVlcnkgdGhlIGNvdW50ZXIKPiBhbmQgd2FpdCBmb3IgaXQg dG8gcHJvZ3Jlc3Mgd2lsbCBzaW1wbHkgaGFuZywgc3Bpbm5pbmcgaW4gYW4gZW5kbGVzcwo+IHF1 ZXJ5IGxvb3AuIFRoZXJlJ3MgdGhhdCBjb21tZW50IGluIHZibGFua19kaXNhYmxlX2FuZF9zYXZl Ogo+IAo+ICIqIFNraXAgdGhpcyBzdGVwIGlmIHRoZXJlIGlzbid0IGFueSBoaWdoIHByZWNpc2lv biB0aW1lc3RhbXAKPiAgKiBhdmFpbGFibGUuIEluIHRoYXQgY2FzZSB3ZSBjYW4ndCBhY2NvdW50 IGZvciB0aGlzIGFuZCBqdXN0Cj4gICogaG9wZSBmb3IgdGhlIGJlc3QuCj4gICovCj4gCj4gV2l0 aCB0aGUgZGlzYWJsZSBoYXBwZW5pbmcgYWZ0ZXIgbGVhZGluZyBlZGdlIG9mIHZibGFuayAoPT0g aHcgY291bnRlcgo+IGluY3JlbWVudCBhbHJlYWR5IGhhcHBlbmVkKSBidXQgYmVmb3JlIHRoZSB2 YmxhbmsgY291bnRlci90aW1lc3RhbXAKPiBoYW5kbGluZyBpbiBkcm1faGFuZGxlX3ZibGFuaywg dGhhdCBzdGVwIGlzIG5lZWRlZCB0byBrZWVwIHRoZSBjb3VudGVyCj4gcHJvZ3Jlc3NpbmcsIHNv IHNraXBwaW5nIGl0IGlzIGJhZC4KPiAKPiBOb3cgd2l0aG91dCBoaWdoIHByZWNpc2lvbiB0aW1l c3RhbXBpbmcgc3VwcG9ydCwgYSBrbXMgZHJpdmVyIG11c3Qgbm90Cj4gc2V0IGRldi0+dmJsYW5r X2Rpc2FibGVfaW1tZWRpYXRlID0gdHJ1ZSwgYXMgdGhpcyB3b3VsZCBjYXVzZSBwcm9ibGVtcwo+ IGZvciBjbGllbnRzLCBzbyB0aGlzIHNob3VsZG4ndCBtYXR0ZXIsIGJ1dCBpdCB3b3VsZCBiZSBn b29kIHRvIHN0aWxsCj4gbWFrZSB0aGlzIHJvYnVzdCBhZ2FpbnN0IGEgZnV0dXJlIGttcyBkcml2 ZXIgd2hpY2ggbWlnaHQgaGF2ZQo+IHVucmVsaWFibGUgaGlnaCBwcmVjaXNpb24gdGltZXN0YW1w aW5nLCBlLmcuLCBoaWdoIHByZWNpc2lvbgo+IHRpbWVzdGFtcGluZyB0aGF0IGludGVybWl0dGVu dGx5IGRvZXNuJ3Qgd29yay4KPiAKPiB2MzogUGF0Y2ggYmVmb3JlIGNvZmZlZSBuZWVkcyBleHRy YSBjb2ZmZWUuCj4gCj4gVGVzdGNhc2U6IGlndC9rbXNfdmJsYW5rCj4gU2lnbmVkLW9mZi1ieTog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIg PGRhbmllbEBmZndsbC5jaD4KPiBDYzogTWljaGVsIETDpG56ZXIgPG1pY2hlbEBkYWVuemVyLm5l dD4KPiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQu Y29tPgo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPiwKPiBDYzogTWFyaW8g S2xlaW5lciA8bWFyaW8ua2xlaW5lci5kZUBnbWFpbC5jb20+CgpZZXAuIFRoaXMgc2VlbXMgbGlr ZSBhIGdvb2QgaWRlYSB0byBtZS4gSSBqdXN0IG5lZ2xlY3RlZCB0byByZXZpZXcgaXQKbGFzdCB0 aW1lIGFyb3VuZCAoYW5kIG1heWJlIGV2ZW4gYmVmb3JlIHRoYXQ/KSBmb3Igc29tZSByZWFzb24u IExvY2tzCnNlZW0gdG8gYmUgdGFrZW4gaW4gdGhlIHJpZ2h0IG9yZGVyLCBzbyBpdCBhdCBsZWFz dCBsb29rcyBzYWZlIHRvIG1lLgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ly cS5jIHwgMTQgKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f aXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gaW5kZXggOWJkY2E2OWY3NTRjLi5l NjRiMDVlYTk1ZWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiBAQCAtMTE5OCw5ICsxMTk4LDkgQEAgc3Rh dGljIHZvaWQgZHJtX3ZibGFua19wdXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQg aW50IHBpcGUpCj4gIAlpZiAoYXRvbWljX2RlY19hbmRfdGVzdCgmdmJsYW5rLT5yZWZjb3VudCkp IHsKPiAgCQlpZiAoZHJtX3ZibGFua19vZmZkZWxheSA9PSAwKQo+ICAJCQlyZXR1cm47Cj4gLQkJ ZWxzZSBpZiAoZGV2LT52YmxhbmtfZGlzYWJsZV9pbW1lZGlhdGUgfHwgZHJtX3ZibGFua19vZmZk ZWxheSA8IDApCj4gKwkJZWxzZSBpZiAoZHJtX3ZibGFua19vZmZkZWxheSA8IDApCj4gIAkJCXZi bGFua19kaXNhYmxlX2ZuKCh1bnNpZ25lZCBsb25nKXZibGFuayk7Cj4gLQkJZWxzZQo+ICsJCWVs c2UgaWYgKCFkZXYtPnZibGFua19kaXNhYmxlX2ltbWVkaWF0ZSkKPiAgCQkJbW9kX3RpbWVyKCZ2 YmxhbmstPmRpc2FibGVfdGltZXIsCj4gIAkJCQkgIGppZmZpZXMgKyAoKGRybV92Ymxhbmtfb2Zm ZGVsYXkgKiBIWikvMTAwMCkpOwo+ICAJfQo+IEBAIC0xNzM0LDYgKzE3MzQsMTYgQEAgYm9vbCBk cm1faGFuZGxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlw ZSkKPiAgCXdha2VfdXAoJnZibGFuay0+cXVldWUpOwo+ICAJZHJtX2hhbmRsZV92YmxhbmtfZXZl bnRzKGRldiwgcGlwZSk7Cj4gIAo+ICsJLyogV2l0aCBpbnN0YW50LW9mZiwgd2UgZGVmZXIgZGlz YWJsaW5nIHRoZSBpbnRlcnJ1cHQgdW50aWwgYWZ0ZXIKPiArCSAqIHdlIGZpbmlzaCBwcm9jZXNz aW5nIHRoZSBmb2xsb3dpbmcgdmJsYW5rLiBUaGUgZGlzYWJsZSBoYXMgdG8KPiArCSAqIGJlIGxh c3QgKGFmdGVyIGRybV9oYW5kbGVfdmJsYW5rX2V2ZW50cykgc28gdGhhdCB0aGUgdGltZXN0YW1w Cj4gKwkgKiBpcyBhbHdheXMgYWNjdXJhdGUuCj4gKwkgKi8KPiArCWlmIChkZXYtPnZibGFua19k aXNhYmxlX2ltbWVkaWF0ZSAmJgo+ICsJICAgIGRybV92Ymxhbmtfb2ZmZGVsYXkgPiAwICYmCj4g KwkgICAgIWF0b21pY19yZWFkKCZ2YmxhbmstPnJlZmNvdW50KSkKPiArCQl2YmxhbmtfZGlzYWJs ZV9mbigodW5zaWduZWQgbG9uZyl2YmxhbmspOwo+ICsKPiAgCXNwaW5fdW5sb2NrX2lycXJlc3Rv cmUoJmRldi0+ZXZlbnRfbG9jaywgaXJxZmxhZ3MpOwo+ICAKPiAgCXJldHVybiB0cnVlOwo+IC0t IAo+IDIuMTEuMAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==