From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 1/4] drm: Mark up accesses of vblank->enabled outside
 of its spinlock
Date: Fri, 17 Mar 2017 22:44:42 +0200
Message-ID: <20170317204442.GW31595@intel.com>
References: <20170317202030.24410-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20170317202030.24410-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gRnJpLCBNYXIgMTcsIDIwMTcgYXQgMDg6MjA6MjdQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE9yZGVyIHRoZSB1cGRhdGUgdG8gdmJsYW5rLT5lbmFibGVkIGFmdGVyIHRoZSB0aW1l
c3RhbXAgaXMgcHJpbWVkIHNvCj4gdGhhdCBhIGNvbmN1cnJlbnQgdW5sb2NrZWQgcmVhZGVyIHdp
bGwgb25seSBzZWUgdGhlIHZibGFuay0+ZW5hYmxlZCB3aXRoCj4gdGhlIGN1cnJlbnQgdGltZXN0
YW1wLgo+IAo+IHYyOiB2YmxhbmstPmVuYWJsZSBpcyBndWFyZGVkIGJ5IGRldi0+dmJsX2xvY2sg
bm90Cj4gZGV2LT52YmxhbmtfdGltZV9sb2NrLCB1cGRhdGUgdGhlIFJFQURfT05DRSBhY2NvcmRp
bmdseS4KClRoZSBsb2NraW5nIGlzIGluZGVlZCB2ZXJ5IGNvbmZ1c2luZywgYW5kIEkgZG9uJ3Qg
a25vdyBpZiBpdCBldmVuIG1ha2VzCnNlbnNlIGFueW1vcmUuIEJ1dCB0aGlzIGxvb2tzIGF0IGxl
YXN0IGFzIHNhbmUgYXMgYW55dGhpbmcgZWxzZSBoZXJlIDopCgpGb3IgdGhlIHNlcmllczoKUmV2
aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+
Cgo+IAo+IERvIG5vdCBhZGQgYSBSRUFEX09OQ0UodmJsYW5rLT5lbmFibGVkKSBpbnNpZGUgdGhl
IGludGVycnVwdCBoYW5kbGVyIHRvCj4gYXZvaWQgbWlzc2luZyBhbiBpbnRlcnJ1cHQgd2hpbHN0
IHJhY2luZyB3aXRoIGVuYWJsZV92YmxhbmsoKQo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp
bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZp
bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu
dmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jIHwgMjMg
KysrKysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMo
KyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f
aXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gaW5kZXggNTNhNTI2YzdiMjRkLi5j
NDdlMDdjODkxMzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiBAQCAtMzI1LDYgKzMyNSw4IEBAIHN0YXRp
YyB2b2lkIHZibGFua19kaXNhYmxlX2FuZF9zYXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVu
c2lnbmVkIGludCBwaXBlKQo+ICAJc3RydWN0IGRybV92YmxhbmtfY3J0YyAqdmJsYW5rID0gJmRl
di0+dmJsYW5rW3BpcGVdOwo+ICAJdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPiAgCj4gKwlhc3Nl
cnRfc3Bpbl9sb2NrZWQoJmRldi0+dmJsX2xvY2spOwo+ICsKPiAgCS8qIFByZXZlbnQgdmJsYW5r
IGlycSBwcm9jZXNzaW5nIHdoaWxlIGRpc2FibGluZyB2YmxhbmsgaXJxcywKPiAgCSAqIHNvIG5v
IHVwZGF0ZXMgb2YgdGltZXN0YW1wcyBvciBjb3VudCBjYW4gaGFwcGVuIGFmdGVyIHdlJ3ZlCj4g
IAkgKiBkaXNhYmxlZC4gTmVlZGVkIHRvIHByZXZlbnQgcmFjZXMgaW4gY2FzZSBvZiBkZWxheWVk
IGlycSdzLgo+IEBAIC0zMzYsMTAgKzMzOCw4IEBAIHN0YXRpYyB2b2lkIHZibGFua19kaXNhYmxl
X2FuZF9zYXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ICAJ
ICogY2FsbGluZyB0aGUgLT5kaXNhYmxlX3ZibGFuaygpIG9wZXJhdGlvbiBpbiBhdG9taWMgY29u
dGV4dCB3aXRoIHRoZQo+ICAJICogaGFyZHdhcmUgcG90ZW50aWFsbHkgcnVudGltZSBzdXNwZW5k
ZWQuCj4gIAkgKi8KPiAtCWlmICh2YmxhbmstPmVuYWJsZWQpIHsKPiArCWlmIChjbXB4Y2hnX3Jl
bGF4ZWQoJnZibGFuay0+ZW5hYmxlZCwgdHJ1ZSwgZmFsc2UpKQo+ICAJCV9fZGlzYWJsZV92Ymxh
bmsoZGV2LCBwaXBlKTsKPiAtCQl2YmxhbmstPmVuYWJsZWQgPSBmYWxzZTsKPiAtCX0KPiAgCj4g
IAkvKgo+ICAJICogQWx3YXlzIHVwZGF0ZSB0aGUgY291bnQgYW5kIHRpbWVzdGFtcCB0byBtYWlu
dGFpbiB0aGUKPiBAQCAtMzg0LDcgKzM4NCw3IEBAIHZvaWQgZHJtX3ZibGFua19jbGVhbnVwKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlmb3IgKHBpcGUgPSAwOyBwaXBlIDwgZGV2LT5udW1f
Y3J0Y3M7IHBpcGUrKykgewo+ICAJCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZibGFuayA9ICZk
ZXYtPnZibGFua1twaXBlXTsKPiAgCj4gLQkJV0FSTl9PTih2YmxhbmstPmVuYWJsZWQgJiYKPiAr
CQlXQVJOX09OKFJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQpICYmCj4gIAkJCWRybV9jb3JlX2No
ZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpOwo+ICAKPiAgCQlkZWxfdGltZXJfc3lu
YygmdmJsYW5rLT5kaXNhYmxlX3RpbWVyKTsKPiBAQCAtMTEwNSwxMSArMTEwNSwxNiBAQCBzdGF0
aWMgaW50IGRybV92YmxhbmtfZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVk
IGludCBwaXBlKQo+ICAJCSAqLwo+ICAJCXJldCA9IF9fZW5hYmxlX3ZibGFuayhkZXYsIHBpcGUp
Owo+ICAJCURSTV9ERUJVRygiZW5hYmxpbmcgdmJsYW5rIG9uIGNydGMgJXUsIHJldDogJWRcbiIs
IHBpcGUsIHJldCk7Cj4gLQkJaWYgKHJldCkKPiArCQlpZiAocmV0KSB7Cj4gIAkJCWF0b21pY19k
ZWMoJnZibGFuay0+cmVmY291bnQpOwo+IC0JCWVsc2Ugewo+IC0JCQl2YmxhbmstPmVuYWJsZWQg
PSB0cnVlOwo+ICsJCX0gZWxzZSB7Cj4gIAkJCWRybV91cGRhdGVfdmJsYW5rX2NvdW50KGRldiwg
cGlwZSwgMCk7Cj4gKwkJCS8qIGRybV91cGRhdGVfdmJsYW5rX2NvdW50KCkgaW5jbHVkZXMgYSB3
bWIgc28gd2UganVzdAo+ICsJCQkgKiBuZWVkIHRvIGVuc3VyZSB0aGF0IHRoZSBjb21waWxlciBl
bWl0cyB0aGUgd3JpdGUKPiArCQkJICogdG8gbWFyayB0aGUgdmJsYW5rIGFzIGVuYWJsZWQgYWZ0
ZXIgdGhlIGNhbGwKPiArCQkJICogdG8gZHJtX3VwZGF0ZV92YmxhbmtfY291bnQoKS4KPiArCQkJ
ICovCj4gKwkJCVdSSVRFX09OQ0UodmJsYW5rLT5lbmFibGVkLCB0cnVlKTsKPiAgCQl9Cj4gIAl9
Cj4gIAo+IEBAIC0xNTE3LDcgKzE1MjIsNyBAQCBzdGF0aWMgaW50IGRybV9xdWV1ZV92Ymxhbmtf
ZXZlbnQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUsCj4gIAkgKiB2
YmxhbmsgZGlzYWJsZSwgc28gbm8gbmVlZCBmb3IgZnVydGhlciBsb2NraW5nLiAgVGhlIHJlZmVy
ZW5jZSBmcm9tCj4gIAkgKiBkcm1fdmJsYW5rX2dldCgpIHByb3RlY3RzIGFnYWluc3QgdmJsYW5r
IGRpc2FibGUgZnJvbSBhbm90aGVyIHNvdXJjZS4KPiAgCSAqLwo+IC0JaWYgKCF2YmxhbmstPmVu
YWJsZWQpIHsKPiArCWlmICghUkVBRF9PTkNFKHZibGFuay0+ZW5hYmxlZCkpIHsKPiAgCQlyZXQg
PSAtRUlOVkFMOwo+ICAJCWdvdG8gZXJyX3VubG9jazsKPiAgCX0KPiBAQCAtMTY0NCw3ICsxNjQ5
LDcgQEAgaW50IGRybV93YWl0X3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpk
YXRhLAo+ICAJCURSTV9XQUlUX09OKHJldCwgdmJsYW5rLT5xdWV1ZSwgMyAqIEhaLAo+ICAJCQkg
ICAgKCgoZHJtX3ZibGFua19jb3VudChkZXYsIHBpcGUpIC0KPiAgCQkJICAgICAgIHZibHdhaXQt
PnJlcXVlc3Quc2VxdWVuY2UpIDw9ICgxIDw8IDIzKSkgfHwKPiAtCQkJICAgICAhdmJsYW5rLT5l
bmFibGVkIHx8Cj4gKwkJCSAgICAgIVJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQpIHx8Cj4gIAkJ
CSAgICAgIWRldi0+aXJxX2VuYWJsZWQpKTsKPiAgCX0KPiAgCj4gLS0gCj4gMi4xMS4wCgotLSAK
VmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9kcmktZGV2ZWwK