dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Martyn Welch <martyn.welch@collabora.co.uk>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [CRTC:24] vblank wait timed out
Date: Wed, 29 Mar 2017 09:21:10 +0100	[thread overview]
Message-ID: <20170329082110.GU25206@hermes.home> (raw)
In-Reply-To: <1490774865.2274.26.camel@pengutronix.de>

On Wed, Mar 29, 2017 at 10:07:45AM +0200, Philipp Zabel wrote:
> On Tue, 2017-03-28 at 18:52 +0100, Martyn Welch wrote:
> > On Tue, Mar 28, 2017 at 06:44:50PM +0200, Philipp Zabel wrote:
> [...] 
> > > It is the ipu1_di0_pre_sel and ipu2_di0_pre_sel setup that is important
> > > here (and you have to pin LVDS and HDMI to separate IPUs). The LDB
> > > driver will switch the ipu1_di0_sel from ipu1_di0_pre to ldb_di1 if IPU1
> > > DI0 drives LVDS (imx_ldb_set_clock), so in that case it would be
> > > ipu2_di0_pre_sel that had to be switched away from pll5_video_div, to
> > > pll2_pfd2_396m.
> > > In short, the IPU that drives HDMI must have its pre_sel set to
> > > pll2_pfd_396m in your case, to avoid stepping on the LVDS output's toes,
> > > as the PLL can't be clocked to the pixel clock and to the LVDS serial
> > > clock (3.5*pixel clock) at the same time. The pre_sel setup for the LVDS
> > > IPU shouldn't matter as that will be switched to the ldb_di clocks. So
> > > just switching both ipu1/2_di0_pre_sel to pll2_pfd2_396m could do the
> > > trick?
> > > 
> > 
> > As you can probably tell by how much I got in a muddle with my explanation
> > above, this isn't territory I'm familiar with.
> 
> Well, the i.MX6 display clock setup is a bit convoluted.
> 
> > It sounds good, not sure I 100% understand how to do this yet. :-)
> > I'll look into this more.
> 
> Have a look at how arch/arm/boot/dts/imx6q-b850v3.dts assigns the
> clocks. I'd propose trying this setup:
> 
> &clks {
>         assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
>                           <&clks IMX6QDL_CLK_LDB_DI1_SEL>,
>                           <&clks IMX6QDL_CLK_IPU1_DI0_PRE_SEL>,
>                           <&clks IMX6QDL_CLK_IPU2_DI0_PRE_SEL>;
>         assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
>                                  <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
>                                  <&clks IMX6QDL_CLK_PLL2_PFD2_396M>,
>                                  <&clks IMX6QDL_CLK_PLL2_PFD2_396M>;
> };
> 
> I hope that way, whichever IPU1/2 DI0 is chosen for HDMI will use PLL2,
> while the IPU1/2 DI0 chosen for LVDS will be undisturbed in using PLL5.
> 

That's exactly what I figured I needed to do last night! Thanks for the
confirmation. :-)

Maybe I'm beginning to understand this a /tiny/ bit more than I thought...

Martyn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2017-03-29  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  9:50 [CRTC:24] vblank wait timed out Martyn Welch
2017-03-21 17:18 ` Philipp Zabel
2017-03-24 10:24   ` Martyn Welch
2017-03-24 10:42     ` Philipp Zabel
2017-03-27 11:11       ` Martyn Welch
2017-03-28 10:49         ` Martyn Welch
2017-03-28 16:44           ` Philipp Zabel
2017-03-28 17:52             ` Martyn Welch
2017-03-29  8:07               ` Philipp Zabel
2017-03-29  8:21                 ` Martyn Welch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329082110.GU25206@hermes.home \
    --to=martyn.welch@collabora.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).