From: Manasi Navare <manasi.d.navare@intel.com>
To: Eric Anholt <eric@anholt.net>
Cc: xorg-devel@lists.x.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD
Date: Thu, 30 Mar 2017 17:50:48 -0700 [thread overview]
Message-ID: <20170331005048.GM31477@intel.com> (raw)
In-Reply-To: <8737due0ws.fsf@eliezer.anholt.net>
On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote:
> Martin Peres <martin.peres@linux.intel.com> writes:
>
> > On 26/01/17 14:37, Martin Peres wrote:
> >> Despite all the careful planing of the kernel, a link may become
> >> insufficient to handle the currently-set mode. At this point, the
> >> kernel should mark this particular configuration as being broken
> >> and potentially prune the mode before setting the offending connector's
> >> link-status to BAD and send the userspace a hotplug event. This may
> >> happen right after a modeset or later on.
> >>
> >> When available, we should use the link-status information to reset
> >> the wanted mode.
> >>
> >> Signed-off-by: Martin Peres <martin.peres@linux.intel.com>
> >
> > The relevant kernel patches have landed in drm-tip about a month ago.
> >
> > Eric, would you mind providing feedback on or merging this patch?
>
> The later discussion has sounded like the kernel will (always) prune the
> mode when we re-query, meaning that it doesn't make any sense to try to
> re-set to the old mode. Is this not the case?
No the kernel will simply send a hotplug with link status as bad
and then after that point its userspace driver's responsibility
to check if link status is BAD, retry the same mode and if it fails
then re probe.
Regards
Manasi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-31 0:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 12:37 [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD Martin Peres
2017-01-26 17:21 ` Daniel Vetter
[not found] ` <20170126172120.iflf5b5l4m4wsuus-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-01-31 17:08 ` Manasi Navare
2017-02-01 10:17 ` Jani Nikula
2017-01-31 20:13 ` Eric Anholt
2017-02-01 10:03 ` Jani Nikula
2017-02-01 19:58 ` Eric Anholt
2017-02-01 20:05 ` Manasi Navare
[not found] ` <20170201200512.GC21934-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-02 23:30 ` Martin Peres
[not found] ` <32b846ee-69c5-1dea-eed4-1bc41bb2958f-GANU6spQydw@public.gmane.org>
2017-02-03 0:30 ` Manasi Navare
2017-02-03 8:04 ` Daniel Vetter
[not found] ` <20170203080451.vrbmoaioqjyd3hhc-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-02-06 15:50 ` Martin Peres
[not found] ` <4f8317ff-53e8-4c2d-effa-d074b11b15e6-GANU6spQydw@public.gmane.org>
2017-02-08 16:37 ` Martin Peres
[not found] ` <069473c6-d75e-48eb-e75d-4e65e201b4fb-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-13 21:05 ` Eric Anholt
2017-02-13 23:14 ` Manasi Navare
[not found] ` <87k28tkdiq.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-02-16 7:56 ` Martin Peres
2017-02-24 20:09 ` Manasi Navare
2017-02-26 19:42 ` Daniel Vetter
2017-02-28 4:07 ` Navare, Manasi D
2017-02-28 8:42 ` Daniel Vetter
2017-02-02 9:01 ` Daniel Vetter
2017-02-02 17:57 ` Eric Anholt
2017-02-28 8:43 ` Daniel Vetter
2017-02-01 19:55 ` Manasi Navare
[not found] ` <20170126123728.5680-1-martin.peres-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-03-27 14:12 ` Martin Peres
2017-03-31 0:37 ` Eric Anholt
2017-03-31 0:50 ` Manasi Navare [this message]
2017-03-31 20:08 ` Eric Anholt
[not found] ` <87d1cxw6nq.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-03-31 20:17 ` Manasi Navare
2017-04-01 0:22 ` Eric Anholt
2017-04-02 12:28 ` Daniel Vetter
[not found] ` <20170402122809.trh7oxzz25oao4bu-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-04-03 2:21 ` Eric Anholt
[not found] ` <87efxamdt6.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-04-03 6:25 ` Manasi Navare
2017-04-03 7:19 ` Daniel Vetter
2017-04-05 18:13 ` Manasi Navare
2017-04-06 17:15 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331005048.GM31477@intel.com \
--to=manasi.d.navare@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=xorg-devel@lists.x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).