Re: [PATCH 3/3] drm/arm: hdlcd: check for rotation

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
	DRI devel <dri-devel@lists.freedesktop.org>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] drm/arm: hdlcd: check for rotation
Date: Fri, 31 Mar 2017 13:11:23 +0300	[thread overview]
Message-ID: <20170331101123.GK30290@intel.com> (raw)
In-Reply-To: <E1cttDk-00067G-1b@rmk-PC.armlinux.org.uk>

On Fri, Mar 31, 2017 at 10:51:52AM +0100, Russell King wrote:
> hdlcd does not support rotation - check for it and reject plane updates
> that try to rotate a plane.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/gpu/drm/arm/hdlcd_crtc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
> index cf70184fd028..171acc842368 100644
> --- a/drivers/gpu/drm/arm/hdlcd_crtc.c
> +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
> @@ -215,6 +215,10 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane,
>  	if (!crtc)
>  		return 0;
>  
> +	/* We do not support rotation */
> +	if (state->rotation != DRM_ROTATE_0)
> +		return -EINVAL;

This can't happen unless you attach a rotation property with a bogus
set of supported rotations to the plane.

> +
>  	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
>  	if (!crtc_state->enable)
>  		return -EINVAL;
> -- 
> 2.7.4

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel