From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Date: Tue, 2 May 2017 10:48:07 +0200 Message-ID: <20170502084807.k7ioo7a5j33xtnpj@phenom.ffwll.local> References: <3e1dba0cd5fc053e56f1c9c94d0cb8789ecca4ae.1493203049.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11E2E6E20D for ; Tue, 2 May 2017 08:48:12 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id y10so2558553wmh.0 for ; Tue, 02 May 2017 01:48:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <3e1dba0cd5fc053e56f1c9c94d0cb8789ecca4ae.1493203049.git.joabreu@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu Cc: Daniel Vetter , Alexey Brodkin , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Carlos Palminha List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMjYsIDIwMTcgYXQgMTE6NDg6MzRBTSArMDEwMCwgSm9zZSBBYnJldSB3cm90 ZToKPiBTb21lIGNydGMncyBtYXkgaGF2ZSByZXN0cmljdGlvbnMgaW4gdGhlIG1vZGUgdGhleSBj YW4gZGlzcGxheS4gSW4KPiB0aGlzIHBhdGNoIGEgbmV3IGNhbGxiYWNrIChjcnRjLT5tb2RlX3Zh bGlkKCkpIGlzIGludHJvZHVjZWQgdGhhdAo+IGlzIGNhbGxlZCBhdCB0aGUgc2FtZSBzdGFnZSBv ZiBjb25uZWN0b3ItPm1vZGVfdmFsaWQoKSBjYWxsYmFjay4KPiAKPiBUaGlzIHNoYWxsIGJlIGlt cGxlbWVudGVkIGlmIHRoZSBjcnRjIGhhcyBzb21lIHNvcnQgb2YgcmVzdHJpY3Rpb24KPiBzbyB0 aGF0IHdlIGRvbid0IHByb2JlIG1vZGVzIHRoYXQgd2lsbCBmYWlsIGluIHRoZSBjb21taXQoKSBz dGFnZS4KPiBGb3IgZXhhbXBsZTogQSBnaXZlbiBjcnRjIG1heSBiZSByZXNwb25zaWJsZSB0byBz ZXQgYSBjbG9jayB2YWx1ZS4KPiBJZiB0aGUgY2xvY2sgY2FuIG5vdCBwcm9kdWNlIGFsbCB0aGUg dmFsdWVzIGZvciB0aGUgYXZhaWxhYmxlCj4gbW9kZXMgdGhlbiB0aGlzIGNhbGxiYWNrIGNhbiBi ZSB1c2VkIHRvIHJlc3RyaWN0IHRoZSBudW1iZXIgb2YKPiBwcm9iYmVkIG1vZGVzIHRvIG9ubHkg dGhlIG9uZXMgdGhhdCBjYW4gYmUgZGlzcGxheWVkLgo+IAo+IElmIHRoZSBjcnRjIGRvZXMgbm90 IGltcGxlbWVudCB0aGUgY2FsbGJhY2sgdGhlbiB0aGUgYmVoYXZpb3VyIHdpbGwKPiByZW1haW4g dGhlIHNhbWUuIEFsc28sIGZvciBhIGdpdmVuIHNldCBvZiBjcnRjcyB0aGF0IGNhbiBiZSBib3Vu ZCB0bwo+IHRoZSBjb25uZWN0b3IsIGlmIGF0IGxlYXN0IG9uZSBjYW4gZGlzcGxheSB0aGUgbW9k ZSB0aGVuIHRoZSBtb2RlCj4gd2lsbCBiZSBwcm9iYmVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpv c2UgQWJyZXUgPGpvYWJyZXVAc3lub3BzeXMuY29tPgo+IENjOiBDYXJsb3MgUGFsbWluaGEgPHBh bG1pbmhhQHN5bm9wc3lzLmNvbT4KPiBDYzogQWxleGV5IEJyb2RraW4gPGFicm9ka2luQHN5bm9w c3lzLmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzog RGF2ZSBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+CgpOb3Qgc3VyZSB0aGlzIGlzIHVzZWZ1bCwg c2luY2UgeW91IHN0aWxsIGhhdmUgdG8gZHVwbGljYXRlIHRoZSBleGFjdCBzYW1lCmNoZWNrIGlu dG8geW91ciAtPm1vZGVfZml4dXAgaG9vay4gVGhhdCBzZWVtcyB0byBtYWtlIHRoaW5ncyBldmVu IG1vcmUKY29uZnVzaW5nLgoKQWxzbyB0aGlzIGRvZXNuJ3QgdXBkYXRlIHRoZSB2YXJpb3VzIGtl cm5lbGRvYyBjb21tZW50cy4gRm9yIHRoZSBleGlzdGluZwpob29rcy4gU2luY2UgdGhpcyB0b3Bp YyBjYXVzZXMgc28gbXVjaCBjb25mdXNpb24sIEkgZG9uJ3QgdGhpbmsgYQpoYWxmLXNvbHV0aW9u IHdpbGwgaGVscCwgYnV0IGhhcyBzb21lIGdvb2QgcG90ZW50aWFsIHRvIG1ha2UgdGhpbmdzIHdv cnNlLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5j ICAgICAgIHwgNDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9k cm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMuaCB8IDI2ICsrKysrKysrKysrKysrKysrKysK PiAgMiBmaWxlcyBjaGFuZ2VkLCA3MCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3By b2JlX2hlbHBlci5jCj4gaW5kZXggMWIwYzE0YS4uNjFlYWMzMCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9wcm9iZV9oZWxwZXIuYwo+IEBAIC04MCw2ICs4MCw0NiBAQAo+ICAJcmV0dXJuIE1PREVfT0s7 Cj4gIH0KPiAgCj4gK3N0YXRpYyBlbnVtIGRybV9tb2RlX3N0YXR1cyBkcm1fbW9kZV92YWxpZGF0 ZV9jb25uZWN0b3JfY3J0YygKPiArCQlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ ICsJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+ICt7Cj4gKwljb25zdCBzdHJ1Y3Qg ZHJtX2NydGNfaGVscGVyX2Z1bmNzICpjcnRjX2Z1bmNzID0gTlVMTDsKPiArCWVudW0gZHJtX21v ZGVfc3RhdHVzIG1vZGVfc3RhdHVzID0gTU9ERV9FUlJPUjsKPiArCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSBjb25uZWN0b3ItPmRldjsKPiArCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcjsK PiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiArCWJvb2wgY2FsbGJhY2tfZm91bmQgPSBmYWxz ZTsKPiArCWludCBpOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBEUk1fQ09OTkVDVE9SX01BWF9F TkNPREVSOyBpKyspIHsKPiArCQllbmNvZGVyID0gZHJtX2VuY29kZXJfZmluZChkZXYsIGNvbm5l Y3Rvci0+ZW5jb2Rlcl9pZHNbaV0pOwo+ICsKPiArCQlpZiAoIWVuY29kZXIpCj4gKwkJCWNvbnRp bnVlOwo+ICsKPiArCQlkcm1fZm9yX2VhY2hfY3J0YyhjcnRjLCBkZXYpIHsKPiArCQkJY3J0Y19m dW5jcyA9IGNydGMtPmhlbHBlcl9wcml2YXRlOwo+ICsKPiArCQkJaWYgKCFkcm1fZW5jb2Rlcl9j cnRjX29rKGVuY29kZXIsIGNydGMpKQo+ICsJCQkJY29udGludWU7Cj4gKwkJCWlmICghY3J0Y19m dW5jcyB8fCAhY3J0Y19mdW5jcy0+bW9kZV92YWxpZCkKPiArCQkJCWNvbnRpbnVlOwo+ICsKPiAr CQkJLyogTU9ERV9PSz0wIGFuZCBkZWZhdWx0IG1vZGVfc3RhdHVzPU1PREVfRVJST1I9LTEKPiAr CQkJICogc28gaWYgYXQgbGVhc3Qgb25lIGNydGMgYWNjZXB0cyB0aGUgbW9kZSB3ZSBnZXQKPiAr CQkJICogTU9ERV9PSyAqLwo+ICsJCQltb2RlX3N0YXR1cyAmPSBjcnRjX2Z1bmNzLT5tb2RlX3Zh bGlkKGNydGMsIG1vZGUpOwo+ICsJCQljYWxsYmFja19mb3VuZCB8PSB0cnVlOwo+ICsJCX0KPiAr CX0KPiArCj4gKwkvKiBXZSBjYW4gcmVhY2ggaGVyZSB3aXRob3V0IGNhbGxpbmcgbW9kZV92YWxp ZCBpZiB0aGVyZSBpcyBubwo+ICsJICogcmVnaXN0ZXJlZCBjcnRjIHdpdGggdGhpcyBjYWxsYmFj aywgbGV0cyByZXR1cm4gTU9ERV9PSyBpbiB0aGlzCj4gKwkgKiBjYXNlICovCj4gKwlyZXR1cm4g Y2FsbGJhY2tfZm91bmQgPyBtb2RlX3N0YXR1cyA6IE1PREVfT0s7Cj4gK30KPiArCj4gIHN0YXRp YyBpbnQgZHJtX2hlbHBlcl9wcm9iZV9hZGRfY21kbGluZV9tb2RlKHN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3IpCj4gIHsKPiAgCXN0cnVjdCBkcm1fY21kbGluZV9tb2RlICpjbWRsaW5l X21vZGU7Cj4gQEAgLTQzMSw2ICs0NzEsMTAgQEAgaW50IGRybV9oZWxwZXJfcHJvYmVfc2luZ2xl X2Nvbm5lY3Rvcl9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCWlm IChtb2RlLT5zdGF0dXMgPT0gTU9ERV9PSyAmJiBjb25uZWN0b3JfZnVuY3MtPm1vZGVfdmFsaWQp Cj4gIAkJCW1vZGUtPnN0YXR1cyA9IGNvbm5lY3Rvcl9mdW5jcy0+bW9kZV92YWxpZChjb25uZWN0 b3IsCj4gIAkJCQkJCQkJICAgbW9kZSk7Cj4gKwo+ICsJCWlmIChtb2RlLT5zdGF0dXMgPT0gTU9E RV9PSykKPiArCQkJbW9kZS0+c3RhdHVzID0gZHJtX21vZGVfdmFsaWRhdGVfY29ubmVjdG9yX2Ny dGMoCj4gKwkJCQkJY29ubmVjdG9yLCBtb2RlKTsKPiAgCX0KPiAgCj4gIHBydW5lOgo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2RybS9kcm1fbW9kZXNldF9oZWxwZXJfdnRhYmxlcy5oIGIvaW5jbHVk ZS9kcm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMuaAo+IGluZGV4IGMwMWMzMjguLjU5ZmZm YmEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMu aAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlcl92dGFibGVzLmgKPiBAQCAt MTA2LDYgKzEwNiwzMiBAQCBzdHJ1Y3QgZHJtX2NydGNfaGVscGVyX2Z1bmNzIHsKPiAgCXZvaWQg KCpjb21taXQpKHN0cnVjdCBkcm1fY3J0YyAqY3J0Yyk7Cj4gIAo+ICAJLyoqCj4gKwkgKiBAbW9k ZV92YWxpZDoKPiArCSAqCj4gKwkgKiBUaGlzIGNhbGxiYWNrIHNob3VsZCBiZSBpbXBsZW1lbnRl ZCBpZiB0aGUgY3J0YyBoYXMgc29tZSBzb3J0IG9mCj4gKwkgKiByZXN0cmljdGlvbiBpbiB0aGUg bW9kZXMgaXQgY2FuIGRpc3BsYXkuIEZvciBleGFtcGxlLCBhIGdpdmVuIGNydGMKPiArCSAqIG1h eSBiZSByZXNwb25zaWJsZSB0byBzZXQgYSBjbG9jayB2YWx1ZS4gSWYgdGhlIGNsb2NrIGNhbiBu b3QKPiArCSAqIHByb2R1Y2UgYWxsIHRoZSB2YWx1ZXMgZm9yIHRoZSBhdmFpbGFibGUgbW9kZXMg dGhlbiB0aGlzIGNhbGxiYWNrCj4gKwkgKiBjYW4gYmUgdXNlZCB0byByZXN0cmljdCB0aGUgbnVt YmVyIG9mIHByb2JiZWQgbW9kZXMgdG8gb25seSB0aGUgb25lcwo+ICsJICogdGhhdCBjYW4gYmUg ZGlzcGxheWVkLgo+ICsJICoKPiArCSAqIFRoaXMgaXMgZGlyZWN0bHkgY2FsbGVkIGF0IHRoZSBz YW1lIHN0YWdlIG9mIGNvbm5lY3Rvci0+bW9kZV92YWxpZAoKJmRybV9jb25uZWN0b3JfaGVscGVy X2Z1bmNzLm1vZGVfdmFsaWQgdG8gbWFrZSBhIHByb3BlciBsaW5rLiBQbGVhc2UgYWxzbwpjaGVj ayB0aGUgb3V0cHV0IG9mIG1ha2UgaHRtbGRvY3MgYW5kIG1ha2Ugc3VyZSBpdCBsb29rcyBwcmV0 dHkuCgo+ICsJICogY2FsbGJhY2suCj4gKwkgKgo+ICsJICogTk9URToKPiArCSAqCj4gKwkgKiBG b3IgYSBnaXZlbiBzZXQgb2YgY3J0YydzIGluIGEgZHJtX2RldmljZSwgaWYgYXQgbGVhc3Qgb25l IGRvZXMgbm90Cj4gKwkgKiBoYXZlIHRoZSBtb2RlX3ZhbGlkIGNhbGxiYWNrLCBvciwgYXQgbGVh c3Qgb25lIHJldHVybnMgTU9ERV9PSyB0aGVuCj4gKwkgKiB0aGUgbW9kZSB3aWxsIGJlIHByb2Ji ZWQuCj4gKwkgKgo+ICsJICogUkVUVVJOUzoKPiArCSAqCj4gKwkgKiBkcm1fbW9kZV9zdGF0dXMg RW51bQo+ICsJICovCj4gKwllbnVtIGRybV9tb2RlX3N0YXR1cyAoKm1vZGVfdmFsaWQpKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPiArCQkJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpOwo+ ICsKPiArCS8qKgo+ICAJICogQG1vZGVfZml4dXA6Cj4gIAkgKgo+ICAJICogVGhpcyBjYWxsYmFj ayBpcyB1c2VkIHRvIHZhbGlkYXRlIGEgbW9kZS4gVGhlIHBhcmFtZXRlciBtb2RlIGlzIHRoZQo+ IC0tIAo+IDEuOS4xCj4gCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==