From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Date: Tue, 16 May 2017 12:53:52 +0200 Message-ID: <20170516105352.GH2481@dhcp22.suse.cz> References: <20170516090606.5891-1-mhocko@kernel.org> <20170516093119.GW19912@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170516093119.GW19912@nuc-i3427.alporthouse.com> Sender: owner-linux-mm@kvack.org To: Chris Wilson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Vetter , Jani Nikula , Sean Paul , David Airlie List-Id: dri-devel@lists.freedesktop.org On Tue 16-05-17 10:31:19, Chris Wilson wrote: > On Tue, May 16, 2017 at 11:06:06AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > drm_malloc* has grown their own kmalloc with vmalloc fallback > > implementations. MM has grown kvmalloc* helpers in the meantime. Let's > > use those because it a) reduces the code and b) MM has a better idea > > how to implement fallbacks (e.g. do not vmalloc before kmalloc is tried > > with __GFP_NORETRY). > > Better? The same idea. The only difference I was reluctant to hand out > large pages for long lived objects. If that's the wisdom of the core mm, > so be it. vmalloc tends to fragment physical memory more os it is preferable to try the physically contiguous request first and only fall back to vmalloc if the first attempt would be too costly or it fails. > Reviewed-by: Chris Wilson thanks! -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org