[PATCH v2 1/8] drm/dp: Add defines for DP SDP types

[PATCH v2 1/8] drm/dp: Add defines for DP SDP types

[ville.syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Add defines for the secondary data packet (SDP) types from the spec.
These are the DP specific ones, and in addition HDMI infoframe types
(see enum hdmi_infoframe_type) are also valid SDP types.

v2: Add more SDP types

Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 include/drm/drm_dp_helper.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index f7007e544f29..8db4513b9195 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -869,6 +869,17 @@ void drm_dp_link_train_channel_eq_delay(const u8 dpcd[DP_RECEIVER_CAP_SIZE]);
 u8 drm_dp_link_rate_to_bw_code(int link_rate);
 int drm_dp_bw_code_to_link_rate(u8 link_bw);
 
+#define DP_SDP_AUDIO_TIMESTAMP		0x01
+#define DP_SDP_AUDIO_STREAM		0x02
+#define DP_SDP_EXTENSION		0x04
+#define DP_SDP_AUDIO_COPYMANAGEMENT	0x05
+#define DP_SDP_ISRC			0x06
+#define DP_SDP_VSC			0x07
+#define DP_SDP_CAMERA_GENERIC(i)	(0x08 + (i)) /* 0-7 */
+#define DP_SDP_PPS			0x10
+#define DP_SDP_VSC_EXT_VESA		0x20
+#define DP_SDP_VSC_EXT_CEA		0x21
+
 struct edp_sdp_header {
 	u8 HB0; /* Secondary Data Packet ID */
 	u8 HB1; /* Secondary Data Packet Type */
-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 1/8] drm/dp: Add defines for DP SDP types

[Rodrigo Vivi]

On Fri, May 19, 2017 at 04:17:18PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Add defines for the secondary data packet (SDP) types from the spec.
> These are the DP specific ones, and in addition HDMI infoframe types
> (see enum hdmi_infoframe_type) are also valid SDP types.
> 
> v2: Add more SDP types
> 
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  include/drm/drm_dp_helper.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index f7007e544f29..8db4513b9195 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -869,6 +869,17 @@ void drm_dp_link_train_channel_eq_delay(const u8 dpcd[DP_RECEIVER_CAP_SIZE]);
>  u8 drm_dp_link_rate_to_bw_code(int link_rate);
>  int drm_dp_bw_code_to_link_rate(u8 link_bw);
>  
> +#define DP_SDP_AUDIO_TIMESTAMP		0x01
> +#define DP_SDP_AUDIO_STREAM		0x02
> +#define DP_SDP_EXTENSION		0x04
> +#define DP_SDP_AUDIO_COPYMANAGEMENT	0x05
> +#define DP_SDP_ISRC			0x06
> +#define DP_SDP_VSC			0x07
> +#define DP_SDP_CAMERA_GENERIC(i)	(0x08 + (i)) /* 0-7 */
> +#define DP_SDP_PPS			0x10

for a moment I couldn't find this and others below, so
I checked DP 1.4 instead of the DP 1.3 and could verify that.
maybe deserves a comment /* DP 1.4 */ ?

Anyways:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> +#define DP_SDP_VSC_EXT_VESA		0x20
> +#define DP_SDP_VSC_EXT_CEA		0x21
> +
>  struct edp_sdp_header {
>  	u8 HB0; /* Secondary Data Packet ID */
>  	u8 HB1; /* Secondary Data Packet Type */
> -- 
> 2.10.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel