From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: Liviu.Dudau@arm.com, dri-devel@lists.freedesktop.org,
tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v5 1/2] drm: Add const to name field declaration in struct drm_prop_enum_list
Date: Thu, 8 Jun 2017 23:36:01 +0300 [thread overview]
Message-ID: <20170608203601.GV12629@intel.com> (raw)
In-Reply-To: <5dd3b6a1e20452bd8abdcbc55d1e8d7f56262266.1496161066.git.jsarha@ti.com>
On Tue, May 30, 2017 at 07:29:55PM +0300, Jyri Sarha wrote:
> There is no reason why the name field should not be const, but
> several why it should. The struct should only be used by
> drm_property_create_enum() and there the name-field from the struct
> is passed to drm_property_add_enum(), which takes a const char * as
> a parameter.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
Thanks for the patch. I've pushed this to drm-misc-next.
> ---
> include/drm/drm_property.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
> index 13e8c17..619868dc 100644
> --- a/include/drm/drm_property.h
> +++ b/include/drm/drm_property.h
> @@ -214,7 +214,7 @@ struct drm_property_blob {
>
> struct drm_prop_enum_list {
> int type;
> - char *name;
> + const char *name;
> };
>
> #define obj_to_property(x) container_of(x, struct drm_property, base)
> --
> 1.9.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-08 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 16:29 [PATCH v5 0/2] drm: Add properties to control YCbCr to RGB conversion Jyri Sarha
2017-05-30 16:29 ` [PATCH v5 1/2] drm: Add const to name field declaration in struct drm_prop_enum_list Jyri Sarha
2017-06-08 20:36 ` Ville Syrjälä [this message]
2017-05-30 16:29 ` [PATCH v5 2/2] drm: Add optinal COLOR_ENCODING and COLOR_RANGE properties to drm_plane Jyri Sarha
2017-05-30 21:23 ` kbuild test robot
2017-06-08 20:40 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608203601.GV12629@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Liviu.Dudau@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).