From: Puthikorn Voravootivat <puthik@chromium.org>
To: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: Puthikorn Voravootivat <puthik@chromium.org>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v12 0/3] Enhancement to intel_dp_aux_backlight driver
Date: Thu, 22 Jun 2017 12:03:36 -0700 [thread overview]
Message-ID: <20170622190339.142671-1-puthik@chromium.org> (raw)
This patch set contain 3 patches which are already reviewed by DK.
Another 6 patches in previous version was already merged in v7 and v9.
- First patch sets the PWM freqency to match data in panel vbt.
- Next patch adds heuristic to determine whether we should use AUX
or PWM pin to adjust panel backlight brightness.
- Last patch adds support for dynamic brightness.
Change log:
v12:
- Rebase
v11:
- Reorder patches in v10 to make the last patch come first
- Fix nits
v10:
- Add heuristic in patch #1
- Add _unsafe mod option in patch #1, #2
- handle frequency set error in patch #3
v9:
- Fix nits in v8
v8:
- Drop 4 patches that was already merged
- Move DP_EDP_BACKLIGHT_AUX_ENABLE_CAP check to patch #2 to avoid
behavior change if only apply patch #1
- Add TODO to warn about enable backlight twice in patch #2
- Use DIV_ROUND_CLOSEST instead of just "/" in patch #5
- Fix bug calculate pn in patch #5
- Clarify commit message / code comment in patch #5
v7:
- Add check in intel_dp_pwm_pin_display_control_capable in patch #4
- Add option in patch #6 to enable DPCD or not
- Change definition in patch #8 and implementation in #9 to use Khz
- Fix compiler warning from build bot in patch #9
v6:
- Address review from Dhinakaran
- Make PWM frequency to have highest value of Pn that make the
frequency still within 25% of desired frequency.
v5:
- Split first patch in v4 to 3 patches
- Bump priority for "Correctly enable backlight brightness adjustment via DPCD"
- Make logic clearer for the case that both PWM pin and AUX are supported
- Add more log when write to register fail
- Add log when enable DBC
v4:
- Rebase / minor typo fix.
v3:
- Add new implementation of PWM frequency patch
v2:
- Drop PWM frequency patch
- Address suggestion from Jani Nikula
Puthikorn Voravootivat (3):
drm/i915: Set PWM divider to match desired frequency in vbt
drm/i915: Add heuristic to determine better way to adjust brightness
drm/i915: Add option to support dynamic backlight via DPCD
drivers/gpu/drm/i915/i915_params.c | 12 +-
drivers/gpu/drm/i915/i915_params.h | 5 +-
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 185 ++++++++++++++++++++++++--
3 files changed, 186 insertions(+), 16 deletions(-)
--
2.13.1.611.g7e3b11ae1-goog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-06-22 19:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 19:03 Puthikorn Voravootivat [this message]
2017-06-22 19:03 ` [PATCH v12 1/3] drm/i915: Set PWM divider to match desired frequency in vbt Puthikorn Voravootivat
2017-06-22 19:03 ` [PATCH v12 2/3] drm/i915: Add heuristic to determine better way to adjust brightness Puthikorn Voravootivat
2017-06-22 19:03 ` [PATCH v12 3/3] drm/i915: Add option to support dynamic backlight via DPCD Puthikorn Voravootivat
2017-06-26 14:18 ` David Weinehall
2017-06-27 13:23 ` [Intel-gfx] " David Weinehall
2017-06-27 22:29 ` Pandiyan, Dhinakaran
2017-06-28 7:58 ` [Intel-gfx] " David Weinehall
2017-06-23 10:25 ` [PATCH v12 0/3] Enhancement to intel_dp_aux_backlight driver Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622190339.142671-1-puthik@chromium.org \
--to=puthik@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).