From: Liviu Dudau <Liviu.Dudau@arm.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Mali DP Maintainers <malidp@foss.arm.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/hdlcd: remove drm_vblank_cleanup, rise of the zoombies edition
Date: Wed, 28 Jun 2017 10:30:11 +0100 [thread overview]
Message-ID: <20170628093011.GA18607@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170628091141.14539-1-daniel.vetter@ffwll.ch>
On Wed, Jun 28, 2017 at 11:11:41AM +0200, Daniel Vetter wrote:
> This was accidentally restored in
>
> commit de5cc8155cd250a31da67dea49aff7637ce98887
> Author: Liviu Dudau <Liviu.Dudau@arm.com>
> Date: Tue Jun 6 15:05:21 2017 +0100
>
> drm/arm: hdlcd: Set the CRTC's port before binding the encoder
>
Oops, that was not the intent! Thanks for catching this!
Will pull and send a new pull request to Dave, hope I get it on time
before he leaves this week.
Best regards,
Liviu
> Fixes: de5cc8155cd2 ("drm/arm: hdlcd: Set the CRTC's port before binding the encoder.")
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Brian Starkey <brian.starkey@arm.com>
> Cc: Mali DP Maintainers <malidp@foss.arm.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index d3da87fbd85a..90bd97bf0013 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -343,7 +343,6 @@ static int hdlcd_drm_bind(struct device *dev)
> }
> err_fbdev:
> drm_kms_helper_poll_fini(drm);
> - drm_vblank_cleanup(drm);
> err_vblank:
> pm_runtime_disable(drm->dev);
> err_pm_active:
> @@ -375,7 +374,6 @@ static void hdlcd_drm_unbind(struct device *dev)
> component_unbind_all(dev, drm);
> of_node_put(hdlcd->crtc.port);
> hdlcd->crtc.port = NULL;
> - drm_vblank_cleanup(drm);
> pm_runtime_get_sync(drm->dev);
> drm_irq_uninstall(drm);
> pm_runtime_put_sync(drm->dev);
> --
> 2.11.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-28 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 9:11 [PATCH] drm/hdlcd: remove drm_vblank_cleanup, rise of the zoombies edition Daniel Vetter
2017-06-28 9:30 ` Liviu Dudau [this message]
2017-06-28 10:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628093011.GA18607@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=malidp@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).