dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm: Fix warning when building docs for scdc_helper
Date: Thu, 20 Jul 2017 20:42:48 +0200	[thread overview]
Message-ID: <20170720184248.ifbktf445ukenkk4@phenom.ffwll.local> (raw)
In-Reply-To: <20170720174746.29100-3-seanpaul@chromium.org>

On Thu, Jul 20, 2017 at 01:47:41PM -0400, Sean Paul wrote:
> Fixes:
> ../drivers/gpu/drm/drm_scdc_helper.c:203: ERROR: Unexpected indentation.
> ../drivers/gpu/drm/drm_scdc_helper.c:204: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  drivers/gpu/drm/drm_scdc_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c
> index 3cd96a95736d..53a743811298 100644
> --- a/drivers/gpu/drm/drm_scdc_helper.c
> +++ b/drivers/gpu/drm/drm_scdc_helper.c
> @@ -199,9 +199,9 @@ EXPORT_SYMBOL(drm_scdc_set_scrambling);
>   * TMDS character rate = The rate at which TMDS characters are transmitted(Mcsc)
>   * TMDS bit rate = 10x TMDS character rate
>   * As per the spec:
> - * TMDS clock rate for pixel clock < 340 MHz = 1x the character rate
> + * TMDS clock rate for pixel clock < 340 MHz = 1x the character rate \
>   *	= 1/10 pixel clock rate
> - * TMDS clock rate for pixel clock > 340 MHz = 0.25x the character rate
> + * TMDS clock rate for pixel clock > 340 MHz = 0.25x the character rate \
>   *	= 1/40 pixel clock rate

Shouldn't we make the entire thing a blockquote? I.e. indent plus on its
own line?
-Daniel

>   *
>   * Writes to the TMDS config register over SCDC channel, and:
> -- 
> 2.14.0.rc0.284.gd933b75aa4-goog
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-07-20 18:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 17:47 [PATCH 0/4] drm: Fix some warnings when building docs Sean Paul
2017-07-20 17:47 ` [PATCH 1/4] drm/modes: Fix drm_mode_is_420_only() comment Sean Paul
2017-07-20 18:41   ` Daniel Vetter
2017-07-24 15:44   ` Sharma, Shashank
2017-07-20 17:47 ` [PATCH 2/4] drm: Fix warning when building docs for scdc_helper Sean Paul
2017-07-20 18:42   ` Daniel Vetter [this message]
2017-07-20 20:09     ` [PATCH v2 " Sean Paul
     [not found]       ` <FF3DDC77922A8A4BB08A3BC48A1EA8CB8D8F6A24@BGSMSX101.gar.corp.intel.com>
2017-07-24 15:36         ` FW: " Sharma, Shashank
     [not found] ` <20170720174746.29100-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-07-20 17:47   ` [PATCH 3/4] gpu/host1x: Remove excess parameter in host1x_subdev_add docs Sean Paul
2017-07-20 17:47 ` [PATCH 4/4] drm: Add a few missing descriptions in drm_driver docs Sean Paul
2017-07-20 18:44   ` Daniel Vetter
2017-07-31 12:33 ` [PATCH 0/4] drm: Fix some warnings when building docs Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170720184248.ifbktf445ukenkk4@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox