From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/atomic: Update comment to match the code
Date: Mon, 31 Jul 2017 12:53:38 +0200 [thread overview]
Message-ID: <20170731105338.GA6345@dvetter-linux.ger.corp.intel.com> (raw)
In-Reply-To: <20170731091343.21363-1-thierry.reding@gmail.com>
On Mon, Jul 31, 2017 at 11:13:43AM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The kerneldoc for drm_atomic_crtc_needs_modeset() is outdated and no
> longer reflects the actual code. Fix that up to remove confusion.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pls push to drm-misc-next.
-Daniel
> ---
> include/drm/drm_atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> index 7cd0f303f5a3..a7adbf57b886 100644
> --- a/include/drm/drm_atomic.h
> +++ b/include/drm/drm_atomic.h
> @@ -883,7 +883,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p);
> *
> * To give drivers flexibility &struct drm_crtc_state has 3 booleans to track
> * whether the state CRTC changed enough to need a full modeset cycle:
> - * planes_changed, mode_changed and active_changed. This helper simply
> + * mode_changed, active_changed and connectors_changed. This helper simply
> * combines these three to compute the overall need for a modeset for @state.
> *
> * The atomic helper code sets these booleans, but drivers can and should
> --
> 2.13.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-07-31 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 9:13 [PATCH] drm/atomic: Update comment to match the code Thierry Reding
2017-07-31 10:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731105338.GA6345@dvetter-linux.ger.corp.intel.com \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox