From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH] drm/rockchip: Skip suspend/resume if no display is attached Date: Wed, 9 Aug 2017 16:50:43 -0700 Message-ID: <20170809235041.GA32566@google.com> References: <20170809230724.113819-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170809230724.113819-1-mka@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Kaehlcke Cc: Mark Yao , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Doug Anderson , Jeffy Chen List-Id: dri-devel@lists.freedesktop.org On Wed, Aug 09, 2017 at 04:07:24PM -0700, Matthias Kaehlcke wrote: > rockchip_drm_sys_suspend/resume() obains a struct drm_device pointer > from drvdata, the pointer is then dereferenced to obtain private data. > drvdata is set when a display is bound, on systems without a > (successfully probed) display drvdata is NULL and the PM functions > try to dereference a NULL pointer. > > The suspend/resume code relies on a valid drm_device object, skip it if > the pointer is NULL. > > Signed-off-by: Matthias Kaehlcke For the record (I believe you found this already), Jeffy sent the same patch out (to the wrong mailing lists), but it got applied a bit ago: https://cgit.freedesktop.org/drm/drm-misc/log/?h=drm-misc-fixes commit 0fa375e6bc9023211eead30a6a79963c45a563da drm/rockchip: Fix suspend crash when drm is not bound https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=0fa375e6bc9023211eead30a6a79963c45a563da Thanks, Brian