From: Greg KH <greg@kroah.com>
To: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
Cc: toru.oishi.zj@renesas.com, binh.nguyen.uw@rvc.renesas.com,
David Airlie <airlied@linux.ie>,
Archit Taneja <architt@codeaurora.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org, stable@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Thong Ho <thong.ho.px@rvc.renesas.com>
Subject: Re: [PATCH 4.4.y] drm: adv7511: Re-write the i2c address before EDID probing
Date: Fri, 8 Sep 2017 09:21:57 +0200 [thread overview]
Message-ID: <20170908072157.GB4412@kroah.com> (raw)
In-Reply-To: <20170908024602.15692-1-nhan.nguyen.yb@renesas.com>
On Fri, Sep 08, 2017 at 09:46:02AM +0700, Nhan Nguyen wrote:
> commit 3587c856675c45809010c2cee5b21096f6e8e938 upstream.
>
> I've found that by just turning the chip on and off via the
> POWER_DOWN register, I end up getting i2c_transfer errors on
> HiKey.
>
> Investigating further, it turns out that some of the register
> state in hardware is getting lost, as the device registers are
> reset when the chip is powered down.
>
> Thus this patch simply re-writes the i2c address to the
> ADV7511_REG_EDID_I2C_ADDR register to ensure its properly set
> before we try to read the EDID data.
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: stable@vger.kernel.org
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
> Signed-off-by: Thong Ho <thong.ho.px@rvc.renesas.com>
> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
> Link: http://patchwork.freedesktop.org/patch/msgid/1484614372-15342-7-git-send-email-john.stultz@linaro.org
> ---
> drivers/gpu/drm/i2c/adv7511.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Can you provide a working backport for the 4.9-stable kernel as well?
Also, please do not send backports for patches that do not also work in
newer stable kernels, like 4.9, I backported some of this series there,
but I shouldn't have to check for you.
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-08 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 2:46 [PATCH 4.4.y] drm: adv7511: Re-write the i2c address before EDID probing Nhan Nguyen
2017-09-08 7:21 ` Greg KH [this message]
2017-09-08 11:22 ` Nhan Ngoc. Nguyen
2017-09-08 12:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908072157.GB4412@kroah.com \
--to=greg@kroah.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=binh.nguyen.uw@rvc.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=nhan.nguyen.yb@renesas.com \
--cc=stable@vger.kernel.org \
--cc=thong.ho.px@rvc.renesas.com \
--cc=toru.oishi.zj@renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox