From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Date: Fri, 8 Sep 2017 14:39:49 +0100 Message-ID: <20170908133949.ekrgphd6dm4ctiih@imgtec.com> References: <20170908131704.32517-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id B28FE6EBA3 for ; Fri, 8 Sep 2017 13:39:51 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Colin King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpZGF5LCAyMDE3LTA5LTA4IDE0OjE3OjA0ICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOgo+ IEZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gCj4gVGhl IGN1cnJlbnQgZXJyb3IgaGFuZGxpbmcgb24gZGV2bV9remFsbG9jIGZhaWx1cmVzIHBlcmZvcm1z IGEgbm9uLW51bGwKPiBjaGVjayBvbiBjb25uZWN0b3IuIFRoc3MgY2hlY2sgaXMgcmVkdW5kYW50 IGJlY2F1c2UgY29ubmVjdG9yIGlzIG51bGwKPiBhdCB0aGF0IGZhaWx1cmUgcG9pbnQuICBXaXRo IHRoaXMgY2hlY2sgcmVtb3ZlZCwgd2UgbWF5IGFzIHdlbGwgbWFrZQo+IHRoZSBmYWlsdXJlIHBh dGggaW50byBhIHRyaXZpYWwgLUVOT01FTSByZXR1cm4gdG8gY2xlYW4gdXAgdGhlIGVycm9yCj4g aGFuZGxpbmcuCj4gCj4gRGV0ZWN0ZWQgYnkgQ292ZXJpdHlTY2FuIENJRCMxMzM5NTI3ICgiTG9n aWNhbGx5IGRlYWQgY29kZSIpCj4gCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNv bGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRf aGRtaS5jIHwgMTMgKystLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25z KCspLCAxMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Zj NC92YzRfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfaGRtaS5jCj4gaW5kZXggOTM3 ZGE4ZGQ2NWI4Li5hODgwOGMxYTFlMDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Zj NC92YzRfaGRtaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfaGRtaS5jCj4gQEAg LTMxMSwxNCArMzExLDExIEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqdmM0X2hkbWlf Y29ubmVjdG9yX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgewo+ICAJc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvciA9IE5VTEw7CgpUaGlzIGA9IE5VTExgIGlzbid0IG5lZWRl ZCBhbnltb3JlIGVpdGhlci4KClJldmlld2VkLWJ5OiBFcmljIEVuZ2VzdHJvbSA8ZXJpYy5lbmdl c3Ryb21AaW1ndGVjLmNvbT4KCj4gIAlzdHJ1Y3QgdmM0X2hkbWlfY29ubmVjdG9yICpoZG1pX2Nv bm5lY3RvcjsKPiAtCWludCByZXQgPSAwOwo+ICAKPiAgCWhkbWlfY29ubmVjdG9yID0gZGV2bV9r emFsbG9jKGRldi0+ZGV2LCBzaXplb2YoKmhkbWlfY29ubmVjdG9yKSwKPiAgCQkJCSAgICAgIEdG UF9LRVJORUwpOwo+IC0JaWYgKCFoZG1pX2Nvbm5lY3Rvcikgewo+IC0JCXJldCA9IC1FTk9NRU07 Cj4gLQkJZ290byBmYWlsOwo+IC0JfQo+ICsJaWYgKCFoZG1pX2Nvbm5lY3RvcikKPiArCQlyZXR1 cm4gRVJSX1BUUigtRU5PTUVNKTsKPiAgCWNvbm5lY3RvciA9ICZoZG1pX2Nvbm5lY3Rvci0+YmFz ZTsKPiAgCj4gIAloZG1pX2Nvbm5lY3Rvci0+ZW5jb2RlciA9IGVuY29kZXI7Cj4gQEAgLTMzNiwx MiArMzMzLDYgQEAgc3RhdGljIHN0cnVjdCBkcm1fY29ubmVjdG9yICp2YzRfaGRtaV9jb25uZWN0 b3JfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJZHJtX21vZGVfY29ubmVjdG9yX2F0 dGFjaF9lbmNvZGVyKGNvbm5lY3RvciwgZW5jb2Rlcik7Cj4gIAo+ICAJcmV0dXJuIGNvbm5lY3Rv cjsKPiAtCj4gLSBmYWlsOgo+IC0JaWYgKGNvbm5lY3RvcikKPiAtCQl2YzRfaGRtaV9jb25uZWN0 b3JfZGVzdHJveShjb25uZWN0b3IpOwo+IC0KPiAtCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gIH0K PiAgCj4gIHN0YXRpYyB2b2lkIHZjNF9oZG1pX2VuY29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2Vu Y29kZXIgKmVuY29kZXIpCj4gLS0gCj4gMi4xNC4xCj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=