From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH 1/7] drm/rockchip/dsi: correct Feedback divider setting Date: Fri, 22 Sep 2017 15:57:45 -0700 Message-ID: <20170922225745.GJ173745@google.com> References: <1505725539-6309-1-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x22e.google.com (mail-pg0-x22e.google.com [IPv6:2607:f8b0:400e:c05::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14A866EA64 for ; Fri, 22 Sep 2017 22:57:47 +0000 (UTC) Received: by mail-pg0-x22e.google.com with SMTP id j70so1297982pgc.10 for ; Fri, 22 Sep 2017 15:57:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1505725539-6309-1-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, bivvy.bi@rock-chips.com, hl@rock-chips.com, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, zyw@rock-chips.com, xbl@rock-chips.com List-Id: dri-devel@lists.freedesktop.org SGkgTmlja2V5LAoKRWwgTW9uLCBTZXAgMTgsIDIwMTcgYXQgMDU6MDU6MzNQTSArMDgwMCBOaWNr ZXkgWWFuZyBoYSBkaXQ6Cgo+IFRoaXMgcGF0Y2ggY29ycmVjdCBGZWVkYmFjayBkaXZpZGVyIHNl dHRpbmc6Cj4gMeOAgVNldCBGZWVkYmFjayBkaXZpZGVyIFs4OjVdIHdoZW4gSElHSF9QUk9HUkFN X0VOCj4gMuOAgUR1ZSB0byB0aGUgdXNlIG9mIGEgImJ5IDIgcHJlLXNjYWxlciwiIHRoZSByYW5n ZSBvZiB0aGUKPiBmZWVkYmFjayBtdWx0aXBsaWNhdGlvbiBGZWVkYmFjayBkaXZpZGVyIGlzIGxp bWl0ZWQgdG8gZXZlbgo+IGRpdmlzaW9uIG51bWJlcnMsIGFuZCBGZWVkYmFjayBkaXZpZGVyIG11 c3QgYmUgZ3JlYXRlciB0aGFuCj4gMTIsIGxlc3MgdGhhbiAxMDAwLgo+IDPjgIFNYWtlIHRoZSBw cmV2aW91c2x5IGNvbmZpZ3VyZWQgRmVlZGJhY2sgZGl2aWRlcihMU0IpCj4gZmFjdG9ycyBlZmZl Y3RpdmUKPiAKPiBTaWduZWQtb2ZmLWJ5OiBOaWNrZXkgWWFuZyA8bmlja2V5LnlhbmdAcm9jay1j aGlwcy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5j IHwgODMgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgNTQgaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2R3LW1pcGktZHNpLmMKPiBpbmRleCA5YTIwYjlkLi41MjY5OGI3IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMKPiBAQCAtMjI4LDcgKzIyOCw3IEBACj4g ICNkZWZpbmUgTE9XX1BST0dSQU1fRU4JCTAKPiAgI2RlZmluZSBISUdIX1BST0dSQU1fRU4JCUJJ VCg3KQo+ICAjZGVmaW5lIExPT1BfRElWX0xPV19TRUwodmFsKQkoKCh2YWwpIC0gMSkgJiAweDFm KQo+IC0jZGVmaW5lIExPT1BfRElWX0hJR0hfU0VMKHZhbCkJKCgoKHZhbCkgLSAxKSA+PiA1KSAm IDB4MWYpCj4gKyNkZWZpbmUgTE9PUF9ESVZfSElHSF9TRUwodmFsKQkoKCgodmFsKSAtIDEpID4+ IDUpICYgMHhmKQo+ICAjZGVmaW5lIFBMTF9MT09QX0RJVl9FTgkJQklUKDUpCj4gICNkZWZpbmUg UExMX0lOUFVUX0RJVl9FTglCSVQoNCkKPiAgCj4gQEAgLTQ2MSw2ICs0NjEsNyBAQCBzdGF0aWMg aW50IGR3X21pcGlfZHNpX3BoeV9pbml0KHN0cnVjdCBkd19taXBpX2RzaSAqZHNpKQo+ICAJZHdf bWlwaV9kc2lfcGh5X3dyaXRlKGRzaSwgMHgxNywgSU5QVVRfRElWSURFUihkc2ktPmlucHV0X2Rp dikpOwo+ICAJZHdfbWlwaV9kc2lfcGh5X3dyaXRlKGRzaSwgMHgxOCwgTE9PUF9ESVZfTE9XX1NF TChkc2ktPmZlZWRiYWNrX2RpdikgfAo+ICAJCQkJCSBMT1dfUFJPR1JBTV9FTik7Cj4gKwlkd19t aXBpX2RzaV9waHlfd3JpdGUoZHNpLCAweDE5LCBQTExfTE9PUF9ESVZfRU4gfCBQTExfSU5QVVRf RElWX0VOKTsKPiAgCWR3X21pcGlfZHNpX3BoeV93cml0ZShkc2ksIDB4MTgsIExPT1BfRElWX0hJ R0hfU0VMKGRzaS0+ZmVlZGJhY2tfZGl2KSB8Cj4gIAkJCQkJIEhJR0hfUFJPR1JBTV9FTik7Cj4g IAlkd19taXBpX2RzaV9waHlfd3JpdGUoZHNpLCAweDE5LCBQTExfTE9PUF9ESVZfRU4gfCBQTExf SU5QVVRfRElWX0VOKTsKPiBAQCAtNTIxLDExICs1MjIsMTYgQEAgc3RhdGljIGludCBkd19taXBp X2RzaV9waHlfaW5pdChzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSkKPiAgc3RhdGljIGludCBkd19t aXBpX2RzaV9nZXRfbGFuZV9icHMoc3RydWN0IGR3X21pcGlfZHNpICpkc2ksCj4gIAkJCQkgICAg c3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCj4gIHsKPiAtCXVuc2lnbmVkIGludCBpLCBw cmU7Cj4gLQl1bnNpZ25lZCBsb25nIG1wY2xrLCBwbGxyZWYsIHRtcDsKPiAtCXVuc2lnbmVkIGlu dCBtID0gMSwgbiA9IDEsIHRhcmdldF9tYnBzID0gMTAwMDsKPiArCXVuc2lnbmVkIGxvbmcgbXBj bGssIHRtcDsKPiArCXVuc2lnbmVkIGludCB0YXJnZXRfbWJwcyA9IDEwMDA7Cj4gIAl1bnNpZ25l ZCBpbnQgbWF4X21icHMgPSBkcHRkaW5fbWFwW0FSUkFZX1NJWkUoZHB0ZGluX21hcCkgLSAxXS5t YXhfbWJwczsKPiAgCWludCBicHA7Cj4gKwl1bnNpZ25lZCBsb25nIGJlc3RfZnJlcSA9IDA7Cj4g Kwl1bnNpZ25lZCBsb25nIGZ2Y29fbWluLCBmdmNvX21heCwgZmluICxmb3V0OwoKbml0OiBzaG91 bGQgYmUgJ2ZpbiwgZm91dCcuCgo+ICsJdW5zaWduZWQgaW50IG1pbl9wcmVkaXYsIG1heF9wcmVk aXY7Cj4gKwl1bnNpZ25lZCBpbnQgX3ByZWRpdiwgdW5pbml0aWFsaXplZF92YXIoYmVzdF9wcmVk aXYpOwo+ICsJdW5zaWduZWQgbG9uZyBfZmJkaXYsIHVuaW5pdGlhbGl6ZWRfdmFyKGJlc3RfZmJk aXYpOwo+ICsJdW5zaWduZWQgbG9uZyBtaW5fZGVsdGEgPSBVSU5UX01BWDsKPiAgCj4gIAlicHAg PSBtaXBpX2RzaV9waXhlbF9mb3JtYXRfdG9fYnBwKGRzaS0+Zm9ybWF0KTsKPiAgCWlmIChicHAg PCAwKSB7Cj4gQEAgLTU0NCwzNCArNTUwLDUzIEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfZ2V0 X2xhbmVfYnBzKHN0cnVjdCBkd19taXBpX2RzaSAqZHNpLAo+ICAJCQlkZXZfZXJyKGRzaS0+ZGV2 LCAiRFBIWSBjbG9jayBmcmVxdWVuY3kgaXMgb3V0IG9mIHJhbmdlXG4iKTsKPiAgCX0KPiAgCj4g LQlwbGxyZWYgPSBESVZfUk9VTkRfVVAoY2xrX2dldF9yYXRlKGRzaS0+cGxscmVmX2NsayksIFVT RUNfUEVSX1NFQyk7Cj4gLQl0bXAgPSBwbGxyZWY7Cj4gLQo+IC0JLyoKPiAtCSAqIFRoZSBsaW1p dHMgb24gdGhlIFBMTCBkaXZpc29yIGFyZToKPiAtCSAqCj4gLQkgKgk1TUh6IDw9IChwbGxyZWYg LyBuKSA8PSA0ME1Iego+IC0JICoKPiAtCSAqIHdlIHdhbGsgb3ZlciB0aGVzZSB2YWx1ZXMgaW4g ZGVzY3JlYXNpbmcgb3JkZXIgc28gdGhhdCBpZiB3ZSBoaXQKPiAtCSAqIGFuIGV4YWN0IG1hdGNo IGZvciB0YXJnZXRfbWJwcyBpdCBpcyBtb3JlIGxpa2VseSB0aGF0ICJtIiB3aWxsIGJlCj4gLQkg KiBldmVuLgo+IC0JICoKPiAtCSAqIFRPRE86IGVuc3VyZSB0aGF0ICJtIiBpcyBldmVuIGFmdGVy IHRoaXMgbG9vcC4KPiAtCSAqLwo+IC0JZm9yIChpID0gcGxscmVmIC8gNTsgaSA+IChwbGxyZWYg LyA0MCk7IGktLSkgewo+IC0JCXByZSA9IHBsbHJlZiAvIGk7Cj4gLQkJaWYgKCh0bXAgPiAodGFy Z2V0X21icHMgJSBwcmUpKSAmJiAodGFyZ2V0X21icHMgLyBwcmUgPCA1MTIpKSB7Cj4gLQkJCXRt cCA9IHRhcmdldF9tYnBzICUgcHJlOwo+IC0JCQluID0gaTsKPiAtCQkJbSA9IHRhcmdldF9tYnBz IC8gcHJlOwo+ICsJZmluID0gY2xrX2dldF9yYXRlKGRzaS0+cGxscmVmX2Nsayk7Cj4gKwlmb3V0 ID0gdGFyZ2V0X21icHMgKiBVU0VDX1BFUl9TRUM7Cj4gKwo+ICsJLyogY29uc3RyYWludDogNU1o eiA8IEZyZWYgLyBOIDwgNDBNSHogKi8KCkFjY29yZGluZyB0byB0aGUgcHJldmlvdXMgY29tbWVu dCBhYm92ZSBpdCBzaG91bGQgYmUgJzw9JyBpbnN0ZWFkIG9mCic8Jy4KCj4gKwltaW5fcHJlZGl2 ID0gRElWX1JPVU5EX1VQKGZpbiwgNDAgKiBVU0VDX1BFUl9TRUMpOwo+ICsJbWF4X3ByZWRpdiA9 IGZpbiAvICg1ICogVVNFQ19QRVJfU0VDKTsKPiArCj4gKwkvKiBjb25zdHJhaW50OiA4ME1IeiA8 IEZ2Y28gPCAxNTAwTWh6ICovCgpTYW1lIGhlcmUuCgo+ICsJZnZjb19taW4gPSA4MCAqIFVTRUNf UEVSX1NFQzsKPiArCWZ2Y29fbWF4ID0gMTUwMCAqIFVTRUNfUEVSX1NFQzsKPiArCj4gKwlmb3Ig KF9wcmVkaXYgPSBtaW5fcHJlZGl2OyBfcHJlZGl2IDw9IG1heF9wcmVkaXY7IF9wcmVkaXYrKykg ewo+ICsJCXUzMiBkZWx0YTsKPiArCQkvKiBGdmNvID0gRnJlZiAqIE0gLyBOICovCj4gKwkJdG1w ID0gZm91dCAqIF9wcmVkaXY7Cj4gKwkJZG9fZGl2KHRtcCwgZmluKTsKPiArCQlfZmJkaXYgPSB0 bXA7Cj4gKwkJLyoKPiArCQkgKiBEdWUgdG8gdGhlIHVzZSBvZiBhICJieSAyIHByZS1zY2FsZXIs IiB0aGUgcmFuZ2Ugb2YgdGhlCj4gKwkJICogZmVlZGJhY2sgbXVsdGlwbGljYXRpb24gdmFsdWUg TSBpcyBsaW1pdGVkIHRvIGV2ZW4gZGl2aXNpb24KPiArCQkgKiBudW1iZXJzLCBhbmQgbSBtdXN0 IGJlIGdyZWF0ZXIgdGhhbiAxMiwgbGVzcyB0aGFuIDEwMDAuCj4gKwkJICovCgpJIGRpZG4ndCBl bmNvdW50ZXIgdGhlIHNlY29uZCBwYXJ0IG9mIHRoZSBjb25zdHJhaW50IGluIG15IHZlcnNpb24g b2YKdGhlIGRhdGFib29rLCBqdWRnaW5nIGZyb20gdGhlIGNvZGUgYmVsb3cgaXQgc2VlbXMgdGhl IGNvbW1lbnQgc2hvdWxkCmJlICIxMiA8PSBtIDw9IDEwMDAiLgoKPiArCQlpZiAoX2ZiZGl2IDwg MTIgfHwgX2ZiZGl2ID4gMTAwMCkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCWlmIChfZmJkaXYg JSAyKQo+ICsJCQkrK19mYmRpdjsKPiArCj4gKwkJdG1wID0gKHU2NClfZmJkaXYgKiBmaW47Cj4g KwkJZG9fZGl2KHRtcCwgX3ByZWRpdik7Cj4gKwkJaWYgKHRtcCA8IGZ2Y29fbWluIHx8IHRtcCA+ IGZ2Y29fbWF4KQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJZGVsdGEgPSBhYnMoZm91dCAtIHRt cCk7Cj4gKwkJaWYgKGRlbHRhIDwgbWluX2RlbHRhKSB7Cj4gKwkJCWJlc3RfcHJlZGl2ID0gX3By ZWRpdjsKPiArCQkJYmVzdF9mYmRpdiA9IF9mYmRpdjsKPiArCQkJbWluX2RlbHRhID0gZGVsdGE7 Cj4gKwkJCWJlc3RfZnJlcSA9IHRtcDsKPiAgCQl9Cj4gLQkJaWYgKHRtcCA9PSAwKQo+IC0JCQli cmVhazsKPiAgCX0KPiAgCj4gLQlkc2ktPmxhbmVfbWJwcyA9IHBsbHJlZiAvIG4gKiBtOwo+IC0J ZHNpLT5pbnB1dF9kaXYgPSBuOwo+IC0JZHNpLT5mZWVkYmFja19kaXYgPSBtOwo+ICsJaWYgKGJl c3RfZnJlcSkgewo+ICsJCWRzaS0+bGFuZV9tYnBzID0gRElWX1JPVU5EX1VQKGJlc3RfZnJlcSwg VVNFQ19QRVJfU0VDKTsKPiArCQlkc2ktPmlucHV0X2RpdiA9IGJlc3RfcHJlZGl2Owo+ICsJCWRz aS0+ZmVlZGJhY2tfZGl2ID0gYmVzdF9mYmRpdjsKPiArCX0KPiAgCj4gIAlyZXR1cm4gMDsKPiAg fQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK