Re: [PATCH v4 2/3] drm/tinydrm: Add devres versions of drm_of_find_backlight

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3446 bytes --]

Hi Meghana,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.14-rc2 next-20170929]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Meghana-Madhyastha/drm-tinydrm-drm_of_find_backlight-helper/20170930-122931
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-randconfig-x017-201739 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Meghana-Madhyastha/drm-tinydrm-drm_of_find_backlight-helper/20170930-122931 HEAD 4dc8fd20ad41e923832dc78cf4d8e7f98c0fedb9 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/gpu/drm/tinydrm/mi0283qt.c: In function 'mi0283qt_probe':
>> drivers/gpu/drm/tinydrm/mi0283qt.c:192:20: error: implicit declaration of function 'devm_drm_of_find_backlight' [-Werror=implicit-function-declaration]
     mipi->backlight = devm_drm_of_find_backlight(dev);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/tinydrm/mi0283qt.c:192:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     mipi->backlight = devm_drm_of_find_backlight(dev);
                     ^
   cc1: some warnings being treated as errors

vim +/devm_drm_of_find_backlight +192 drivers/gpu/drm/tinydrm/mi0283qt.c

   163	
   164	static int mi0283qt_probe(struct spi_device *spi)
   165	{
   166		struct device *dev = &spi->dev;
   167		struct mipi_dbi *mipi;
   168		struct gpio_desc *dc;
   169		u32 rotation = 0;
   170		int ret;
   171	
   172		mipi = devm_kzalloc(dev, sizeof(*mipi), GFP_KERNEL);
   173		if (!mipi)
   174			return -ENOMEM;
   175	
   176		mipi->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
   177		if (IS_ERR(mipi->reset)) {
   178			dev_err(dev, "Failed to get gpio 'reset'\n");
   179			return PTR_ERR(mipi->reset);
   180		}
   181	
   182		dc = devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW);
   183		if (IS_ERR(dc)) {
   184			dev_err(dev, "Failed to get gpio 'dc'\n");
   185			return PTR_ERR(dc);
   186		}
   187	
   188		mipi->regulator = devm_regulator_get(dev, "power");
   189		if (IS_ERR(mipi->regulator))
   190			return PTR_ERR(mipi->regulator);
   191	
 > 192		mipi->backlight = devm_drm_of_find_backlight(dev);
   193		if (IS_ERR(mipi->backlight))
   194			return PTR_ERR(mipi->backlight);
   195	
   196		device_property_read_u32(dev, "rotation", &rotation);
   197	
   198		ret = mipi_dbi_spi_init(spi, mipi, dc);
   199		if (ret)
   200			return ret;
   201	
   202		ret = mipi_dbi_init(&spi->dev, mipi, &mi0283qt_pipe_funcs,
   203				    &mi0283qt_driver, &mi0283qt_mode, rotation);
   204		if (ret)
   205			return ret;
   206	
   207		ret = mi0283qt_init(mipi);
   208		if (ret)
   209			return ret;
   210	
   211		/* use devres to fini after drm unregister (drv->remove is before) */
   212		ret = devm_add_action(dev, mi0283qt_fini, mipi);
   213		if (ret) {
   214			mi0283qt_fini(mipi);
   215			return ret;
   216		}
   217	
   218		spi_set_drvdata(spi, mipi);
   219	
   220		return devm_tinydrm_register(&mipi->tinydrm);
   221	}
   222	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29255 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel