From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions. Date: Wed, 11 Oct 2017 13:51:45 +0200 Message-ID: <20171011135145.6701b38a@bbrezillon> References: <20170817210455.17885-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id C7E7F6E1C8 for ; Wed, 11 Oct 2017 11:51:46 +0000 (UTC) In-Reply-To: <20170817210455.17885-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxNyBBdWcgMjAxNyAxNDowNDo1NSAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gVkM0J3MgRFNJMSBoYXMgYSBidWcgd2hlcmUgdGhlIEFYSSBjb25u ZWN0aW9uIGlzIGJyb2tlbiBmb3IgMzItYml0Cj4gd3JpdGVzIGZyb20gdGhlIENQVSwgc28gd2Ug dXNlIHRoZSBETUEgZW5naW5lIHRvIERNQSAzMi1iaXQgdmFsdWVzCj4gaW50byByZWdpc3RlcnMg aW5zdGVhZC4gIFRoYXQgc2xlZXBzLCBzbyB3ZSBjYW4ndCBkbyBpdCBmcm9tIHRoZSB0b3AKPiBo YWxmLgo+IAo+IEFzIGEgc29sdXRpb24gKHN1Z2dlc3RlZCBieSBBcm5kKSwgd2UgY2FuIG1hc2sg dGhlIElSUSBpbiB0aGUgaXJxY2hpcAo+IGluIHRoZSB0b3AgaGFsZiwgYW5kIHJlLWVuYWJsZSBp dCBmcm9tIGFuIGlycXRocmVhZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBFcmljIEFuaG9sdCA8ZXJp Y0BhbmhvbHQubmV0Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kc2kuYyB8IDM5 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMzcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kc2ku Ywo+IGluZGV4IGVjMWQ2NDZiMzE1MS4uOTU1NjIzNmI2N2QwIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS92YzQvdmM0X2RzaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRf ZHNpLmMKPiBAQCAtNTE2LDYgKzUxNiw4IEBAIHN0cnVjdCB2YzRfZHNpIHsKPiAgCS8qIFdoZXRo ZXIgd2UncmUgb24gYmNtMjgzNSdzIERTSTAgb3IgRFNJMS4gKi8KPiAgCWludCBwb3J0Owo+ICAK PiArCWludCBpcnE7Cj4gKwo+ICAJLyogRFNJIGNoYW5uZWwgZm9yIHRoZSBwYW5lbCB3ZSdyZSBj b25uZWN0ZWQgdG8uICovCj4gIAl1MzIgY2hhbm5lbDsKPiAgCXUzMiBsYW5lczsKPiBAQCAtMTM2 MCw2ICsxMzYyLDI4IEBAIHN0YXRpYyB2b2lkIGRzaV9oYW5kbGVfZXJyb3Ioc3RydWN0IHZjNF9k c2kgKmRzaSwKPiAgCSpyZXQgPSBJUlFfSEFORExFRDsKPiAgfQo+ICAKPiArLyogSW5pdGlhbCBo YW5kbGVyIGZvciBwb3J0IDEgd2hlcmUgd2UgbmVlZCB0aGUgcmVnX2RtYSB3b3JrYXJvdW5kLgo+ ICsgKiBUaGUgcmVnaXN0ZXIgRE1BIHdyaXRlcyBzbGVlcCwgc28gd2UgY2FuJ3QgZG8gaXQgaW4g dGhlIHRvcCBoYWxmLgo+ICsgKiBJbnN0ZWFkIHdlIGp1c3QgZGlzYWJsZSB0aGUgaW50ZXJydXB0 IGluIHRoZSBvbmx5IHdheSB3ZSBoYXZlCj4gKyAqIGF2YWlsYWJsZSAobWFzayBpdCBpbiB0aGUg aXJxY2hpcCksIGFuZCBjb250aW51ZSBvbiB0byB0aGUgdGhyZWFkZWQKPiArICogaGFuZGxlci4K PiArICovCj4gK3N0YXRpYyBpcnFyZXR1cm5fdCB2YzRfZHNpX2lycV9kZWZlcl90b190aHJlYWRf aGFuZGxlcihpbnQgaXJxLCB2b2lkICpkYXRhKQo+ICt7Cj4gKwlzdHJ1Y3QgdmM0X2RzaSAqZHNp ID0gZGF0YTsKPiArCXUzMiBzdGF0ID0gRFNJX1BPUlRfUkVBRChJTlRfU1RBVCk7Cj4gKwo+ICsJ aWYgKCFzdGF0KQo+ICsJCXJldHVybiBJUlFfTk9ORTsKPiArCj4gKwlkaXNhYmxlX2lycV9ub3N5 bmMoZHNpLT5pcnEpOwoKQXJlIHlvdSBzdXJlIHlvdSBuZWVkIHRvIGV4cGxpY2l0bHkgZGlzYWJs ZSB0aGUgSVJRIGhlcmU/IERpZCB5b3UgdHJ5CndpdGggYW4gSVJRRl9PTkVTSE9UIGZsYWcgd2hl biByZWdpc3RlcmluZyB5b3VyIGlycSBoYW5kbGVyICh0aGlzCnNob3VsZCBkbyBleGFjdGx5IHdo YXQgeW91J3JlIGRvaW5nIGhlcmU6IG1hc2sgdGhlIGludGVycnVwdCB1bnRpbAp0aGUgdGhyZWFk ZWQgaGFuZGxlciByZXR1cm5zIElSUV9ET05FIG9yIElSUV9OT05FIFsxXSk/CgpbMV1odHRwOi8v ZWxpeGlyLmZyZWUtZWxlY3Ryb25zLmNvbS9saW51eC92NC4zLjIvc291cmNlL2luY2x1ZGUvbGlu dXgvaW50ZXJydXB0LmgjTDUwCgo+ICsKPiArCXJldHVybiBJUlFfV0FLRV9USFJFQUQ7Cj4gK30K PiArCj4gKy8qIE5vcm1hbCBJUlEgaGFuZGxlciBmb3IgcG9ydCAwLCBvciB0aGUgdGhyZWFkZWQg SVJRIGhhbmRsZXIgZm9yIHBvcnQKPiArICogMSB3aGVyZSB3ZSBuZWVkIHRoZSByZWdfZG1hIHdv cmthcm91bmQuCj4gKyAqLwo+ICBzdGF0aWMgaXJxcmV0dXJuX3QgdmM0X2RzaV9pcnFfaGFuZGxl cihpbnQgaXJxLCB2b2lkICpkYXRhKQo+ICB7Cj4gIAlzdHJ1Y3QgdmM0X2RzaSAqZHNpID0gZGF0 YTsKPiBAQCAtMTM2OCw2ICsxMzkyLDkgQEAgc3RhdGljIGlycXJldHVybl90IHZjNF9kc2lfaXJx X2hhbmRsZXIoaW50IGlycSwgdm9pZCAqZGF0YSkKPiAgCj4gIAlEU0lfUE9SVF9XUklURShJTlRf U1RBVCwgc3RhdCk7Cj4gIAo+ICsJaWYgKGRzaS0+cmVnX2RtYV9tZW0pCj4gKwkJZW5hYmxlX2ly cShkc2ktPmlycSk7Cj4gKwo+ICAJZHNpX2hhbmRsZV9lcnJvcihkc2ksICZyZXQsIHN0YXQsCj4g IAkJCSBEU0kxX0lOVF9FUlJfU1lOQ19FU0MsICJMUERUIHN5bmMiKTsKPiAgCWRzaV9oYW5kbGVf ZXJyb3IoZHNpLCAmcmV0LCBzdGF0LAo+IEBAIC0xNTM5LDggKzE1NjYsMTYgQEAgc3RhdGljIGlu dCB2YzRfZHNpX2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIs IHZvaWQgKmRhdGEpCj4gIAkvKiBDbGVhciBhbnkgZXhpc3RpbmcgaW50ZXJydXB0IHN0YXRlLiAq Lwo+ICAJRFNJX1BPUlRfV1JJVEUoSU5UX1NUQVQsIERTSV9QT1JUX1JFQUQoSU5UX1NUQVQpKTsK PiAgCj4gLQlyZXQgPSBkZXZtX3JlcXVlc3RfaXJxKGRldiwgcGxhdGZvcm1fZ2V0X2lycShwZGV2 LCAwKSwKPiAtCQkJICAgICAgIHZjNF9kc2lfaXJxX2hhbmRsZXIsIDAsICJ2YzQgZHNpIiwgZHNp KTsKPiArCWRzaS0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKPiArCWlmIChkc2kt PnJlZ19kbWFfbWVtKSB7Cj4gKwkJcmV0ID0gZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycShkZXYs IGRzaS0+aXJxLAo+ICsJCQkJCQl2YzRfZHNpX2lycV9kZWZlcl90b190aHJlYWRfaGFuZGxlciwK PiArCQkJCQkJdmM0X2RzaV9pcnFfaGFuZGxlciwgMCwKPiArCQkJCQkJInZjNCBkc2kiLCBkc2kp Owo+ICsJfSBlbHNlIHsKPiArCQlyZXQgPSBkZXZtX3JlcXVlc3RfaXJxKGRldiwgZHNpLT5pcnEs Cj4gKwkJCQkgICAgICAgdmM0X2RzaV9pcnFfaGFuZGxlciwgMCwgInZjNCBkc2kiLCBkc2kpOwo+ ICsJfQo+ICAJaWYgKHJldCkgewo+ICAJCWlmIChyZXQgIT0gLUVQUk9CRV9ERUZFUikKPiAgCQkJ ZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IGludGVycnVwdDogJWRcbiIsIHJldCk7CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK