From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v6 3/5] drm/vc4: Set up the DSI host at pdev probe time, not component bind. Date: Wed, 11 Oct 2017 14:01:24 +0200 Message-ID: <20171011140124.37551ea0@bbrezillon> References: <20170815234722.20700-1-eric@anholt.net> <20170815234722.20700-3-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 723376E652 for ; Wed, 11 Oct 2017 12:01:25 +0000 (UTC) In-Reply-To: <20170815234722.20700-3-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxNSBBdWcgMjAxNyAxNjo0NzoyMCAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gV2UgbmVlZCB0aGUgZm9sbG93aW5nIHRoaW5ncyB0byBoYXBwZW4g aW4gc2VxdWVuY2U6Cj4gCj4gRFNJIGhvc3QgY3JlYXRpb24KPiBEU0kgZGV2aWNlIGNyZWF0aW9u IGluIHRoZSBwYW5lbCBkcml2ZXIgKG5lZWRzIERTSSBob3N0KQo+IERTSSBkZXZpY2UgYXR0YWNo IGZyb20gcGFuZWwgdG8gaG9zdC4KPiBEU0kgZHJtX3BhbmVsX2FkZCgpCj4gRFNJIGVuY29kZXIg Y3JlYXRpb24KPiBEU0kgZW5jb2RlcidzIERSTSBwYW5lbC9icmlkZ2UgYXR0YWNoCj4gCj4gVW5s ZXNzIHdlIGFsbG93IGRldmljZSBjcmVhdGlvbiB3aGlsZSB0aGUgaG9zdCBpc24ndCB1cCB5ZXQs IHdlIG5lZWQKPiB0byBicmVhayB0aGUgLUVQUk9CRV9ERUZFUiBkZWFkbG9jayBiZXR3ZWVuIHRo ZSBwYW5lbCBkcml2ZXIgbG9va2luZwo+IHVwIHRoZSBob3N0IGFuZCB0aGUgaG9zdCBkcml2ZXIg bG9va2luZyB1cCB0aGUgcGFuZWwuICBXZSBjYW4gZG8gc28gYnkKPiBtb3ZpbmcgdGhlIERTSSBo b3N0IGNyZWF0aW9uIG91dHNpZGUgb2YgdGhlIGNvbXBvbmVudCBiaW5kIGxvb3AsIGFuZAo+IHRo ZSBwYW5lbC9icmlkZ2UgbG9va3VwL2F0dGFjaCBpbnRvIHRoZSBjb21wb25lbnQgYmluZCBwcm9j ZXNzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+CgpS ZXZpZXdlZC1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJv bnMuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHNpLmMgfCA5NyArKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA1NyBpbnNlcnRpb25zKCspLCA0MCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kc2ku Ywo+IGluZGV4IDI1MTZjZDNhMWQ4Ny4uZWMxZDY0NmIzMTUxIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS92YzQvdmM0X2RzaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRf ZHNpLmMKPiBAQCAtMzMsNiArMzMsNyBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBl ci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9lZGlkLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX21p cGlfZHNpLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX29mLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJt X3BhbmVsLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9jbGsuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2Ns ay1wcm92aWRlci5oPgo+IEBAIC01MDQsNyArNTA1LDYgQEAgc3RydWN0IHZjNF9kc2kgewo+ICAJ c3RydWN0IG1pcGlfZHNpX2hvc3QgZHNpX2hvc3Q7Cj4gIAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVu Y29kZXI7Cj4gIAlzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlOwo+IC0JYm9vbCBpc19wYW5lbF9i cmlkZ2U7Cj4gIAo+ICAJdm9pZCBfX2lvbWVtICpyZWdzOwo+ICAKPiBAQCAtMTI4OSw3ICsxMjg5 LDYgQEAgc3RhdGljIGludCB2YzRfZHNpX2hvc3RfYXR0YWNoKHN0cnVjdCBtaXBpX2RzaV9ob3N0 ICpob3N0LAo+ICAJCQkgICAgICAgc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZGV2aWNlKQo+ICB7 Cj4gIAlzdHJ1Y3QgdmM0X2RzaSAqZHNpID0gaG9zdF90b19kc2koaG9zdCk7Cj4gLQlpbnQgcmV0 ID0gMDsKPiAgCj4gIAlkc2ktPmxhbmVzID0gZGV2aWNlLT5sYW5lczsKPiAgCWRzaS0+Y2hhbm5l bCA9IGRldmljZS0+Y2hhbm5lbDsKPiBAQCAtMTMyNCwzNCArMTMyMywxMiBAQCBzdGF0aWMgaW50 IHZjNF9kc2lfaG9zdF9hdHRhY2goc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3QsCj4gIAkJcmV0 dXJuIDA7Cj4gIAl9Cj4gIAo+IC0JZHNpLT5icmlkZ2UgPSBvZl9kcm1fZmluZF9icmlkZ2UoZGV2 aWNlLT5kZXYub2Zfbm9kZSk7Cj4gLQlpZiAoIWRzaS0+YnJpZGdlKSB7Cj4gLQkJc3RydWN0IGRy bV9wYW5lbCAqcGFuZWwgPQo+IC0JCQlvZl9kcm1fZmluZF9wYW5lbChkZXZpY2UtPmRldi5vZl9u b2RlKTsKPiAtCj4gLQkJZHNpLT5icmlkZ2UgPSBkcm1fcGFuZWxfYnJpZGdlX2FkZChwYW5lbCwK PiAtCQkJCQkJICAgRFJNX01PREVfQ09OTkVDVE9SX0RTSSk7Cj4gLQkJaWYgKElTX0VSUihkc2kt PmJyaWRnZSkpIHsKPiAtCQkJcmV0ID0gUFRSX0VSUihkc2ktPmJyaWRnZSk7Cj4gLQkJCWRzaS0+ YnJpZGdlID0gTlVMTDsKPiAtCQkJcmV0dXJuIHJldDsKPiAtCQl9Cj4gLQkJZHNpLT5pc19wYW5l bF9icmlkZ2UgPSB0cnVlOwo+IC0JfQo+IC0KPiAtCXJldHVybiBkcm1fYnJpZGdlX2F0dGFjaChk c2ktPmVuY29kZXIsIGRzaS0+YnJpZGdlLCBOVUxMKTsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ ICBzdGF0aWMgaW50IHZjNF9kc2lfaG9zdF9kZXRhY2goc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhv c3QsCj4gIAkJCSAgICAgICBzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkZXZpY2UpCj4gIHsKPiAt CXN0cnVjdCB2YzRfZHNpICpkc2kgPSBob3N0X3RvX2RzaShob3N0KTsKPiAtCj4gLQlpZiAoZHNp LT5pc19wYW5lbF9icmlkZ2UpIHsKPiAtCQlkcm1fcGFuZWxfYnJpZGdlX3JlbW92ZShkc2ktPmJy aWRnZSk7Cj4gLQkJZHNpLT5icmlkZ2UgPSBOVUxMOwo+IC0JfQo+IC0KPiAgCXJldHVybiAwOwo+ ICB9Cj4gIAo+IEBAIC0xNDkzLDE2ICsxNDcwLDEzIEBAIHN0YXRpYyBpbnQgdmM0X2RzaV9iaW5k KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+ ICAJc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiA9IHRvX3BsYXRmb3JtX2RldmljZShkZXYp Owo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IGRldl9nZXRfZHJ2ZGF0YShtYXN0ZXIpOwo+ ICAJc3RydWN0IHZjNF9kZXYgKnZjNCA9IHRvX3ZjNF9kZXYoZHJtKTsKPiAtCXN0cnVjdCB2YzRf ZHNpICpkc2k7Cj4gKwlzdHJ1Y3QgdmM0X2RzaSAqZHNpID0gZGV2X2dldF9kcnZkYXRhKGRldik7 Cj4gIAlzdHJ1Y3QgdmM0X2RzaV9lbmNvZGVyICp2YzRfZHNpX2VuY29kZXI7Cj4gKwlzdHJ1Y3Qg ZHJtX3BhbmVsICpwYW5lbDsKPiAgCWNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm1hdGNoOwo+ ICAJZG1hX2NhcF9tYXNrX3QgZG1hX21hc2s7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWRzaSA9IGRl dm1fa3phbGxvYyhkZXYsIHNpemVvZigqZHNpKSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAoIWRzaSkK PiAtCQlyZXR1cm4gLUVOT01FTTsKPiAtCj4gIAltYXRjaCA9IG9mX21hdGNoX2RldmljZSh2YzRf ZHNpX2R0X21hdGNoLCBkZXYpOwo+ICAJaWYgKCFtYXRjaCkKPiAgCQlyZXR1cm4gLUVOT0RFVjsK PiBAQCAtMTUxNyw3ICsxNDkxLDYgQEAgc3RhdGljIGludCB2YzRfZHNpX2JpbmQoc3RydWN0IGRl dmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gIAl2YzRfZHNp X2VuY29kZXItPmRzaSA9IGRzaTsKPiAgCWRzaS0+ZW5jb2RlciA9ICZ2YzRfZHNpX2VuY29kZXIt PmJhc2UuYmFzZTsKPiAgCj4gLQlkc2ktPnBkZXYgPSBwZGV2Owo+ICAJZHNpLT5yZWdzID0gdmM0 X2lvcmVtYXBfcmVncyhwZGV2LCAwKTsKPiAgCWlmIChJU19FUlIoZHNpLT5yZWdzKSkKPiAgCQly ZXR1cm4gUFRSX0VSUihkc2ktPnJlZ3MpOwo+IEBAIC0xNTk4LDYgKzE1NzEsMTggQEAgc3RhdGlj IGludCB2YzRfZHNpX2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0 ZXIsIHZvaWQgKmRhdGEpCj4gIAkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4gKwlyZXQgPSBkcm1f b2ZfZmluZF9wYW5lbF9vcl9icmlkZ2UoZGV2LT5vZl9ub2RlLCAwLCAwLAo+ICsJCQkJCSAgJnBh bmVsLCAmZHNpLT5icmlkZ2UpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiAr CWlmIChwYW5lbCkgewo+ICsJCWRzaS0+YnJpZGdlID0gZGV2bV9kcm1fcGFuZWxfYnJpZGdlX2Fk ZChkZXYsIHBhbmVsLAo+ICsJCQkJCQkJRFJNX01PREVfQ09OTkVDVE9SX0RTSSk7Cj4gKwkJaWYg KElTX0VSUihkc2ktPmJyaWRnZSkpCj4gKwkJCXJldHVybiBQVFJfRVJSKGRzaS0+YnJpZGdlKTsK PiArCX0KPiArCj4gIAkvKiBUaGUgZXNjIGNsb2NrIHJhdGUgaXMgc3VwcG9zZWQgdG8gYWx3YXlz IGJlIDEwME1oei4gKi8KPiAgCXJldCA9IGNsa19zZXRfcmF0ZShkc2ktPmVzY2FwZV9jbG9jaywg MTAwICogMTAwMDAwMCk7Cj4gIAlpZiAocmV0KSB7Cj4gQEAgLTE2MTYsMTIgKzE2MDEsMTEgQEAg c3RhdGljIGludCB2YzRfZHNpX2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNl ICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gIAkJCSBEUk1fTU9ERV9FTkNPREVSX0RTSSwgTlVMTCk7 Cj4gIAlkcm1fZW5jb2Rlcl9oZWxwZXJfYWRkKGRzaS0+ZW5jb2RlciwgJnZjNF9kc2lfZW5jb2Rl cl9oZWxwZXJfZnVuY3MpOwo+ICAKPiAtCWRzaS0+ZHNpX2hvc3Qub3BzID0gJnZjNF9kc2lfaG9z dF9vcHM7Cj4gLQlkc2ktPmRzaV9ob3N0LmRldiA9IGRldjsKPiAtCj4gLQltaXBpX2RzaV9ob3N0 X3JlZ2lzdGVyKCZkc2ktPmRzaV9ob3N0KTsKPiAtCj4gLQlkZXZfc2V0X2RydmRhdGEoZGV2LCBk c2kpOwo+ICsJcmV0ID0gZHJtX2JyaWRnZV9hdHRhY2goZHNpLT5lbmNvZGVyLCBkc2ktPmJyaWRn ZSwgTlVMTCk7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJZGV2X2VycihkZXYsICJicmlkZ2UgYXR0YWNo IGZhaWxlZDogJWRcbiIsIHJldCk7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiAgCj4gIAlwbV9y dW50aW1lX2VuYWJsZShkZXYpOwo+ICAKPiBAQCAtMTYzOSw4ICsxNjIzLDYgQEAgc3RhdGljIHZv aWQgdmM0X2RzaV91bmJpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0 ZXIsCj4gIAo+ICAJdmM0X2RzaV9lbmNvZGVyX2Rlc3Ryb3koZHNpLT5lbmNvZGVyKTsKPiAgCj4g LQltaXBpX2RzaV9ob3N0X3VucmVnaXN0ZXIoJmRzaS0+ZHNpX2hvc3QpOwo+IC0KPiAgCWlmIChk c2ktPnBvcnQgPT0gMSkKPiAgCQl2YzQtPmRzaTEgPSBOVUxMOwo+ICB9Cj4gQEAgLTE2NTIsMTIg KzE2MzQsNDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBjb21wb25lbnRfb3BzIHZjNF9kc2lfb3Bz ID0gewo+ICAKPiAgc3RhdGljIGludCB2YzRfZHNpX2Rldl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ICB7Cj4gLQlyZXR1cm4gY29tcG9uZW50X2FkZCgmcGRldi0+ZGV2LCAm dmM0X2RzaV9vcHMpOwo+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCXN0 cnVjdCB2YzRfZHNpICpkc2k7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWRzaSA9IGRldm1fa3phbGxv YyhkZXYsIHNpemVvZigqZHNpKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWRzaSkKPiArCQlyZXR1 cm4gLUVOT01FTTsKPiArCWRldl9zZXRfZHJ2ZGF0YShkZXYsIGRzaSk7Cj4gKwo+ICsJZHNpLT5w ZGV2ID0gcGRldjsKPiArCj4gKwkvKiBOb3RlLCB0aGUgaW5pdGlhbGl6YXRpb24gc2VxdWVuY2Ug Zm9yIERTSSBhbmQgcGFuZWxzIGlzCj4gKwkgKiB0cmlja3kuICBUaGUgY29tcG9uZW50IGJpbmQg YWJvdmUgd29uJ3QgZ2V0IHBhc3QgaXRzCj4gKwkgKiAtRVBST0JFX0RFRkVSIHVudGlsIHRoZSBw YW5lbC9icmlkZ2UgcHJvYmVzLiAgVGhlCj4gKwkgKiBwYW5lbC9icmlkZ2Ugd2lsbCByZXR1cm4g LUVQUk9CRV9ERUZFUiB1bnRpbCBpdCBoYXMgYQo+ICsJICogbWlwaV9kc2lfaG9zdCB0byByZWdp c3RlciBpdHMgZGV2aWNlIHRvLiAgU28sIHdlIHJlZ2lzdGVyCj4gKwkgKiB0aGUgaG9zdCBkdXJp bmcgcGRldiBwcm9iZSB0aW1lLCBzbyB2YzQgYXMgYSB3aG9sZSBjYW4gdGhlbgo+ICsJICogLUVQ Uk9CRV9ERUZFUiBpdHMgY29tcG9uZW50IGJpbmQgcHJvY2VzcyB1bnRpbCB0aGUgcGFuZWwKPiAr CSAqIHN1Y2Nlc3NmdWxseSBhdHRhY2hlcy4KPiArCSAqLwo+ICsJZHNpLT5kc2lfaG9zdC5vcHMg PSAmdmM0X2RzaV9ob3N0X29wczsKPiArCWRzaS0+ZHNpX2hvc3QuZGV2ID0gZGV2Owo+ICsJbWlw aV9kc2lfaG9zdF9yZWdpc3RlcigmZHNpLT5kc2lfaG9zdCk7Cj4gKwo+ICsJcmV0ID0gY29tcG9u ZW50X2FkZCgmcGRldi0+ZGV2LCAmdmM0X2RzaV9vcHMpOwo+ICsJaWYgKHJldCkgewo+ICsJCW1p cGlfZHNpX2hvc3RfdW5yZWdpc3RlcigmZHNpLT5kc2lfaG9zdCk7Cj4gKwkJcmV0dXJuIHJldDsK PiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCB2YzRfZHNpX2Rl dl9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgewo+ICsJc3RydWN0IGRl dmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCXN0cnVjdCB2YzRfZHNpICpkc2kgPSBkZXZfZ2V0 X2RydmRhdGEoZGV2KTsKPiArCj4gIAljb21wb25lbnRfZGVsKCZwZGV2LT5kZXYsICZ2YzRfZHNp X29wcyk7Cj4gKwltaXBpX2RzaV9ob3N0X3VucmVnaXN0ZXIoJmRzaS0+ZHNpX2hvc3QpOwo+ICsK PiAgCXJldHVybiAwOwo+ICB9Cj4gIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==