dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 2/3] drm/fb: add support for not enabling fbcon on non-std displays
Date: Mon, 16 Oct 2017 14:29:08 +1000	[thread overview]
Message-ID: <20171016042909.6901-2-airlied@gmail.com> (raw)
In-Reply-To: <20171016042909.6901-1-airlied@gmail.com>

From: Dave Airlie <airlied@redhat.com>

We don't want fbcon to get used on non-standard dislays,
don't pass them as enabled connectors to the fb helper setup.

This prevents my HMD from getting disorted fbcon, and from
affecting other displays console.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/drm_fb_helper.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 6a31d13f2f81..41ff51ca0396 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2033,6 +2033,9 @@ static bool drm_connector_enabled(struct drm_connector *connector, bool strict)
 {
 	bool enable;
 
+	if (connector->display_info.non_std)
+		return false;
+
 	if (strict)
 		enable = connector->status == connector_status_connected;
 	else
@@ -2052,7 +2055,8 @@ static void drm_enable_connectors(struct drm_fb_helper *fb_helper,
 		connector = fb_helper->connector_info[i]->connector;
 		enabled[i] = drm_connector_enabled(connector, true);
 		DRM_DEBUG_KMS("connector %d enabled? %s\n", connector->base.id,
-			  enabled[i] ? "yes" : "no");
+			      connector->display_info.non_std ? "non standard" : enabled[i] ? "yes" : "no");
+
 		any_enabled |= enabled[i];
 	}
 
-- 
2.14.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-10-16  4:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  4:29 [PATCH 1/3] drm: add connector info/property for non-std displays Dave Airlie
2017-10-16  4:29 ` Dave Airlie [this message]
2017-10-16  4:29 ` [PATCH 3/3] drm/edid: quirk HTC vive headset as non-standard Dave Airlie
2017-10-16  6:47   ` Thierry Reding
2017-10-17  0:59     ` Pierre-Loup A. Griffais
2017-10-16  6:41 ` [PATCH 1/3] drm: add connector info/property for non-std displays Thierry Reding
2017-10-16  6:50   ` Dave Airlie
2017-10-16  9:24     ` Daniel Vetter
2017-10-16 14:21       ` Alex Deucher
2017-10-17  5:56         ` Andrzej Hajda
2017-10-17  5:59           ` Dave Airlie
2017-10-16  9:26 ` Daniel Vetter
2017-10-16 10:09 ` Jani Nikula
2017-10-19 15:37 ` Daniel Stone
2017-10-19 16:27   ` Keith Packard
2017-10-25 11:27     ` Daniel Stone
2017-10-25 19:34       ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016042909.6901-2-airlied@gmail.com \
    --to=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox