From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 05/23] drm/sun4i: tcon: Don't rely on encoders to enable the TCON Date: Tue, 17 Oct 2017 16:38:06 +0200 Message-ID: <20171017143806.yrloimhpzioo7sk6@flea.lan> References: <90b4396e19b3eca61b2ebfdae0672074b88ad74d.1508231063.git-series.maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0762634472==" Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 87CB46E69E for ; Tue, 17 Oct 2017 14:38:07 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: Mark Rutland , Thomas Petazzoni , Priit Laes , linux-kernel , dri-devel , Quentin Schulz , Rob Herring , Daniel Vetter , Mylene Josserand , linux-clk , linux-arm-kernel , Icenowy Zheng List-Id: dri-devel@lists.freedesktop.org --===============0762634472== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="m6g7l7rk5ke7irz3" Content-Disposition: inline --m6g7l7rk5ke7irz3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 17, 2017 at 05:28:42PM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard > wrote: > > So far, we've required all the TCON-connected encoders to call the TCON > > enable and disable functions. > > > > This was made this way because in the RGB/LVDS case, the TCON is the CR= TC > > and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.),= we > > have another encoder down the road that needs to be programmed. > > > > We also needed to know which channel the encoder is connected to, which= is > > encoder-specific. > > > > The CRTC's enable and disable callbacks can work just fine for our use > > case, and we can get the channel to use just by looking at the type of > > encoder, since that is fixed. Implement those callbacks, which will > > remove some of the encoder boilerplate. > > > > Signed-off-by: Maxime Ripard >=20 > Reviewed-by: Chen-Yu Tsai Applied, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --m6g7l7rk5ke7irz3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZ5hXOAAoJEBx+YmzsjxAgvqsP/jWzuoTfv1CJrnboTtkOwyFU b7/cMVb6IyGgK6TDI/vTmjS0kbTBve2yedfWV8V3HBX1/5rb/lshucblHYuEiJ99 SJHv6nEIAunBPnJ2VytzVBRlrFoJuMnMJASu6uBDVkZaTHxqTkzAtOTWea9BJa1x dMXRHKNHuSgn0/y1cGlIrhEeIQoOBuhrSv10gxmGoRPwSzjq+okUvY1qgT//U073 R9Atgs9KDZDtAI96suV4/pPCIzOYWtN6Ge0QvmVzC3IGj1ivBUcXrbAq0XMdf46E NWiCgIp2DkxxVo/D4mLt8AfJEqhWLse2kUvihak53+GOs/CqlC8BpCCXWyWxXKOA I53jhtaWcAlRUZBNB1FbMpdmQoJn2tqwVAE6CjzXGDZzbzR0h4cph82RiFoRU6gW qnZyDtgrU15fuIWoSXpI5qIyZkeW64ktMPz9c1wp01/nVdOj2o4R+yDr3obrF8zj iGW878rA9VzTSeeKeW3dg9hXKt+tM+N1dpWrYXfx19Pl1zxBOPRfpPsY6wGjALtd gGilRAxjCNRN6D30mLrIlDayrFjxQOqTzQ2AE4+j5kkHOB/5r4VIGqbBOC/naoCp mv+ltdRF20BBwAAiL7op4q9c7CX8cARsn3Eh3LORpPm2HoLYmLVK1mUy+8ujbBm/ b1fZ3QQqBguPl3kA1Ach =scAW -----END PGP SIGNATURE----- --m6g7l7rk5ke7irz3-- --===============0762634472== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0762634472==--