Re: [PATCH v4 07/11] drm/arc: Use drm_gem_cma_print_info()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Oct 31, 2017 at 04:17:07PM +0000, Alexey Brodkin wrote:
> Hi Noralf,
> 
> On Mon, 2017-10-30 at 17:29 +0100, Noralf Trønnes wrote:
> > There is a new core debugfs file that prints fb/gem info:
> > <debugfs>/dri/<n>/framebuffer
> > 
> > Use drm_gem_cma_print_info() to provide info to that output instead
> > of using drm_fb_cma_debugfs_show().
> > 
> > Cc: Alexey Brodkin <abrodkin@synopsys.com>
> > Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> > ---
> 
> Thanks for doing this!
> 
> We used to have just:
> ----------------------------->8--------------------------
> # cat fb 
> fb: 1280x720@RG16
>    0: offset=0 pitch=2560, obj:  0 ( 1) 00008000 0xbe000000 70100000 1843200
> ----------------------------->8--------------------------
> 
> And now we get more:
>  a) information printed
>  b) readable form of this info
> ----------------------------->8--------------------------
> # cat framebuffer 
> framebuffer[33]:
>         refcount=3
>         format=RG16 little-endian (0x36314752)
>         modifier=0x0
>         size=1280x720
>         layers:

BTW "layers" seems like a somewhat confusing term to use here. I believe
layers mean something different in GL, so we probably shouldn't use that
name here.

The current name used in the code is "plane". But that too is rather
confusing on account of drm_plane. IIRC in the past I've proposed that
we should s/plane/color_plane/ when talking about the planes of a
framebuffer.

>                 size[0]=1280x720
>                 pitch[0]=2560
>                 offset[0]=0
>                 obj[0]:
>                         name=0
>                         refcount=1
>                         start=00008000
>                         size=1843200
>                         imported=no
>                         paddr=0xbe000000
>                         vaddr=70100000
> ----------------------------->8--------------------------
> 
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel