From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2. Date: Wed, 1 Nov 2017 17:29:03 +0200 Message-ID: <20171101152903.GF10981@intel.com> References: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDQ6MDQ6MzNQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhpcyBpbnRyb2R1Y2VzIGEgc2xpZ2h0IGJlaGF2aW9yYWwgY2hhbmdlIHRv IHJtZmIuIEluc3RlYWQgb2YKPiBkaXNhYmxpbmcgYSBjcnRjIHdoZW4gdGhlIHByaW1hcnkgcGxh bmUgaXMgZGlzYWJsZWQsIHdlIHRyeSB0bwo+IHByZXNlcnZlIGl0Lgo+IAo+IEFwYXJ0IGZyb20g b2xkIHZlcnNpb25zIG9mIHRoZSB2bXdnZnggeG9yZyBkcml2ZXIsIHRoZXJlIGlzCj4gbm90aGlu ZyBkZXBlbmRpbmcgb24gcm1mYiBkaXNhYmxpbmcgYSBjcnRjLgo+IAo+IFZtd2dmeCcgYW5kIHNp bXBsZSBrbXMgaGVscGVyIGF0b21pYyBpbXBsZW1lbnRhdGlvbiByZWplY3RzIENSVEMKPiBlbmFi bGVkIHdpdGhvdXQgcGxhbmUsIHNvIHdlIGNhbiBkbyB0aGlzIHNhZmVseS4KPiAKPiBJZiB0aGUg YXRvbWljIGNvbW1pdCBpcyByZWplY3RlZCBieSB0aGUgZHJpdmVyIHRoZW4gd2Ugd2lsbCBzdGls bAo+IGZhbGwgYmFjayB0byB0aGUgb2xkIGJlaGF2aW9yIGFuZCB0dXJuIG9mZiB0aGUgY3J0Yy4K PiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gUmVzdGFydCBjb21wbGV0ZWx5IHdoZW4gcm1mYiB3 aXRoIGNydGMgb24gZmFpbHMgKFNlYW4gUGF1bCkuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogU2Vh biBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZm ZXIuYyB8IDIzICsrKysrKysrKysrKysrKysrLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVy LmMKPiBpbmRleCAyYWZmZTUzZjNmZGEuLmYwNjc5NDY4ZjQyMSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZyYW1lYnVmZmVyLmMKPiBAQCAtNzY1LDE0ICs3NjUsMTggQEAgc3RhdGljIGludCBhdG9taWNf cmVtb3ZlX2ZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+ICAJc3RydWN0IGRybV9wbGFu ZSAqcGxhbmU7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubjsKPiAgCXN0cnVjdCBkcm1f Y29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlOwo+IC0JaW50IGksIHJldCA9IDA7Cj4gKwlpbnQg aSwgcmV0Owo+ICAJdW5zaWduZWQgcGxhbmVfbWFzazsKPiArCWJvb2wgZGlzYWJsZV9jcnRjcyA9 IGZhbHNlOwo+ICAKPiAtCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+IC0J aWYgKCFzdGF0ZSkKPiAtCQlyZXR1cm4gLUVOT01FTTsKPiAtCj4gK3JldHJ5X2Rpc2FibGU6Cj4g IAlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gKwo+ICsJc3RhdGUgPSBkcm1f YXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gKwlpZiAoIXN0YXRlKSB7Cj4gKwkJcmV0ID0gLUVO T01FTTsKPiArCQlnb3RvIG91dDsKPiArCX0KPiAgCXN0YXRlLT5hY3F1aXJlX2N0eCA9ICZjdHg7 Cj4gIAo+ICByZXRyeToKPiBAQCAtNzkzLDcgKzc5Nyw3IEBAIHN0YXRpYyBpbnQgYXRvbWljX3Jl bW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiAgCQkJZ290byB1bmxvY2s7Cj4g IAkJfQo+ICAKPiAtCQlpZiAocGxhbmVfc3RhdGUtPmNydGMtPnByaW1hcnkgPT0gcGxhbmUpIHsK PiArCQlpZiAoZGlzYWJsZV9jcnRjcyAmJiBwbGFuZV9zdGF0ZS0+Y3J0Yy0+cHJpbWFyeSA9PSBw bGFuZSkgewo+ICAJCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gIAo+ICAJ CQljcnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZShzdGF0ZSwg cGxhbmVfc3RhdGUtPmNydGMpOwo+IEBAIC04MTgsNiArODIyLDcgQEAgc3RhdGljIGludCBhdG9t aWNfcmVtb3ZlX2ZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+ICAJCXBsYW5lLT5vbGRf ZmIgPSBwbGFuZS0+ZmI7Cj4gIAl9Cj4gIAo+ICsJLyogVGhpcyBsaXN0IGlzIG9ubHkgZmlsbGVk IHdoZW4gZGlzYWJsZV9jcnRjcyBpcyBzZXQuICovCj4gIAlmb3JfZWFjaF9uZXdfY29ubmVjdG9y X2luX3N0YXRlKHN0YXRlLCBjb25uLCBjb25uX3N0YXRlLCBpKSB7CgpXQVJOX09OKCFkaXNhYmxl X2NydGNzKSBtYXliZT8KCj4gIAkJcmV0ID0gZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfY29ubmVj dG9yKGNvbm5fc3RhdGUsIE5VTEwpOwo+ICAKPiBAQCAtODQwLDkgKzg0NSwxNSBAQCBzdGF0aWMg aW50IGF0b21pY19yZW1vdmVfZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gIAo+ICAJ ZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOwo+ICAKPiArb3V0Ogo+ICAJZHJtX21vZGVzZXRf ZHJvcF9sb2NrcygmY3R4KTsKPiAgCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiAg Cj4gKwlpZiAocmV0ID09IC1FSU5WQUwgJiYgIWRpc2FibGVfY3J0Y3MpIHsKCkhtbS4gLUVJTlZB TCBzZWVtcyByYXRoZXIgc3BlY2lmaWMuIE5vdCBzdXJlIGlmIHdlIGNvdWxkIGp1c3QgY2hlY2sg Zm9yCmFueSBlcnJvcj8KCk9yLi4uIEknbSBub3Qgc3VyZSBpZiB3ZSBoYXZlIGFueSBjZW50cmFs IHBsYWNlIHdoZXJlIHdlIGRvIHRoZQoiY2FuIEkgZGlzYWJsZSB0aGUgcHJpbWFyeSBwbGFuZSB3 L28gZGlzYWJsaW5nIHRoZSBjcnRjPyIgY2hlY2suIElmIHdlCmRvIHRoZW4gd2UgY291bGQgYWxz byBhZGQgYSBjb21tZW50IHRoZXJlIGluZm9ybWluZyBwZW9wbGUgdGhhdCB0aGUKLUVJTlZBTCBp cyBpbXBvcnRhbnQuCgo+ICsJCWRpc2FibGVfY3J0Y3MgPSB0cnVlOwo+ICsJCWdvdG8gcmV0cnlf ZGlzYWJsZTsKPiArCX0KPiArCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IC0tIAo+IDIuMTQu MQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==