From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/atomic: Try to preserve the crtc
 enabled state in drm_atomic_remove_fb, v2.
Date: Wed, 1 Nov 2017 19:00:19 +0200
Message-ID: <20171101170019.GG10981@intel.com>
References: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com>
 <20171101152903.GF10981@intel.com>
 <ae71ae35-2745-4d21-76ea-bb9d9831d016@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <ae71ae35-2745-4d21-76ea-bb9d9831d016@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDQ6NTU6MDZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gT3AgMDEtMTEtMTcgb20gMTY6Mjkgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6
Cj4gPiBPbiBXZWQsIE5vdiAwMSwgMjAxNyBhdCAwNDowNDozM1BNICswMTAwLCBNYWFydGVuIExh
bmtob3JzdCB3cm90ZToKPiA+PiBUaGlzIGludHJvZHVjZXMgYSBzbGlnaHQgYmVoYXZpb3JhbCBj
aGFuZ2UgdG8gcm1mYi4gSW5zdGVhZCBvZgo+ID4+IGRpc2FibGluZyBhIGNydGMgd2hlbiB0aGUg
cHJpbWFyeSBwbGFuZSBpcyBkaXNhYmxlZCwgd2UgdHJ5IHRvCj4gPj4gcHJlc2VydmUgaXQuCj4g
Pj4KPiA+PiBBcGFydCBmcm9tIG9sZCB2ZXJzaW9ucyBvZiB0aGUgdm13Z2Z4IHhvcmcgZHJpdmVy
LCB0aGVyZSBpcwo+ID4+IG5vdGhpbmcgZGVwZW5kaW5nIG9uIHJtZmIgZGlzYWJsaW5nIGEgY3J0
Yy4KPiA+Pgo+ID4+IFZtd2dmeCcgYW5kIHNpbXBsZSBrbXMgaGVscGVyIGF0b21pYyBpbXBsZW1l
bnRhdGlvbiByZWplY3RzIENSVEMKPiA+PiBlbmFibGVkIHdpdGhvdXQgcGxhbmUsIHNvIHdlIGNh
biBkbyB0aGlzIHNhZmVseS4KClRoZSBjb2RlIGZvciB0aG9zZSBzZWVtcyBhIGJpdCBpbmNvbnNp
c3RlbnQuIFRoZSBjcnRjIGNoZWNrIHJlcXVpcmVzCnRoYXQgdGhlIGNydGMgc3RhdGUgYW5kIHBs
YW5lIHN0YXRlIG1hdGNoLiBCdXQgdGhlIHBsYW5lIGNoZWNrIGFsbG93cwp0aGUgcGxhbmUgdG8g
YmUgZW5hYmxlZCB3L28gdGhlIGNydGMgYmVpbmcgZW5hYmxlZC4gSSBndWVzcyBpdCBkb2Vzbid0
Cm1hdHRlciByZWFsbHkgc2luY2UgeW91IGNhbid0IGVuYWJsZSB0aGUgcGxhbmUgd2l0aG91dCBh
IGNydGMsIGFuZCB0aGUKY3J0YyBjaGVjayB3b3VsZCB0aGVuIGNhdGNoIHRoZSBjYXNlIHdoZXJl
IHRoZSBjcnRjIHdvdWxkIGJlIGRpc2FibGVkLgoKT2ggYW5kIGxvb2tzIGxpa2UgZHJtX3BsYW5l
X2hlbHBlcl9jaGVja19zdGF0ZSgpIGlzIGEgYml0IGJ1Z2d5LiBJdApzdGlsbCB1c2VzIGNydGMt
PmVuYWJsZWQgaW5zdGVhZCBvZiBjcnRjX3N0YXRlLT5lbmFibGUgdG8gY2hlY2sgdGhlCnN0YXRl
IG9mIHRoZSBjcnRjLiBJIGd1ZXNzIHRvIGtlZXAgZHJtX3BsYW5lX2hlbHBlcl9jaGVja191cGRh
dGUoKQp3b3JraW5nIHdlIG1heSBoYXZlIHRvIHBhc3MgaW4gdGhlIGNydGMgc3RhdGUgbWFudWFs
bHkuCgpUaGUgdm13Z2Z4IHBsYW5lIGNoZWNrIGxvb2tzIGEgYml0IGJvZ3VzIGluIG90aGVyIHdh
eXMgdG9vLiBJIGd1ZXNzCkknbGwgaGF2ZSB0byBmaXJlIG9mZiBhIGNvdXBsZSBvZiBwYXRjaGVz
LgoKPiA+Pgo+ID4+IElmIHRoZSBhdG9taWMgY29tbWl0IGlzIHJlamVjdGVkIGJ5IHRoZSBkcml2
ZXIgdGhlbiB3ZSB3aWxsIHN0aWxsCj4gPj4gZmFsbCBiYWNrIHRvIHRoZSBvbGQgYmVoYXZpb3Ig
YW5kIHR1cm4gb2ZmIHRoZSBjcnRjLgo+ID4+Cj4gPj4gQ2hhbmdlcyBzaW5jZSB2MToKPiA+PiAt
IFJlc3RhcnQgY29tcGxldGVseSB3aGVuIHJtZmIgd2l0aCBjcnRjIG9uIGZhaWxzIChTZWFuIFBh
dWwpLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u
bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+PiBDYzogU2VhbiBQYXVsIDxzZWFucGF1bEBj
aHJvbWl1bS5vcmc+Cj4gPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwu
Y2g+Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyB8IDIz
ICsrKysrKysrKysrKysrKysrLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRp
b25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9kcm1fZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIu
Ywo+ID4+IGluZGV4IDJhZmZlNTNmM2ZkYS4uZjA2Nzk0NjhmNDIxIDEwMDY0NAo+ID4+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+ID4+IEBAIC03NjUsMTQgKzc2NSwxOCBAQCBzdGF0aWMg
aW50IGF0b21pY19yZW1vdmVfZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gPj4gIAlz
dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiA+PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u
Owo+ID4+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gPj4gLQlp
bnQgaSwgcmV0ID0gMDsKPiA+PiArCWludCBpLCByZXQ7Cj4gPj4gIAl1bnNpZ25lZCBwbGFuZV9t
YXNrOwo+ID4+ICsJYm9vbCBkaXNhYmxlX2NydGNzID0gZmFsc2U7Cj4gPj4gIAo+ID4+IC0Jc3Rh
dGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gPj4gLQlpZiAoIXN0YXRlKQo+ID4+
IC0JCXJldHVybiAtRU5PTUVNOwo+ID4+IC0KPiA+PiArcmV0cnlfZGlzYWJsZToKPiA+PiAgCWRy
bV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsKPiA+PiArCj4gPj4gKwlzdGF0ZSA9IGRy
bV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPiA+PiArCWlmICghc3RhdGUpIHsKPiA+PiArCQly
ZXQgPSAtRU5PTUVNOwo+ID4+ICsJCWdvdG8gb3V0Owo+ID4+ICsJfQo+ID4+ICAJc3RhdGUtPmFj
cXVpcmVfY3R4ID0gJmN0eDsKPiA+PiAgCj4gPj4gIHJldHJ5Ogo+ID4+IEBAIC03OTMsNyArNzk3
LDcgQEAgc3RhdGljIGludCBhdG9taWNfcmVtb3ZlX2ZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIg
KmZiKQo+ID4+ICAJCQlnb3RvIHVubG9jazsKPiA+PiAgCQl9Cj4gPj4gIAo+ID4+IC0JCWlmIChw
bGFuZV9zdGF0ZS0+Y3J0Yy0+cHJpbWFyeSA9PSBwbGFuZSkgewo+ID4+ICsJCWlmIChkaXNhYmxl
X2NydGNzICYmIHBsYW5lX3N0YXRlLT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7Cj4gPj4gIAkJ
CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiA+PiAgCj4gPj4gIAkJCWNydGNf
c3RhdGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLCBwbGFuZV9z
dGF0ZS0+Y3J0Yyk7Cj4gPj4gQEAgLTgxOCw2ICs4MjIsNyBAQCBzdGF0aWMgaW50IGF0b21pY19y
ZW1vdmVfZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gPj4gIAkJcGxhbmUtPm9sZF9m
YiA9IHBsYW5lLT5mYjsKPiA+PiAgCX0KPiA+PiAgCj4gPj4gKwkvKiBUaGlzIGxpc3QgaXMgb25s
eSBmaWxsZWQgd2hlbiBkaXNhYmxlX2NydGNzIGlzIHNldC4gKi8KPiA+PiAgCWZvcl9lYWNoX25l
d19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm4sIGNvbm5fc3RhdGUsIGkpIHsKPiA+IFdB
Uk5fT04oIWRpc2FibGVfY3J0Y3MpIG1heWJlPwo+IFdvdWxkIGJlIG92ZXJraWxsLCBub3RoaW5n
IGJlZm9yZSBpdCBhZGRzIGNvbm5lY3RvciBzdGF0ZSwgYW5kIGlmIGF0b21pYyBjaGVjayBkb2Vz
IHRoZW4gdGhhdCdzIGZpbmUsIGJ1dCBpdCB3b24ndCBiZSBydW4gaGVyZS4gOikKCkl0IHdvdWxk
IHNlcnZlIGFzIGEgd2F5IHRvIGRvY3VtZW50IHRoYXQgZmFjdCwgZXZlbiB3aXRob3V0IHRoZSBj
b21tZW50LgpCdXQgSSB3b24ndCBpbnNpc3Qgb24gaXQuCgo+ID4+ICAJCXJldCA9IGRybV9hdG9t
aWNfc2V0X2NydGNfZm9yX2Nvbm5lY3Rvcihjb25uX3N0YXRlLCBOVUxMKTsKPiA+PiAgCj4gPj4g
QEAgLTg0MCw5ICs4NDUsMTUgQEAgc3RhdGljIGludCBhdG9taWNfcmVtb3ZlX2ZiKHN0cnVjdCBk
cm1fZnJhbWVidWZmZXIgKmZiKQo+ID4+ICAKPiA+PiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0
YXRlKTsKPiA+PiAgCj4gPj4gK291dDoKPiA+PiAgCWRybV9tb2Rlc2V0X2Ryb3BfbG9ja3MoJmN0
eCk7Cj4gPj4gIAlkcm1fbW9kZXNldF9hY3F1aXJlX2ZpbmkoJmN0eCk7Cj4gPj4gIAo+ID4+ICsJ
aWYgKHJldCA9PSAtRUlOVkFMICYmICFkaXNhYmxlX2NydGNzKSB7Cj4gPiBIbW0uIC1FSU5WQUwg
c2VlbXMgcmF0aGVyIHNwZWNpZmljLiBOb3Qgc3VyZSBpZiB3ZSBjb3VsZCBqdXN0IGNoZWNrIGZv
cgo+ID4gYW55IGVycm9yPwo+ID4KPiA+IE9yLi4uIEknbSBub3Qgc3VyZSBpZiB3ZSBoYXZlIGFu
eSBjZW50cmFsIHBsYWNlIHdoZXJlIHdlIGRvIHRoZQo+ID4gImNhbiBJIGRpc2FibGUgdGhlIHBy
aW1hcnkgcGxhbmUgdy9vIGRpc2FibGluZyB0aGUgY3J0Yz8iIGNoZWNrLiBJZiB3ZQo+ID4gZG8g
dGhlbiB3ZSBjb3VsZCBhbHNvIGFkZCBhIGNvbW1lbnQgdGhlcmUgaW5mb3JtaW5nIHBlb3BsZSB0
aGF0IHRoZQo+ID4gLUVJTlZBTCBpcyBpbXBvcnRhbnQuCj4gV2UgZG9uJ3QgaGF2ZSBhIGNlbnRy
YWwgcGxhY2UsIEkgY2hlY2sgZm9yIEVJTlZBTCBzaW5jZSB0aGF0IGlzIHRoZSBnZW5lcmljIGF0
b21pY19jaGVjaygpIGZhaWxlZCBlcnJvci4gSWYgaXQgZmFpbHMgZm9yIGFueSBvdGhlciByZWFz
b24gdGhlbiB3ZSBkb24ndCBoYXZlIHRvIHJldHJ5LCBidXQgcGFzcyBpdCBhbG9uZy4gOikKCk9o
IHdlbGwuIEkgZ3Vlc3MgcGVvcGxlIGp1c3QgaGF2ZSB0byBiZSBjYXJlZnVsIHdpdGggdGhlaXIg
ZXJyb3IKdmFsdWVzLiBJIHN1cHBvZSBhbnlvbmUgZGVwZW5kaW5nIG9uIHRoZSByZXRyeSB3aWxs
IG5vdGljZSB0aGlzCmlzc3VlIHJhdGhlciBxdWlja2x5LgoKLS0gClZpbGxlIFN5cmrDpGzDpApJ
bnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==