From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 0/7] drm/edid and drivers: ELD refactoring Date: Mon, 6 Nov 2017 15:54:52 +0100 Message-ID: <20171106145452.GA15647@ulmo> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0839666869==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Russell King , dri-devel@lists.freedesktop.org, Ben Skeggs , Alex Deucher , Vincent Abriou , Christian =?utf-8?B?S8O2bmln?= List-Id: dri-devel@lists.freedesktop.org --===============0839666869== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 01, 2017 at 04:20:56PM +0200, Jani Nikula wrote: > We were recently bitten by drm_edid_to_eld() clearing the connector > type, and us failing to set it back for DP. Here's a few ELD related > patches to try to unify ELD handling and make it a bit simpler for > drivers to get it right. >=20 > Apologies for the massive Cc list; it's the maintainers of all drivers > that call drm_edid_to_eld(). >=20 > I'm open to splitting up patch 6 to driver specific patches as needed, > but I'd think it would be just fine to merge via drm-misc as-is too. >=20 > BR, > Jani. >=20 > Cc: Alex Deucher > Cc: Christian K=C3=B6nig > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Russell King > Cc: CK Hu > Cc: Philipp Zabel > Cc: Ben Skeggs > Cc: Mark Yao > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: Thierry Reding > Cc: Eric Anholt >=20 >=20 > Jani Nikula (7): > drm/edid: use macros for ELD offsets and values > drm/edid: set ELD connector type in drm_edid_to_eld() > drm/i915: remove redundant ELD connector type update > drm/edid: abstract connector ELD clearing > drm/edid: build ELD in drm_add_edid_modes() > drm/drivers: drop redundant drm_edid_to_eld() calls > drm/edid: make drm_edid_to_eld() static >=20 > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - > drivers/gpu/drm/bridge/analogix-anx78xx.c | 2 - > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 - > drivers/gpu/drm/drm_edid.c | 70 +++++++++++++++-----= ------ > drivers/gpu/drm/i2c/tda998x_drv.c | 1 - > drivers/gpu/drm/i915/intel_dp.c | 1 - > drivers/gpu/drm/i915/intel_modes.c | 18 ------- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 - > drivers/gpu/drm/nouveau/nv50_display.c | 5 +- > drivers/gpu/drm/radeon/radeon_connectors.c | 1 - > drivers/gpu/drm/radeon/radeon_dp_mst.c | 1 - > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +- > drivers/gpu/drm/sti/sti_hdmi.c | 1 - > drivers/gpu/drm/tegra/output.c | 1 - > drivers/gpu/drm/vc4/vc4_hdmi.c | 1 - > include/drm/drm_edid.h | 1 - > include/drm/drm_modeset_helper_vtables.h | 3 -- > 17 files changed, 44 insertions(+), 70 deletions(-) The series: Acked-by: Thierry Reding --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAloAd7YACgkQ3SOs138+ s6GmcRAApMw98tcZ37PRfBSCOpqstd3GSPMYhPexpPVYi5Ex2RQm3CZBWjKGE+lL DI4zo8qTjl7B+ZoZxDHjzQndL28m/6DyAvywKihFNM2UiE8Wq00z5xB+0oNJc3/I 5rgx2JkUcr33G5K2ojpxamKXw6CKBsjgEVHmRmyrLAZb9G5q0JxKTe8oZSCddV1y WNnWHjdoIKybZi/28Gv+7xBS/wzhZ+fHWzijMh4ZMknSaciOgoMiYdg2fOthuw6X sER73B0sXCgK0HmkgqGv35hkZBReSs7U8VOL1gGR9yJhBo5+E10NEc2WEmfiWwXC UH5wkGq1DFQgu8hcav3B/zxLKAt0xsUaAGI+uXYWDgGkFHUgc4J9EjrzNlGjVhzf 3B1WAx5+6InDLD827iAPG+tpGUCEvlfoGWzVCa/bjCpKYmTf3a9H1MAdNpo3iDUb w8MR1LO9HQkW9tTB8G6gzLCTMUn+pI9QImx/K7+NskA48h5xIBUGAub2h6N24IRM vCENJTjqLhsJa4QU2qBctfipibLL4jEwmzHjKHHFq/iKT4y+ZGchFlbppnR8PV1A WtPpy6OzGBrLWmGTeBdDkpexszSaoLCupHTYDFtI94b6JuXmVwmecIrjdDWRENgd Up1m6oWggatYhN2TQrwiqhskRbaMBy3uYY35NqOWWTAhAA5VPGU= =IVup -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm-- --===============0839666869== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0839666869==--