* [PATCH] video: fbdev: aty: radeon_pm: mark expected switch fall-throughs @ 2017-11-06 22:40 ` Gustavo A. R. Silva 2017-11-09 15:59 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Gustavo A. R. Silva @ 2017-11-06 22:40 UTC (permalink / raw) To: Benjamin Herrenschmidt, Bartlomiej Zolnierkiewicz Cc: linux-fbdev, dri-devel, linux-kernel, Gustavo A. R. Silva In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/video/fbdev/aty/radeon_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/aty/radeon_pm.c b/drivers/video/fbdev/aty/radeon_pm.c index f7c253d..7137c12 100644 --- a/drivers/video/fbdev/aty/radeon_pm.c +++ b/drivers/video/fbdev/aty/radeon_pm.c @@ -1208,9 +1208,11 @@ static void radeon_pm_enable_dll_m10(struct radeonfb_info *rinfo) case 1: if (mc & 0x4) break; + /* fall through */ case 2: dll_sleep_mask |= MDLL_R300_RDCK__MRDCKB_SLEEP; dll_reset_mask |= MDLL_R300_RDCK__MRDCKB_RESET; + /* fall through */ case 0: dll_sleep_mask |= MDLL_R300_RDCK__MRDCKA_SLEEP; dll_reset_mask |= MDLL_R300_RDCK__MRDCKA_RESET; @@ -1219,6 +1221,7 @@ static void radeon_pm_enable_dll_m10(struct radeonfb_info *rinfo) case 1: if (!(mc & 0x4)) break; + /* fall through */ case 2: dll_sleep_mask |= MDLL_R300_RDCK__MRDCKD_SLEEP; dll_reset_mask |= MDLL_R300_RDCK__MRDCKD_RESET; -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: aty: radeon_pm: mark expected switch fall-throughs 2017-11-06 22:40 ` [PATCH] video: fbdev: aty: radeon_pm: mark expected switch fall-throughs Gustavo A. R. Silva @ 2017-11-09 15:59 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-11-09 15:59 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel, dri-devel On Monday, November 06, 2017 04:40:01 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-09 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171106224006epcas3p4585900edc130ff7ca3a5bef657a237a3@epcas3p4.samsung.com>
2017-11-06 22:40 ` [PATCH] video: fbdev: aty: radeon_pm: mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-09 15:59 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).