From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Eric Anholt <eric@anholt.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: drivers/gpu/drm/bridge/lvds-encoder.c broken in mainline
Date: Thu, 9 Nov 2017 16:15:14 +0100 [thread overview]
Message-ID: <20171109161514.6b5e4fa3@karo-electronics.de> (raw)
In-Reply-To: <87vaiky6qs.fsf@anholt.net>
Hi,
On Wed, 08 Nov 2017 10:18:03 -0800 Eric Anholt wrote:
> Lothar Waßmann <LW@KARO-electronics.de> writes:
>
> > Hi,
> >
> > drivers/gpu/drm/bridge/lvds-encoder.c driver is currently
> > dysfunctional due to:
> > |commit 13dfc0540a575b47b2d640b093ac16e9e09474f6
> > |Author: Eric Anholt <eric@anholt.net>
> > |Date: Fri Jun 2 13:25:14 2017 -0700
> > |
> > | drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.
> >
> > Also, there is no in-kernel user of this driver, so that it obviously
> > doesn't get tested in any way. There is only one dts file (r8a7779-marzen.dts)
> > that instantiates this driver, but it has an incomplete OF graph. The missing
> > link for the OF graph is provided by either r8a77xx-aa104xd12-panel.dtsi or
> > r8a77xx-aa121td01-panel.dtsi, but those files are referenced nowhere in
> > the kernel source.
> >
> > Should the driver be removed or moved to staging, until it is properly
> > fixed?
>
> I can't see any behavior change about the DT handling in that commit,
> and I didn't intend for there to be any. Could you help me understand
> what went wrong?
>
With the offending commit applied, the lvds-encoder driver is being
attached to the device associated with the lcd-panel driver's of_node
(panel-simple in my case) rather than the lvds-encoder's of_node.
Lothar Waßmann
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-09 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 14:06 drivers/gpu/drm/bridge/lvds-encoder.c broken in mainline Lothar Waßmann
2017-11-08 18:18 ` Eric Anholt
2017-11-09 15:15 ` Lothar Waßmann [this message]
2017-11-13 21:03 ` Eric Anholt
2017-11-14 3:43 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109161514.6b5e4fa3@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=boris.brezillon@free-electrons.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).