From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: CK Hu <ck.hu@mediatek.com>,
intel-gfx@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 07/15] drm/mediatek: Use drm_mode_get_hv_timing() to populate plane clip rectangle
Date: Fri, 24 Nov 2017 16:49:13 +0200 [thread overview]
Message-ID: <20171124144913.GK10981@intel.com> (raw)
In-Reply-To: <1511533942.8422.2.camel@pengutronix.de>
On Fri, Nov 24, 2017 at 03:32:22PM +0100, Philipp Zabel wrote:
> On Thu, 2017-11-23 at 21:04 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Use drm_mode_get_hv_timing() to fill out the plane clip rectangle.
> >
> > No functional changes as the code already uses crtc_state->mode
> > to populate the clip, which is also what drm_mode_get_hv_timing()
> > uses.
>
> I don't understand this explanation, drm_mode_get_hv_timing uses
> whichever mode is passed to it?
Hmm. I worded that badly it seems. The point is that we pass the user
mode everywhere else where we want to know the dimensions of the
crtc coordinate space.
>
> > Once everyone agrees on this we can move the clip handling into
> > drm_atomic_helper_check_plane_state().
>
> I can see that there are no functional changes though,
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> regards
> Philipp
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-24 14:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 19:04 [PATCH 00/15] drm: More plane clipping polish Ville Syrjala
2017-11-23 19:04 ` [PATCH 01/15] drm/i915: Reject odd pipe source width with double wide/dual link Ville Syrjala
2017-11-24 17:04 ` [Intel-gfx] " Daniel Vetter
2017-11-23 19:04 ` [PATCH 02/15] drm/i915: Use drm_mode_get_hv_timing() to populate plane clip rectangle Ville Syrjala
2017-11-23 19:04 ` [PATCH 03/15] drm/arm/hdlcd: " Ville Syrjala
2017-11-24 11:03 ` Liviu Dudau
2017-11-23 19:04 ` [PATCH 04/15] drm/arm/mali-dp: " Ville Syrjala
2017-11-24 11:03 ` Liviu Dudau
2017-11-23 19:04 ` [PATCH 05/15] drm/simple_kms_helper: " Ville Syrjala
2017-11-23 19:04 ` [PATCH 06/15] drm/imx: " Ville Syrjala
2017-11-24 14:32 ` Philipp Zabel
2017-11-23 19:04 ` [PATCH 07/15] drm/mediatek: " Ville Syrjala
2017-11-24 14:32 ` Philipp Zabel
2017-11-24 14:49 ` Ville Syrjälä [this message]
2017-11-23 19:04 ` [PATCH 08/15] drm/meson: " Ville Syrjala
2017-11-23 19:04 ` [PATCH 09/15] drm/msm/mdp5: " Ville Syrjala
2017-11-26 13:11 ` Archit Taneja
2017-11-23 19:04 ` [PATCH 11/15] drm/rockchip: " Ville Syrjala
[not found] ` <20171123190502.28449-1-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-23 19:04 ` [PATCH 10/15] drm/nouveau/kms/nv50: " Ville Syrjala
2017-11-23 19:04 ` [PATCH 12/15] drm/tegra/dc: " Ville Syrjala
[not found] ` <20171123190502.28449-13-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-24 13:42 ` Thierry Reding
2017-11-24 13:41 ` [PATCH 00/15] drm: More plane clipping polish Thierry Reding
2017-11-23 19:05 ` [PATCH 13/15] drm/vmwgfx: Use drm_mode_get_hv_timing() to populate plane clip rectangle Ville Syrjala
2017-11-28 5:11 ` Sinclair Yeh
2017-11-23 19:05 ` [PATCH 14/15] drm/zte: " Ville Syrjala
2017-11-29 6:41 ` Shawn Guo
2017-11-23 19:05 ` [PATCH 15/15] drm: Don't pass clip to drm_atomic_helper_check_plane_state() Ville Syrjala
2017-11-24 11:59 ` Liviu Dudau
2017-11-24 14:08 ` Ville Syrjälä
2017-11-24 15:24 ` Liviu Dudau
2017-11-24 12:01 ` Liviu Dudau
2017-11-24 17:00 ` Daniel Vetter
2018-01-23 16:15 ` [PATCH 00/15] drm: More plane clipping polish Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124144913.GK10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ck.hu@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).