From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v3 2/5] drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove Date: Tue, 28 Nov 2017 10:41:29 -0800 Message-ID: <20171128184129.GB116479@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-3-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0D5F6E6C1 for ; Tue, 28 Nov 2017 18:41:33 +0000 (UTC) Received: by mail-it0-x244.google.com with SMTP id b5so934877itc.3 for ; Tue, 28 Nov 2017 10:41:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <1511868006-27130-3-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, airlied@linux.ie, hoegsberg@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, philippe.cornu@st.com, yannick.fertre@st.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org, hl@rock-chips.com List-Id: dri-devel@lists.freedesktop.org SGkgTmlja2V5LAoKT24gVHVlLCBOb3YgMjgsIDIwMTcgYXQgMDc6MjA6MDNQTSArMDgwMCwgTmlj a2V5IFlhbmcgd3JvdGU6Cj4gQnJpZGdlIGRyaXZlcnMvaGVscGVycyBzaG91bGRuJ3QgYmUgY2xv YmJlcmluZyB0aGUgZHJ2ZGF0YSwgc2luY2UgYQo+IHBhcmVudCBkcml2ZXIgbWlnaHQgbmVlZCB0 byBvd24gdGhpcy4gSW5zdGVhZCwgbGV0J3MgcmV0dXJuIG91cgoKT3RoZXIgcmV2aWV3cyBoYXZl IHN1Z2dlc3RlZCB0aGlzIG1pZ2h0IGJlIGRlc2NyaWJlZCBhcyAiU29DIGdsdWUKZHJpdmVyIiwg bm90ICJwYXJlbnQgZHJpdmVyIi4gQWxzbywgdGhlIHN1YmplY3QgcHJvYmFibHkgc2hvdWxkIGlu Y2x1ZGUKZWl0aGVyICJtaXBpIiBvciAiZHctbWlwaS1kc2kiLgoKPiAnZHdfbWlwaV9kc2knIG9i amVjdCBhbmQgaGF2ZSBjYWxsZXJzIHBhc3MgdGhhdCBiYWNrIHRvIHVzIGZvciByZW1vdmFsLgo+ IFNvIGFkanVzdCBpdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBOaWNrZXkgWWFuZyA8bmlja2V5Lnlh bmdAcm9jay1jaGlwcy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9zdG0vZHdfbWlwaV9k c2ktc3RtLmMgfCA4ICsrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCgpTbywgeW91J3ZlIHNwbGl0IG15IHBhdGNoIGluIDIgYW5kIGNhbGxl ZCBpdCB5b3VyIG93biAoc2VlIHBhdGNoIDEsCndoaWNoIHN0aWxsIGhhcyB0aGUgJ0Zyb20nIChp LmUuLCBhdXRob3IpIGxpbmUgYXMgIk5pY2tleSBZYW5nIiwgbm90CiJCcmlhbiBOb3JyaXMiKS4g WW91IG5lZWQgdG8ga2VlcCB0aGUgYXV0aG9yIGFjY3VyYXRlLiAoSXQncyBnb29kIHRvIGFkZAph biBhZGRpdGlvbmFsICdTaWduZWQtb2ZmLWJ5JyBvZiB5b3VyIG93biwgYnV0IGtlZXAgdGhlIGF1 dGhvci4pCgpXaGVuIGRldmVsb3BpbmcgaW4geW91ciBsb2NhbCBnaXQgdHJlZSwgbWFrZSBzdXJl IHRoYXQgdGhlICdBdXRob3InIGxpbmUKaXMgYWNjdXJhdGUgaW4gJ2dpdCBsb2cnLiBUaGVuICdn aXQgZm9ybWF0LXBhdGNoICsgZ2l0IHNlbmQtZW1haWwnIHdpbGwKZm9ybWF0IHRoaW5ncyBjb3Jy ZWN0bHksIHN1Y2ggdGhhdCB5b3VyIGVtYWlsIGhlYWRlcnMgd2lsbCBzYXkgIkZyb206Ck5pY2tl eSBZYW5nIiwgYnV0IHRoZW4gZ2l0LXNlbmQtZW1haWwgd2lsbCBtYWtlIHN1cmUgdGhlcmUncyBh bgphZGRpdGlvbmFsIGxpbmUgd2l0aGluIHRoZSBib2R5IG9mIHRoZSBlbWFpbCB0byBhdHRyaWJ1 dGUgdGhlIGF1dGhvci4KCkZvciBleGFtcGxlLCBzZWUgaG93IHRoaXMgcGF0Y2ggd2FzIHNlbnQg YnkgRG91ZyBpbiBhIGxhdGVyIHNlcmllcywgYnV0IGhhcyBteQphdXRob3JzaGlwOgoKaHR0cHM6 Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85MTg4NDE5LwoKVGhlIGVtYWlsIGhlYWRlciBz YXlzOgoKRnJvbTogRG91Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgoKYnV0 IHRoZSBib2R5IG9mIHRoZSBtYWlsIGluY2x1ZGVzOgoKRnJvbTogQnJpYW4gTm9ycmlzIDxicmlh bm5vcnJpc0BjaHJvbWl1bS5vcmc+CgpUaGlzIGVuZHMgdXAgY29ycmVjdGx5LWF0dHJpYnV0ZWQg aW4gdGhlIG1haW5saW5lIGdpdCB0cmVlOgoKY29tbWl0IDM2YjVkNDYwMjYxZjE2NTYzZjkxOTZj NDljOTM2YjNlMTdkMjM3ZTMKQXV0aG9yOiBCcmlhbiBOb3JyaXMgPGJyaWFubm9ycmlzQGNocm9t aXVtLm9yZz4KRGF0ZTogICBNb24gSnVuIDIwIDEwOjU2OjQyIDIwMTYgLTA3MDAKCiAgICBwaHk6 IHJvY2tjaGlwLWVtbWM6IGNvbmZpZ3VyZSBkZWZhdWx0IG91dHB1dCB0YXAgZGVsYXkKLi4uCiAg ICBTaWduZWQtb2ZmLWJ5OiBCcmlhbiBOb3JyaXMgPGJyaWFubm9ycmlzQGNocm9taXVtLm9yZz4K ICAgIFNpZ25lZC1vZmYtYnk6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5kZXJzQGNocm9taXVtLm9y Zz4KCgpCdXQgbW9yZSBpbXBvcnRhbnRseTogeW91IGNhbid0IHNwbGl0IG15IHBhdGNoIGluIDIs IGJlY2F1c2UgaXQgbWFrZXMKdGhlIHNlcmllcyBub24tYmlzZWN0YWJsZS4gQXMgeW91IHNwbGl0 IGl0LCBwYXRjaCAxIGlzIG1ha2luZyBhbiBBUEkKY2hhbmdlLCBidXQgaXQgZG9lc24ndCB1cGRh dGUgdGhlIGRyaXZlcnMgdGhhdCB1c2UgdGhhdCBBUEkuIFNvIHRoZSBTVE0KRFNJIGRyaXZlciBk b2Vzbid0IGNvbXBpbGUgaWYgeW91IGFwcGx5IG9ubHkgcGF0Y2ggMS4gVGhhdCdzIGRpc2NvdXJh Z2VkCndpdGhpbiB0aGUgTGludXgga2VybmVsLgoKU28sIGxldCdzIG1ha2Ugc3VyZSB0byBrZWVw IHRoaXMgcGF0Y2ggaW4gMSBwaWVjZS4KCkJyaWFuCgo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vc3RtL2R3X21pcGlfZHNpLXN0bS5jIGIvZHJpdmVycy9ncHUvZHJtL3N0bS9kd19t aXBpX2RzaS1zdG0uYwo+IGluZGV4IGU1YjYzMTAuLjgwZjk5NTAgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3N0bS9kd19taXBpX2RzaS1zdG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9zdG0vZHdfbWlwaV9kc2ktc3RtLmMKPiBAQCAtNjYsNiArNjYsNyBAQCBlbnVtIGRzaV9jb2xv ciB7Cj4gIHN0cnVjdCBkd19taXBpX2RzaV9zdG0gewo+ICAJdm9pZCBfX2lvbWVtICpiYXNlOwo+ ICAJc3RydWN0IGNsayAqcGxscmVmX2NsazsKPiArCXN0cnVjdCBkd19taXBpX2RzaSAqZG1kOwo+ ICB9Owo+ICAKPiAgc3RhdGljIGlubGluZSB2b2lkIGRzaV93cml0ZShzdHJ1Y3QgZHdfbWlwaV9k c2lfc3RtICpkc2ksIHUzMiByZWcsIHUzMiB2YWwpCj4gQEAgLTMxOCwxMCArMzE5LDExIEBAIHN0 YXRpYyBpbnQgZHdfbWlwaV9kc2lfc3RtX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAlkd19taXBpX2RzaV9zdG1fcGxhdF9kYXRhLmJhc2UgPSBkc2ktPmJhc2U7Cj4gIAlk d19taXBpX2RzaV9zdG1fcGxhdF9kYXRhLnByaXZfZGF0YSA9IGRzaTsKPiAgCj4gLQlyZXQgPSBk d19taXBpX2RzaV9wcm9iZShwZGV2LCAmZHdfbWlwaV9kc2lfc3RtX3BsYXRfZGF0YSk7Cj4gLQlp ZiAocmV0KSB7Cj4gKwlkc2ktPmRtZCA9IGR3X21pcGlfZHNpX3Byb2JlKHBkZXYsICZkd19taXBp X2RzaV9zdG1fcGxhdF9kYXRhKTsKPiArCWlmIChJU19FUlIoZHNpLT5kbWQpKSB7Cj4gIAkJRFJN X0VSUk9SKCJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBtaXBpIGRzaSBob3N0XG4iKTsKPiAgCQljbGtf ZGlzYWJsZV91bnByZXBhcmUoZHNpLT5wbGxyZWZfY2xrKTsKPiArCQlyZXR1cm4gUFRSX0VSUihk c2ktPmRtZCk7Cj4gIAl9Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiBAQCAtMzMyLDcgKzMzNCw3IEBA IHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfc3RtX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ICAJc3RydWN0IGR3X21pcGlfZHNpX3N0bSAqZHNpID0gZHdfbWlwaV9kc2lfc3Rt X3BsYXRfZGF0YS5wcml2X2RhdGE7Cj4gIAo+ICAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGRzaS0+ cGxscmVmX2Nsayk7Cj4gLQlkd19taXBpX2RzaV9yZW1vdmUocGRldik7Cj4gKwlkd19taXBpX2Rz aV9yZW1vdmUoZHNpLT5kbWQpOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4gLS0gCj4gMS45LjEK PiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==