From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/5] drm/armada: fix leak of crtc structure Date: Wed, 29 Nov 2017 19:16:43 +0000 Message-ID: <20171129191643.GF8356@n2100.armlinux.org.uk> References: <20171129114516.GD8356@n2100.armlinux.org.uk> <20171129145342.ripjickq7o75cvfj@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 846186E051 for ; Wed, 29 Nov 2017 19:16:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171129145342.ripjickq7o75cvfj@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMjksIDIwMTcgYXQgMDk6NTM6NDJBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFdlZCwgTm92IDI5LCAyMDE3IGF0IDExOjQ1OjQzQU0gKzAwMDAsIFJ1c3NlbGwgS2lu ZyB3cm90ZToKPiA+IEZpeCB0aGUgbGVhayBvZiB0aGUgQ1JUQyBzdHJ1Y3R1cmUgaW4gdGhlIGZh aWx1cmUgcGF0aHMgb2YKPiA+IGFybWFkYV9kcm1fY3J0Y19jcmVhdGUoKS4KPiA+IAo+ID4gU2ln bmVkLW9mZi1ieTogUnVzc2VsbCBLaW5nIDxybWsra2VybmVsQGFybWxpbnV4Lm9yZy51az4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hcm1hZGEvYXJtYWRhX2NydGMuYyB8IDEwICsrKysr KysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfY3J0 Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfY3J0Yy5jCj4gPiBpbmRleCAyZTA2 NWZhY2RjZTcuLjg0NGQ0ODhiNjY1NCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h cm1hZGEvYXJtYWRhX2NydGMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1h ZGFfY3J0Yy5jCj4gPiBAQCAtMTI0NiwxMSArMTI0NiwxNCBAQCBzdGF0aWMgaW50IGFybWFkYV9k cm1fY3J0Y19jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRybSwgc3RydWN0IGRldmljZSAqZGV2 LAo+ID4gIAlkY3J0Yy0+Y3J0Yy5wb3J0ID0gcG9ydDsKPiA+ICAKPiA+ICAJcHJpbWFyeSA9IGt6 YWxsb2Moc2l6ZW9mKCpwcmltYXJ5KSwgR0ZQX0tFUk5FTCk7Cj4gPiAtCWlmICghcHJpbWFyeSkK PiA+ICsJaWYgKCFwcmltYXJ5KSB7Cj4gPiArCQlrZnJlZShkY3J0Yyk7Cj4gPiAgCQlyZXR1cm4g LUVOT01FTTsKPiA+ICsJfQo+ID4gIAo+ID4gIAlyZXQgPSBhcm1hZGFfZHJtX3BsYW5lX2luaXQo cHJpbWFyeSk7Cj4gPiAgCWlmIChyZXQpIHsKPiA+ICsJCWtmcmVlKGRjcnRjKTsKPiA+ICAJCWtm cmVlKHByaW1hcnkpOwo+ID4gIAkJcmV0dXJuIHJldDsKPiA+ICAJfQo+ID4gQEAgLTEyNjIsMTQg KzEyNjUsMTcgQEAgc3RhdGljIGludCBhcm1hZGFfZHJtX2NydGNfY3JlYXRlKHN0cnVjdCBkcm1f ZGV2aWNlICpkcm0sIHN0cnVjdCBkZXZpY2UgKmRldiwKPiA+ICAJCQkJICAgICAgIE5VTEwsCj4g PiAgCQkJCSAgICAgICBEUk1fUExBTkVfVFlQRV9QUklNQVJZLCBOVUxMKTsKPiA+ICAJaWYgKHJl dCkgewo+ID4gKwkJa2ZyZWUoZGNydGMpOwo+ID4gIAkJa2ZyZWUocHJpbWFyeSk7Cj4gPiAgCQly ZXR1cm4gcmV0Owo+ID4gIAl9Cj4gPiAgCj4gPiAgCXJldCA9IGRybV9jcnRjX2luaXRfd2l0aF9w bGFuZXMoZHJtLCAmZGNydGMtPmNydGMsICZwcmltYXJ5LT5iYXNlLCBOVUxMLAo+ID4gIAkJCQkJ JmFybWFkYV9jcnRjX2Z1bmNzLCBOVUxMKTsKPiA+IC0JaWYgKHJldCkKPiA+ICsJaWYgKHJldCkg ewo+ID4gKwkJa2ZyZWUoZGNydGMpOwo+ID4gIAkJZ290byBlcnJfY3J0Y19pbml0Owo+IAo+IFRo ZSBtaXhlZCB1c2Ugb2YgY2xlYW5pbmcgdXAgYXQgZXZlcnkgZXhpdCBhbmQgdGhlIGxvbmUgbGFi ZWwgaXMgYSBiaXQgbWVzc3kgYW5kCj4gcHJvbmUgdG8gYnVncyBzdWNoIGFzIHRoZSBvbmUgeW91 J3JlIGZpeGluZy4gSG93IGFib3V0IHlvdSBsYWJlbCBldmVyeXRoaW5nCj4gYW5kIHRoZW4ganVz dCBjbGVhbiB1cCBvbmNlPwoKSXQncyBub3QgdGhhdCBzaW1wbGUgLSBzZWUgYWx0ZXJuYXRpdmUg cGF0Y2ggYmVsb3cuICBIb3cgd2UgY2xlYW4Kc3R1ZmYgdXAgZGVwZW5kcyBvbiBob3cgZmFyIHRo cm91Z2ggdGhlIGluaXRpYWxpc2F0aW9uIHdlIGFyZSwgYW5kCnRoYXQgZG9lc24ndCBsZW5kIGl0 c2VsZiB0byBhIHNlcXVlbnRpYWwgY2xlYW51cCBtZXRob2RvbG9neS4KCj4gSXQgYWxzbyBzZWVt cyBsaWtlIHlvdSdyZSBtaXNzaW5nIGNsZWFudXAgaWYgYXJtYWRhX292ZXJsYXlfcGxhbmVfY3Jl YXRlKCkKPiBmYWlscz8KCkl0J3Mgbm90IG1pc3NpbmcuICBBdCB0aGF0IHBvaW50LCB0aGUgQ1JU QyBoYXMgYmVlbiByZWdpc3RlcmVkLCBhbmQgYW55CmZhaWx1cmUgd2lsbCBiZSBjbGVhbmVkIHVw IGJ5IHRoZSBkcm1fbW9kZV9jb25maWdfY2xlYW51cCgpIGluIHRoZQplcnJvciBwYXRocyBpbiBh cm1hZGFfZHJtX2JpbmQoKSBpbiBhcm1hZGFfZHJ2LmMKCkl0J3MgcmF0aGVyIG5vbi1vYnZpb3Vz IGJlY2F1c2UgaXQgdXNlcyB0aGUgLT5kZXN0cm95IGNhbGxiYWNrcy4KCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJt YWRhL2FybWFkYV9jcnRjLmMKaW5kZXggZDk4NzE5OGEyYWM2Li43OWNlODc3YmY0NWYgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm1hZGEvYXJtYWRhX2NydGMuYworKysgYi9kcml2ZXJz L2dwdS9kcm0vYXJtYWRhL2FybWFkYV9jcnRjLmMKQEAgLTEyMjUsMTcgKzEyMjUsMTMgQEAgc3Rh dGljIGludCBhcm1hZGFfZHJtX2NydGNfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0sIHN0 cnVjdCBkZXZpY2UgKmRldiwKIAogCXJldCA9IGRldm1fcmVxdWVzdF9pcnEoZGV2LCBpcnEsIGFy bWFkYV9kcm1faXJxLCAwLCAiYXJtYWRhX2RybV9jcnRjIiwKIAkJCSAgICAgICBkY3J0Yyk7Ci0J aWYgKHJldCA8IDApIHsKLQkJa2ZyZWUoZGNydGMpOwotCQlyZXR1cm4gcmV0OwotCX0KKwlpZiAo cmV0IDwgMCkKKwkJZ290byBlcnJfY3J0YzsKIAogCWlmIChkY3J0Yy0+dmFyaWFudC0+aW5pdCkg ewogCQlyZXQgPSBkY3J0Yy0+dmFyaWFudC0+aW5pdChkY3J0YywgZGV2KTsKLQkJaWYgKHJldCkg ewotCQkJa2ZyZWUoZGNydGMpOwotCQkJcmV0dXJuIHJldDsKLQkJfQorCQlpZiAocmV0KQorCQkJ Z290byBlcnJfY3J0YzsKIAl9CiAKIAkvKiBFbnN1cmUgQVhJIHBpcGVsaW5lIGlzIGVuYWJsZWQg Ki8KQEAgLTEyNDcsMTUgKzEyNDMsMTQgQEAgc3RhdGljIGludCBhcm1hZGFfZHJtX2NydGNfY3Jl YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0sIHN0cnVjdCBkZXZpY2UgKmRldiwKIAogCXByaW1h cnkgPSBremFsbG9jKHNpemVvZigqcHJpbWFyeSksIEdGUF9LRVJORUwpOwogCWlmICghcHJpbWFy eSkgewotCQlrZnJlZShkY3J0Yyk7Ci0JCXJldHVybiAtRU5PTUVNOworCQlyZXQgPSAtRU5PTUVN OworCQlnb3RvIGVycl9jcnRjOwogCX0KIAogCXJldCA9IGFybWFkYV9kcm1fcGxhbmVfaW5pdChw cmltYXJ5KTsKIAlpZiAocmV0KSB7Ci0JCWtmcmVlKGRjcnRjKTsKIAkJa2ZyZWUocHJpbWFyeSk7 Ci0JCXJldHVybiByZXQ7CisJCWdvdG8gZXJyX2NydGM7CiAJfQogCiAJcmV0ID0gZHJtX3VuaXZl cnNhbF9wbGFuZV9pbml0KGRybSwgJnByaW1hcnktPmJhc2UsIDAsCkBAIC0xMjY1LDE3ICsxMjYw LDE0IEBAIHN0YXRpYyBpbnQgYXJtYWRhX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZHJtLCBzdHJ1Y3QgZGV2aWNlICpkZXYsCiAJCQkJICAgICAgIE5VTEwsCiAJCQkJICAgICAg IERSTV9QTEFORV9UWVBFX1BSSU1BUlksIE5VTEwpOwogCWlmIChyZXQpIHsKLQkJa2ZyZWUoZGNy dGMpOwogCQlrZnJlZShwcmltYXJ5KTsKLQkJcmV0dXJuIHJldDsKKwkJZ290byBlcnJfY3J0YzsK IAl9CiAKIAlyZXQgPSBkcm1fY3J0Y19pbml0X3dpdGhfcGxhbmVzKGRybSwgJmRjcnRjLT5jcnRj LCAmcHJpbWFyeS0+YmFzZSwgTlVMTCwKIAkJCQkJJmFybWFkYV9jcnRjX2Z1bmNzLCBOVUxMKTsK LQlpZiAocmV0KSB7Ci0JCWtmcmVlKGRjcnRjKTsKKwlpZiAocmV0KQogCQlnb3RvIGVycl9jcnRj X2luaXQ7Ci0JfQogCiAJZHJtX2NydGNfaGVscGVyX2FkZCgmZGNydGMtPmNydGMsICZhcm1hZGFf Y3J0Y19oZWxwZXJfZnVuY3MpOwogCkBAIC0xMjg4LDYgKzEyODAsOSBAQCBzdGF0aWMgaW50IGFy bWFkYV9kcm1fY3J0Y19jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRybSwgc3RydWN0IGRldmlj ZSAqZGV2LAogCiBlcnJfY3J0Y19pbml0OgogCXByaW1hcnktPmJhc2UuZnVuY3MtPmRlc3Ryb3ko JnByaW1hcnktPmJhc2UpOworZXJyX2NydGM6CisJa2ZyZWUoZGNydGMpOworCiAJcmV0dXJuIHJl dDsKIH0KIAoKCi0tIApSTUsncyBQYXRjaCBzeXN0ZW06IGh0dHA6Ly93d3cuYXJtbGludXgub3Jn LnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBsaW5lIGlu IHN1YnVyYmlhOiBzeW5jIGF0IDguOE1icHMgZG93biA2MzBrYnBzIHVwCkFjY29yZGluZyB0byBz cGVlZHRlc3QubmV0OiA4LjIxTWJwcyBkb3duIDUxMGticHMgdXAKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==