From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/5] drm/armada: fix leak of crtc structure Date: Wed, 29 Nov 2017 20:11:53 +0000 Message-ID: <20171129201153.GH8356@n2100.armlinux.org.uk> References: <20171129114516.GD8356@n2100.armlinux.org.uk> <20171129145342.ripjickq7o75cvfj@art_vandelay> <20171129191643.GF8356@n2100.armlinux.org.uk> <20171129200309.xy3tz4xc4iqcnlgs@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id C434A6E0E9 for ; Wed, 29 Nov 2017 20:12:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171129200309.xy3tz4xc4iqcnlgs@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMjksIDIwMTcgYXQgMDM6MDM6MDlQTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFdlZCwgTm92IDI5LCAyMDE3IGF0IDA3OjE2OjQzUE0gKzAwMDAsIFJ1c3NlbGwgS2lu ZyAtIEFSTSBMaW51eCB3cm90ZToKPiA+IE9uIFdlZCwgTm92IDI5LCAyMDE3IGF0IDA5OjUzOjQy QU0gLTA1MDAsIFNlYW4gUGF1bCB3cm90ZToKPiA+ID4gT24gV2VkLCBOb3YgMjksIDIwMTcgYXQg MTE6NDU6NDNBTSArMDAwMCwgUnVzc2VsbCBLaW5nIHdyb3RlOgo+ID4gPiA+IEZpeCB0aGUgbGVh ayBvZiB0aGUgQ1JUQyBzdHJ1Y3R1cmUgaW4gdGhlIGZhaWx1cmUgcGF0aHMgb2YKPiA+ID4gPiBh cm1hZGFfZHJtX2NydGNfY3JlYXRlKCkuCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTog UnVzc2VsbCBLaW5nIDxybWsra2VybmVsQGFybWxpbnV4Lm9yZy51az4KPiA+ID4gPiAtLS0KPiA+ ID4gPiAgZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfY3J0Yy5jIHwgMTAgKysrKysrKyst LQo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2Fy bWFkYV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9jcnRjLmMKPiA+ID4g PiBpbmRleCAyZTA2NWZhY2RjZTcuLjg0NGQ0ODhiNjY1NCAxMDA2NDQKPiA+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9jcnRjLmMKPiA+ID4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYXJtYWRhL2FybWFkYV9jcnRjLmMKPiA+ID4gPiBAQCAtMTI0NiwxMSArMTI0Niwx NCBAQCBzdGF0aWMgaW50IGFybWFkYV9kcm1fY3J0Y19jcmVhdGUoc3RydWN0IGRybV9kZXZpY2Ug KmRybSwgc3RydWN0IGRldmljZSAqZGV2LAo+ID4gPiA+ICAJZGNydGMtPmNydGMucG9ydCA9IHBv cnQ7Cj4gPiA+ID4gIAo+ID4gPiA+ICAJcHJpbWFyeSA9IGt6YWxsb2Moc2l6ZW9mKCpwcmltYXJ5 KSwgR0ZQX0tFUk5FTCk7Cj4gPiA+ID4gLQlpZiAoIXByaW1hcnkpCj4gPiA+ID4gKwlpZiAoIXBy aW1hcnkpIHsKPiA+ID4gPiArCQlrZnJlZShkY3J0Yyk7Cj4gPiA+ID4gIAkJcmV0dXJuIC1FTk9N RU07Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJcmV0ID0gYXJtYWRhX2RybV9wbGFu ZV9pbml0KHByaW1hcnkpOwo+ID4gPiA+ICAJaWYgKHJldCkgewo+ID4gPiA+ICsJCWtmcmVlKGRj cnRjKTsKPiA+ID4gPiAgCQlrZnJlZShwcmltYXJ5KTsKPiA+ID4gPiAgCQlyZXR1cm4gcmV0Owo+ ID4gPiA+ICAJfQo+ID4gPiA+IEBAIC0xMjYyLDE0ICsxMjY1LDE3IEBAIHN0YXRpYyBpbnQgYXJt YWRhX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLCBzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4gPiA+ID4gIAkJCQkgICAgICAgTlVMTCwKPiA+ID4gPiAgCQkJCSAgICAgICBEUk1f UExBTkVfVFlQRV9QUklNQVJZLCBOVUxMKTsKPiA+ID4gPiAgCWlmIChyZXQpIHsKPiA+ID4gPiAr CQlrZnJlZShkY3J0Yyk7Cj4gPiA+ID4gIAkJa2ZyZWUocHJpbWFyeSk7Cj4gPiA+ID4gIAkJcmV0 dXJuIHJldDsKPiA+ID4gPiAgCX0KPiA+ID4gPiAgCj4gPiA+ID4gIAlyZXQgPSBkcm1fY3J0Y19p bml0X3dpdGhfcGxhbmVzKGRybSwgJmRjcnRjLT5jcnRjLCAmcHJpbWFyeS0+YmFzZSwgTlVMTCwK PiA+ID4gPiAgCQkJCQkmYXJtYWRhX2NydGNfZnVuY3MsIE5VTEwpOwo+ID4gPiA+IC0JaWYgKHJl dCkKPiA+ID4gPiArCWlmIChyZXQpIHsKPiA+ID4gPiArCQlrZnJlZShkY3J0Yyk7Cj4gPiA+ID4g IAkJZ290byBlcnJfY3J0Y19pbml0Owo+ID4gPiAKPiA+ID4gVGhlIG1peGVkIHVzZSBvZiBjbGVh bmluZyB1cCBhdCBldmVyeSBleGl0IGFuZCB0aGUgbG9uZSBsYWJlbCBpcyBhIGJpdCBtZXNzeSBh bmQKPiA+ID4gcHJvbmUgdG8gYnVncyBzdWNoIGFzIHRoZSBvbmUgeW91J3JlIGZpeGluZy4gSG93 IGFib3V0IHlvdSBsYWJlbCBldmVyeXRoaW5nCj4gPiA+IGFuZCB0aGVuIGp1c3QgY2xlYW4gdXAg b25jZT8KPiA+IAo+ID4gSXQncyBub3QgdGhhdCBzaW1wbGUgLSBzZWUgYWx0ZXJuYXRpdmUgcGF0 Y2ggYmVsb3cuICBIb3cgd2UgY2xlYW4KPiA+IHN0dWZmIHVwIGRlcGVuZHMgb24gaG93IGZhciB0 aHJvdWdoIHRoZSBpbml0aWFsaXNhdGlvbiB3ZSBhcmUsIGFuZAo+ID4gdGhhdCBkb2Vzbid0IGxl bmQgaXRzZWxmIHRvIGEgc2VxdWVudGlhbCBjbGVhbnVwIG1ldGhvZG9sb2d5Lgo+IAo+IEl0IGNh biBiZSB0aGF0IHNpbXBsZSwgZGVwZW5kaW5nIG9uIGhvdyB5b3Ugc2V0dXAgeW91ciBpbml0aWFs aXphdGlvbiBzZXF1ZW5jZS4KPiBGb3IgaW5zdGFuY2UsIGlmIGFybWFkYV9wbGFuZV9pbml0IGRp ZCB0aGUgYWxsb2NhdGlvbiBhcyB3ZWxsIGFzCj4gdW5pdmVyc2FsX3BsYW5lX2luaXQgKGxpa2Ug YXJtYWRhX292ZXJsYXlfcGxhbmVfY3JlYXRlIGFscmVhZHkgZG9lcyksIHRoZW4geW91Cj4gd291 bGRuJ3QgbmVlZCB0byB3b3JyeSBhYm91dCBrZnJlZShwcmltYXJ5KSBhdCBhbGwuCgpUd28gcHJv YmxlbXMgd2l0aCB0aGF0OgoKMS4gVGhlIHVuZGVybHlpbmcgcGxhbmUgc3RydWN0dXJlcyBmb3Ig dGhlIHByaW1hcnkgYW5kIG92ZXJsYXkgcGxhbmVzCiAgIGFyZSBkaWZmZXJlbnQuCgoyLiB0aGUg Y2FsbHMgdG8gZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KCkgYXJlIHJhdGhlciBkaWZmZXJlbnQ6 CgotIHByaW1hcnk6CiAgICAgICAgcmV0ID0gZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KGRybSwg JnByaW1hcnktPmJhc2UsIDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICZhcm1hZGFfcHJpbWFyeV9wbGFuZV9mdW5jcywKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYXJtYWRhX3ByaW1hcnlfZm9ybWF0cywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgQVJSQVlfU0laRShhcm1hZGFfcHJpbWFyeV9mb3JtYXRzKSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSwgTlVMTCk7Cgot IG92ZXJsYXk6CiAgICAgICAgcmV0ID0gZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KGRldiwgJmRw bGFuZS0+YmFzZS5iYXNlLCBjcnRjcywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJmFybWFkYV9vdmxfcGxhbmVfZnVuY3MsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGFybWFkYV9vdmxfZm9ybWF0cywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgQVJSQVlfU0laRShhcm1hZGFfb3ZsX2Zvcm1hdHMpLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBEUk1fUExBTkVfVFlQRV9PVkVSTEFZLCBOVUxMKTsKCk1vdmluZyB0 aGUgZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KCkgY2FsbCBpbnRvIGFybWFkYV9kcm1fcGxhbmVf aW5pdCgpCmluIGEgcGF0Y2ggdG8gZml4IGEgbGVhayBkb2Vzbid0IG1ha2Ugc2Vuc2UgLSB5b3Un cmUgYWN0dWFsbHkgYXNraW5nIGZvcgphIG1hc3NpdmUgcmV3cml0ZSBvZiB0aGUgY29kZSAoSSBk byBoYXZlIHBhdGNoZXMgd2hpY2ggSSdtIGludGVuZGluZyB0bwpzZW5kIGFmdGVyIHRoaXMgc2Vy aWVzIHdoaWNoIGRvIHF1aXRlIGEgbG90IG9mIHJlLW9yZ2FuaXNhdGlvbiBvZiB0aGlzCnBsYW5l IGNvZGUsIGJ1dCBJIHdhbnQgdG8gZ2V0IHRoZSBmaXhlcyBzb3J0ZWQgYmVmb3JlIEkgcG9zdCB0 aGF0LikKCi0tIApSTUsncyBQYXRjaCBzeXN0ZW06IGh0dHA6Ly93d3cuYXJtbGludXgub3JnLnVr L2RldmVsb3Blci9wYXRjaGVzLwpGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBsaW5lIGluIHN1 YnVyYmlhOiBzeW5jIGF0IDguOE1icHMgZG93biA2MzBrYnBzIHVwCkFjY29yZGluZyB0byBzcGVl ZHRlc3QubmV0OiA4LjIxTWJwcyBkb3duIDUxMGticHMgdXAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==