From: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
To: "Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Cc: "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"Li, Samuel" <Samuel.Li-5C7GfCeVMHo@public.gmane.org>,
Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Subject: Re: [PATCH 1/3] drm/prime: forward begin_cpu_access callback to drivers
Date: Thu, 21 Dec 2017 11:04:24 +0100 [thread overview]
Message-ID: <20171221100424.GT26573@phenom.ffwll.local> (raw)
In-Reply-To: <4c0df435-913c-7569-591b-f15c212bc249-5C7GfCeVMHo@public.gmane.org>
On Wed, Dec 20, 2017 at 08:54:33PM +0100, Christian König wrote:
> Am 20.12.2017 um 20:43 schrieb Daniel Vetter:
> > On Wed, Dec 20, 2017 at 6:20 PM, Li, Samuel <Samuel.Li@amd.com> wrote:
> > > Ping... can someone please review this patch?
> > Might be simpler to implement your own dma-buf backend instead of
> > going through the drm_prime midlayer. That was mostly written to give
> > nvidia a set of non-EXPORT_GPL symbols to support dma-buf. Or
> > something like that.
>
> Ah, that explains that. Well the alternative Sam suggest was to export most
> of the functions implementing that.
Yeah that sounds like a good idea, makes it feel less midlayer-y.
> But then we have a hard time having a common detection logic if a DMA-buf
> has a GEM object behind it or not.
Hm, why do you need that? I guess you'll care whether it's an
amdgpu-exported one, and you can still do that by checking against your
own dma_buf_ops table. We do the same in i915, without using the core
drm_prime helpers.
> > Also don't expect people to look at patches when CI bots spot issues.
>
> That is either a false positive or a one liner.
Hey it's holiday seasons, leave me some cheap excuses pls :-)
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-12-21 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 16:28 [PATCH 1/3] drm/prime: forward begin_cpu_access callback to drivers Samuel Li
[not found] ` <1513355282-20248-1-git-send-email-Samuel.Li-5C7GfCeVMHo@public.gmane.org>
2017-12-16 5:40 ` kbuild test robot
2017-12-16 6:29 ` kbuild test robot
2017-12-20 17:20 ` Li, Samuel
2017-12-20 19:43 ` Daniel Vetter
2017-12-20 19:54 ` Christian König
[not found] ` <4c0df435-913c-7569-591b-f15c212bc249-5C7GfCeVMHo@public.gmane.org>
2017-12-21 10:04 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221100424.GT26573@phenom.ffwll.local \
--to=daniel-/w4ywyx8dfk@public.gmane.org \
--cc=Samuel.Li-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox