From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com
Cc: airlied@linux.ie, jsarha@ti.com, dri-devel@lists.freedesktop.org
Subject: [PATCH 1/2] drm/blend: Account also the primary plane of the crtc for normalized_zpos
Date: Thu, 21 Dec 2017 14:11:00 +0200 [thread overview]
Message-ID: <20171221121101.29161-2-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20171221121101.29161-1-peter.ujfalusi@ti.com>
Make sure that the primary plane will get normalized_zpos=0 if it's zpos is
set to 0, avoiding other planes to be placed in the background.
If user space wants to move the primary plane forward, it can set the zpos
of the plane.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/gpu/drm/drm_blend.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
index 4c62dff14893..bdc4f714afb8 100644
--- a/drivers/gpu/drm/drm_blend.c
+++ b/drivers/gpu/drm/drm_blend.c
@@ -301,7 +301,11 @@ static int drm_atomic_state_zpos_cmp(const void *a, const void *b)
const struct drm_plane_state *sa = *(struct drm_plane_state **)a;
const struct drm_plane_state *sb = *(struct drm_plane_state **)b;
- if (sa->zpos != sb->zpos)
+ if (sa->plane == sa->crtc->primary && sa->zpos == 0)
+ return -1;
+ else if (sb->plane == sb->crtc->primary && sb->zpos == 0)
+ return 1;
+ else if (sa->zpos != sb->zpos)
return sa->zpos - sb->zpos;
else
return sa->plane->base.id - sb->plane->base.id;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-12-21 12:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 12:10 [PATCH 0/2] drm blend/omap: normalized zpos handling Peter Ujfalusi
2017-12-21 12:11 ` Peter Ujfalusi [this message]
2017-12-21 12:55 ` [PATCH 1/2] drm/blend: Account also the primary plane of the crtc for normalized_zpos Ville Syrjälä
2017-12-21 13:44 ` Tomi Valkeinen
2017-12-21 14:20 ` Ville Syrjälä
2017-12-21 14:31 ` Tomi Valkeinen
2017-12-21 15:12 ` Ville Syrjälä
2017-12-22 9:16 ` Tomi Valkeinen
2017-12-22 10:12 ` Ville Syrjälä
2017-12-22 15:15 ` Peter Ujfalusi
2018-01-09 12:42 ` Daniel Vetter
2018-01-09 13:40 ` Laurent Pinchart
2018-01-09 14:29 ` Daniel Vetter
2017-12-21 12:11 ` [PATCH 2/2] drm/omap: Normalize the zpos and use the normalized_zpos in runtime Peter Ujfalusi
2017-12-21 13:17 ` Daniel Vetter
2017-12-22 6:38 ` Peter Ujfalusi
2018-01-09 8:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221121101.29161-2-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox