From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 3/8] drm/i915/psr: Avoid initializing PSR if there is no sink support. Date: Wed, 3 Jan 2018 13:59:11 -0800 Message-ID: <20180103215911.66dk2mwghwb4r4wi@intel.com> References: <20171219052659.2355-1-dhinakaran.pandiyan@intel.com> <20171219052659.2355-4-dhinakaran.pandiyan@intel.com> <20171219212936.hgfunngspyvvdnvd@intel.com> <1513720900.22022.28.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1513720900.22022.28.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org CmZpcnN0IG9mIGFsbCBzb3JyeSBmb3Igbm90IGdldHRpbmcgYmFjayBzb29uZXIgb24gdGhpcy4u LgoKT24gVHVlLCBEZWMgMTksIDIwMTcgYXQgMDk6NDA6MDFQTSArMDAwMCwgUGFuZGl5YW4sIERo aW5ha2FyYW4gd3JvdGU6Cj4gCj4gCj4gCj4gT24gVHVlLCAyMDE3LTEyLTE5IGF0IDEzOjI5IC0w ODAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gPiBPbiBUdWUsIERlYyAxOSwgMjAxNyBhdCAwNToy Njo1NEFNICswMDAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdyb3RlOgo+ID4gPiBEUENEIHJlYWQg Zm9yIHRoZSBlRFAgaXMgY29tcGxldGUgYnkgdGhlIHRpbWUgaW50ZWxfcHNyX2luaXQoKSBpcwo+ ID4gPiBjYWxsZWQsIHdoaWNoIG1lYW5zIHdlIGNhbiBhdm9pZCBpbml0aWFsaXppbmcgUFNSIHN0 cnVjdHVyZXMgYW5kIHN0YXRlCj4gPiA+IGlmIHRoZXJlIGlzIG5vIHNpbmsgc3VwcG9ydC4KPiA+ ID4gCj4gPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiA+ IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4g PiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFu QGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYyB8IDcgKysrKysrLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy LmMgICAgfCA5ICsrKysrKysrKwo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVn ZnMuYwo+ID4gPiBpbmRleCA2NGU1YTI2MzQ1OGMuLjFhN2IyOGY2MjU3MCAxMDA2NDQKPiA+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiA+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiA+ID4gQEAgLTI1MzIsMTQgKzI1MzIs MTkgQEAgc3RhdGljIGludCBpOTE1X2VkcF9wc3Jfc3RhdHVzKHN0cnVjdCBzZXFfZmlsZSAqbSwg dm9pZCAqZGF0YSkKPiA+ID4gIAl1MzIgc3RhdFszXTsKPiA+ID4gIAllbnVtIHBpcGUgcGlwZTsK PiA+ID4gIAlib29sIGVuYWJsZWQgPSBmYWxzZTsKPiA+ID4gKwlib29sIHNpbmtfc3VwcG9ydDsK PiA+ID4gIAo+ID4gPiAgCWlmICghSEFTX1BTUihkZXZfcHJpdikpCj4gPiA+ICAJCXJldHVybiAt RU5PREVWOwo+ID4gPiAgCj4gPiA+ICsJc2lua19zdXBwb3J0ID0gZGV2X3ByaXYtPnBzci5zaW5r X3N1cHBvcnQ7Cj4gPiA+ICsJc2VxX3ByaW50ZihtLCAiU2lua19TdXBwb3J0OiAlc1xuIiwgeWVz bm8oc2lua19zdXBwb3J0KSk7Cj4gPiA+ICsJaWYgKCFzaW5rX3N1cHBvcnQpCj4gPiA+ICsJCXJl dHVybiAwOwo+ID4gPiArCj4gPiA+ICAJaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+ ID4gPiAgCj4gPiA+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiA+ID4gLQlz ZXFfcHJpbnRmKG0sICJTaW5rX1N1cHBvcnQ6ICVzXG4iLCB5ZXNubyhkZXZfcHJpdi0+cHNyLnNp bmtfc3VwcG9ydCkpOwo+ID4gPiAgCXNlcV9wcmludGYobSwgIkVuYWJsZWQ6ICVzXG4iLCB5ZXNu bygoYm9vbClkZXZfcHJpdi0+cHNyLmVuYWJsZWQpKTsKPiA+ID4gIAlzZXFfcHJpbnRmKG0sICJB Y3RpdmU6ICVzXG4iLCB5ZXNubyhkZXZfcHJpdi0+cHNyLmFjdGl2ZSkpOwo+ID4gPiAgCXNlcV9w cmludGYobSwgIkJ1c3kgZnJvbnRidWZmZXIgYml0czogMHglMDN4XG4iLAo+ID4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wc3IuYwo+ID4gPiBpbmRleCA3NjMzOWNmMzg3Y2IuLjA5NWUwYTVhODU3NCAx MDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gQEAgLTUwMyw2ICs1 MDMsOSBAQCB2b2lkIGludGVsX3Bzcl9lbmFibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwK PiA+ID4gIAlpZiAoIWNydGNfc3RhdGUtPmhhc19wc3IpCj4gPiA+ICAJCXJldHVybjsKPiA+ID4g IAo+ID4gPiArCWlmIChXQVJOX09OKCFDQU5fUFNSKGRldl9wcml2KSkpCj4gPiA+ICsJCXJldHVy bjsKPiA+IAo+ID4gaG1tLi4uIEkgYmVsaWV2ZSB3ZSB3aWxsIHNlZSB0aGlzIHdhcm5pbmcgc29v bmVyIHRoYW4gbGF0ZXIuLi4KPiA+IAo+ID4gaGFzX3BzciBpcyBub3QgdGhlIHNhbWUgYXMgQ0FO X1BTUi4KPiAKPiBoYXNfcHNyIHNob3VsZCBub3QgYmUgc2V0IGluIHBzcl9jb21wdXRlX2NvbmZp ZygpIHVubGVzcyBib3RoIHNvdXJjZSBhbmQKPiBzaW5rIGhhdmUgUFNSLiBTbywgdGhlIHdhcm5f b24gaXMgaWYgd2UgbWVzcyB1cCB0aGUgc3RhdGUgcHJlcGFyYXRpb24uCj4gPiAKPiA+IGFsc28s IGJ0dyBJIGRpZG4ndCBsaWtlIGFsbCB0aGlzIGNydGNfc3RhdGUgaGFzX3BzciB4IGhhc19wc3Iy LiA6Lwo+ID4gCj4gPiBwcm9iYWJseSB0aGlzIHNlcmllcyBjb3VsZCBhbHNvIHVuaWZ5IHRoYXQg YW5kIGNsZWFuIGl0IHVwLgo+ID4gdG8gbWFueSBoYXNfcHNyIGxpa2UgY2FzZXMuCj4gPiAKPiA+ ID4gKwo+ID4gPiAgCVdBUk5fT04oZGV2X3ByaXYtPmRycnMuZHApOwo+ID4gPiAgCW11dGV4X2xv Y2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gPiA+ICAJaWYgKGRldl9wcml2LT5wc3IuZW5hYmxl ZCkgewo+ID4gPiBAQCAtNjMzLDYgKzYzNiw5IEBAIHZvaWQgaW50ZWxfcHNyX2Rpc2FibGUoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiA+ID4gIAlpZiAoIW9sZF9jcnRjX3N0YXRlLT5oYXNf cHNyKQo+ID4gPiAgCQlyZXR1cm47Cj4gPiA+ICAKPiA+ID4gKwlpZiAoV0FSTl9PTighQ0FOX1BT UihkZXZfcHJpdikpKQo+ID4gPiArCQlyZXR1cm47Cj4gPiA+ICsKPiA+ID4gIAltdXRleF9sb2Nr KCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+ID4gPiAgCWlmICghZGV2X3ByaXYtPnBzci5lbmFibGVk KSB7Cj4gPiA+ICAJCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiA+ID4gQEAg LTkxMyw2ICs5MTksOSBAQCB2b2lkIGludGVsX3Bzcl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiA+ID4gIAlkZXZfcHJpdi0+cHNyX21taW9fYmFzZSA9IElTX0hBU1dF TEwoZGV2X3ByaXYpID8KPiA+ID4gIAkJSFNXX0VEUF9QU1JfQkFTRSA6IEJEV19FRFBfUFNSX0JB U0U7Cj4gPiA+ICAKPiA+ID4gKwlpZiAoIWRldl9wcml2LT5wc3Iuc2lua19zdXBwb3J0KQo+ID4g PiArCQlyZXR1cm47Cj4gPiA+ICsKPiA+IAo+ID4gV2h5IG5vdCB1c2UgQ0FOX1BTUiBoZXJlPwo+ IAo+IAo+IFNvIHRoYXQgd2UgaGF2ZSB0aGUgcmlnaHQgTU1JTydzIGluIGNhc2Ugd2Ugd2FudCB0 byBwcm9iZSB0aGUgSFcgd2l0aCBubwo+IHNpbmsgc3VwcG9ydC4gSSB3YXNuJ3Qgd2hhdCB3b3Vs ZCBoYXBwZW4gaWYgd2UgcmVnX3JlYWQoKSBvbiBQU1IKPiByZWdpc3RlcnMgd2l0aG91dCB0aGUg Y29ycmVjdCBNTUlPIGJhc2UuCgpCdXQgaXNuJ3QgdGhlIGdvYWwgb2YgQ0FOX1BTUiB0byBhdm9p ZCBhbnkgZXh0cmEgY2FsbHMgb24gcGxhdGZvcm1zCnRoYXQgZWl0aGVyIGRvZXNuJ3QgaGF2ZSBz dXBwb3J0IG5vciB0aGUgcGFuZWw/IEluIHRoaXMgY2FzZSB3ZSBzaG91bGQKbmV2ZXIgYmVpbmcg dG91Y2hpbmcgYW55IHJlZ2lzdGVyLgoKPiAKPiA+IAo+ID4gPiAgCS8qIFBlciBwbGF0Zm9ybSBk ZWZhdWx0OiBhbGwgZGlzYWJsZWQuICovCj4gPiA+ICAJaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJs ZV9wc3IgPT0gLTEpCj4gPiA+ICAJCWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9wc3IgPSAwOwo+ID4g PiAtLSAKPiA+ID4gMi4xMS4wCj4gPiA+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK