From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/vc4: Expose performance counters to userspace
Date: Fri, 12 Jan 2018 09:49:55 +0100 [thread overview]
Message-ID: <20180112094955.5a53f9c3@bbrezillon> (raw)
In-Reply-To: <87zi5jykw3.fsf@anholt.net>
On Thu, 11 Jan 2018 16:35:08 -0800
Eric Anholt <eric@anholt.net> wrote:
> Could we add some docs for get_values? Like:
Sure.
>
> /*
> * Returns the values of the performance counters tracked by this
> * perfmon (as an array of ncounters u64 values).
> *
> * No implicit synchronization is performed, so the user has to
> * guarantee that any jobs using this perfmon have already been
> * completed (probably by blocking on the seqno returned by the
> * last exec that used the perfmon).
> */
>
> With that,
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> > +struct drm_vc4_perfmon_get_values {
> > + __u32 id;
> > + __u64 values_ptr;
> > +};
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-01-12 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 9:32 [PATCH v2] drm/vc4: Expose performance counters to userspace Boris Brezillon
2018-01-12 0:35 ` Eric Anholt
2018-01-12 8:49 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112094955.5a53f9c3@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox