dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chunming Zhou <zhoucm1@amd.com>
Cc: "Michel D鋘zer" <michel@daenzer.net>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, "Zhu, Seth" <Seth.Zhu@amd.com>,
	christian.koenig@amd.com
Subject: Re: [PATCH libdrm] drm: fix return value
Date: Wed, 17 Jan 2018 10:31:09 +0100	[thread overview]
Message-ID: <20180117093109.GL2759@phenom.ffwll.local> (raw)
In-Reply-To: <8a91b7d7-8d30-694d-3bd0-f96e7663151d@amd.com>

On Wed, Jan 17, 2018 at 05:26:41PM +0800, Chunming Zhou wrote:
> 
> 
> On 2018年01月17日 17:24, Christian König wrote:
> > Am 17.01.2018 um 09:53 schrieb Chunming Zhou:
> > > 
> > > 
> > > On 2018年01月17日 16:21, Daniel Vetter wrote:
> > > > On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote:
> > > > > Can your guys help me push it and last vamgr patches to upstream?
> > > > > My new count request for libdrm still is under pending.
> > > > Or hand out commmit rights? That's easier long-term imo ...
> > > That's not true, we need to track the commit for driver release, if
> > > we have no permission to push it, we often need to check the patch
> > > status to see if it's already in there.
> > > Are you admin for count request? if you are, and approve my count
> > > request, I greatly appreciate your approval.
> > 
> > David, sounds like a misunderstanding. What Daniel suggested was that
> > you should get commit rights, so that you can commit it yourself :)
> > 
> > But that's actually what we are already trying to do. It's just that the
> > account request seems to take a while.
> > 
> > If Alex hasn't already forwarded the request to the Admins please post
> > the link once more and I or Daniel can take care of it.
> https://bugs.freedesktop.org/show_bug.cgi?id=104631
> Michel and Alex have committed.

fd.o admins are drowning a bit under meltdown/spectre (and there's
apparently a pile more serious exploits that need to be patched asap).

I'd ping them next week on #freedesktop if it hasn't happened by then.
-Daniel

> 
> Thanks,
> David Zhou
> > 
> > Regards,
> > Christian.
> > 
> > > 
> > > Regards,
> > > David Zhou
> > > > -Daniel
> > > > 
> > > > > Thanks,
> > > > > David Zhou
> > > > > 
> > > > > 
> > > > > 发自坚果 Pro
> > > > > 
> > > > > Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于
> > > > > 2018年1月16日 下午4:56写道:
> > > > > 
> > > > > Apart from that a good catch and Reviewed-by: Christian König
> > > > > <christian.koenig@amd.com>.
> > > > > 
> > > > > Regards,
> > > > > Christian.
> > > > > 
> > > > > Am 16.01.2018 um 09:49 schrieb Michel Dänzer:
> > > > > > Moving from the amd-gfx list to dri-devel, since this
> > > > > > isn't amdgpu specific.
> > > > > > 
> > > > > > 
> > > > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote:
> > > > > > > otherwise -ETIME is missed.
> > > > > > > 
> > > > > > > Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423
> > > > > > > Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
> > > > > > > ---
> > > > > > >    xf86drm.c | 2 +-
> > > > > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > > 
> > > > > > > diff --git a/xf86drm.c b/xf86drm.c
> > > > > > > index 8a327170..3881bd9f 100644
> > > > > > > --- a/xf86drm.c
> > > > > > > +++ b/xf86drm.c
> > > > > > > @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd,
> > > > > > > uint32_t *handles, unsigned num_handles,
> > > > > > > 
> > > > > > >        ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args);
> > > > > > >        if (ret < 0)
> > > > > > > -            return ret;
> > > > > > > +            return -errno;
> > > > > > > 
> > > > > > >        if (first_signaled)
> > > > > > >                *first_signaled = args.first_signaled;
> > > > > > > 
> > > > > _______________________________________________
> > > > > dri-devel mailing list
> > > > > dri-devel@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > > 
> > > 
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-01-17  9:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180116025401.18906-1-david1.zhou@amd.com>
2018-01-16  8:49 ` [PATCH libdrm] drm: fix return value Michel Dänzer
2018-01-16  8:56   ` Christian König
2018-01-16 14:01     ` Zhou, David(ChunMing)
2018-01-17  8:21       ` Daniel Vetter
2018-01-17  8:53         ` Chunming Zhou
2018-01-17  9:24           ` Christian König
2018-01-17  9:26             ` Chunming Zhou
2018-01-17  9:31               ` Daniel Vetter [this message]
2018-01-31  2:49                 ` Chunming Zhou
2018-01-31  8:09                   ` Daniel Vetter
2018-01-16  2:54 Chunming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117093109.GL2759@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=Seth.Zhu@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=michel@daenzer.net \
    --cc=zhoucm1@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox