From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure Date: Wed, 31 Jan 2018 09:12:32 +0100 Message-ID: <20180131081231.GX25930@phenom.ffwll.local> References: <20180117184429.7809-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180117184429.7809-1-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, Jan 17, 2018 at 08:44:29PM +0200, Laurent Pinchart wrote: > Since commit 2fc4d838aaf2 ("drm: rcar: use generic code for managing > zpos plane property") the rcar-du driver stores the plane zpos in the > drm_plane_state structure. The commit however forgot to remove the zpos > field from the rcar_du_vsp_plane_state structure. Remove it. > > Fixes: 2fc4d838aaf2 ("drm: rcar: use generic code for managing zpos plane property") > Signed-off-by: Laurent Pinchart More Cc: helps sometimes, e.g. dim fixes autoadds all you ever want :-) Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.h b/drivers/gpu/drm/rcar-du/rcar_du_vsp.h > index f876c512163c..4c5d7bbce6aa 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.h > @@ -45,7 +45,6 @@ static inline struct rcar_du_vsp_plane *to_rcar_vsp_plane(struct drm_plane *p) > * @format: information about the pixel format used by the plane > * @sg_tables: scatter-gather tables for the frame buffer memory > * @alpha: value of the plane alpha property > - * @zpos: value of the plane zpos property > */ > struct rcar_du_vsp_plane_state { > struct drm_plane_state state; > @@ -54,7 +53,6 @@ struct rcar_du_vsp_plane_state { > struct sg_table sg_tables[3]; > > unsigned int alpha; > - unsigned int zpos; > }; > > static inline struct rcar_du_vsp_plane_state * > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch