From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: simple_kms_helper: Add mode_valid() callback support Date: Mon, 19 Feb 2018 10:40:45 +0100 Message-ID: <20180219094045.GJ22199@phenom.ffwll.local> References: <20180206121854.4407-1-linus.walleij@linaro.org> <20180206121854.4407-2-linus.walleij@linaro.org> <87bmgwdb71.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9835F892C0 for ; Mon, 19 Feb 2018 09:40:49 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id t74so13913881wme.3 for ; Mon, 19 Feb 2018 01:40:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <87bmgwdb71.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Peter Ujfalusi , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBGZWIgMTAsIDIwMTggYXQgMDU6MDg6MzRQTSArMDAwMCwgRXJpYyBBbmhvbHQgd3Jv dGU6Cj4gTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPiB3cml0ZXM6Cj4g Cj4gPiBUaGUgUEwxMTEgbmVlZHMgdG8gZmlsdGVyIHZhbGlkIG1vZGVzIGJhc2VkIG9uIG1lbW9y eSBiYW5kd2lkdGguCj4gPiBJIGd1ZXNzIGl0IGlzIGEgcHJldHR5IHNpbXBsZSBvcGVyYXRpb24s IHNvIHdlIGNhbiBzdGlsbCBjbGFpbQo+ID4gdGhlIERSTSBLTVMgaGVscGVyIHBpcGVsaW5lIGlz IHNpbXBsZSBhZnRlciBhZGRpbmcgdGhpcyAob3B0aW9uYWwpCj4gPiB2dGFibGUgY2FsbGJhY2su Cj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5h cm8ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBl ci5jIHwgMTUgKysrKysrKysrKysrKysrCj4gPiAgaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNf aGVscGVyLmggICAgIHwgMTUgKysrKysrKysrKysrKysrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAz MCBpbnNlcnRpb25zKCspCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f c2ltcGxlX2ttc19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxw ZXIuYwo+ID4gaW5kZXggZGM5ZmQxMDlkZTE0Li5iNzg0MGNmMzQ4MDggMTAwNjQ0Cj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmMKPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuYwo+ID4gQEAgLTM0LDYgKzM0LDIwIEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2VuY29kZXJfZnVuY3MgZHJtX3NpbXBsZV9rbXNfZW5j b2Rlcl9mdW5jcyA9IHsKPiA+ICAJLmRlc3Ryb3kgPSBkcm1fZW5jb2Rlcl9jbGVhbnVwLAo+ID4g IH07Cj4gPiAgCj4gPiArc3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzCj4gPiArZHJtX3NpbXBs ZV9rbXNfY3J0Y19tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ICsJCQkgICAg ICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCj4gPiArewo+ID4gKwlzdHJ1 Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUgKnBpcGU7Cj4gPiArCj4gPiArCXBpcGUgPSBjb250 YWluZXJfb2YoY3J0Yywgc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlLCBjcnRjKTsKPiA+ ICsJaWYgKCFwaXBlLT5mdW5jcyB8fCAhcGlwZS0+ZnVuY3MtPm1vZGVfdmFsaWQpCj4gPiArCQkv KiBBbnl0aGluZyBnb2VzICovCj4gPiArCQlyZXR1cm4gTU9ERV9PSzsKPiA+ICsKPiA+ICsJcmV0 dXJuIHBpcGUtPmZ1bmNzLT5tb2RlX3ZhbGlkKGNydGMsIG1vZGUpOwo+ID4gK30KPiA+ICsKPiA+ ICBzdGF0aWMgaW50IGRybV9zaW1wbGVfa21zX2NydGNfY2hlY2soc3RydWN0IGRybV9jcnRjICpj cnRjLAo+ID4gIAkJCQkgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gPiAgewo+ ID4gQEAgLTcyLDYgKzg2LDcgQEAgc3RhdGljIHZvaWQgZHJtX3NpbXBsZV9rbXNfY3J0Y19kaXNh YmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgZHJtX3NpbXBsZV9rbXNfY3J0Y19oZWxwZXJf ZnVuY3MgPSB7Cj4gPiArCS5tb2RlX3ZhbGlkID0gZHJtX3NpbXBsZV9rbXNfY3J0Y19tb2RlX3Zh bGlkLAo+ID4gIAkuYXRvbWljX2NoZWNrID0gZHJtX3NpbXBsZV9rbXNfY3J0Y19jaGVjaywKPiA+ ICAJLmF0b21pY19lbmFibGUgPSBkcm1fc2ltcGxlX2ttc19jcnRjX2VuYWJsZSwKPiA+ICAJLmF0 b21pY19kaXNhYmxlID0gZHJtX3NpbXBsZV9rbXNfY3J0Y19kaXNhYmxlLAo+ID4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJt X3NpbXBsZV9rbXNfaGVscGVyLmgKPiA+IGluZGV4IDZkOWFkYmI0NjI5My4uYWQ3NGNiMzNjNTM5 IDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmgKPiA+ ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5oCj4gPiBAQCAtMjEsNiAr MjEsMjEgQEAgc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlOwo+ID4gICAqICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRpc3BsYXkgcGlwZWxpbmUKPiA+ICAgKi8K PiA+ICBzdHJ1Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGVfZnVuY3Mgewo+ID4gKwkvKioKPiA+ ICsJICogQG1vZGVfdmFsaWQ6Cj4gPiArCSAqCj4gPiArCSAqIFRoaXMgZnVuY3Rpb24gaXMgY2Fs bGVkIHRvIGZpbHRlciBvdXQgdmFsaWQgbW9kZXMgZnJvbSB0aGUKPiA+ICsJICogc3VnZ2VzdGlv bnMgc3VnZ2VzdGVkIGJ5IHRoZSBicmlkZ2Ugb3IgZGlzcGxheS4gVGhpcyBvcHRpb25hbAo+ID4g KwkgKiBob29rIGlzIHBhc3NlZCBpbiB3aGVuIGluaXRpYWxpemluZyB0aGUgcGlwZWxpbmUuCj4g PiArCSAqCj4gPiArCSAqIFJFVFVSTlM6Cj4gPiArCSAqCj4gPiArCSAqIE1PREVfT0sgaWYgdGhl IG1vZGUgaXMgYWNjZXB0YWJsZS4KPiA+ICsJICogTU9ERV9CQUQgaWYgd2UgbmVlZCB0byB0cnkg c29tZXRoaW5nIGVsc2UuCj4gPiArCSAqLwo+IAo+IEkgZG9uJ3Qgc2VlIHdoeSBNT0RFX0JBRCB3 b3VsZCBiZSB0aGUgb25seSB2YWxpZCBlcnJvciByZXR1cm4gZnJvbSB0aGlzCj4gaG9vay4gIENh biB3ZSBqdXN0IHVzZSB0aGUgc2FtZSBSRVRVUk5TIGRvY3MgYXMgb3RoZXIgbW9kZV92YWxpZCBt ZXRob2RzPwo+IAo+IE90aGVyIHRoYW4gdGhhdCwKPiAKPiBSZXZpZXdlZC1ieTogRXJpYyBBbmhv bHQgPGVyaWNAYW5ob2x0Lm5ldD4KClNhbWUgY29tbWVudCAoYWx0aG91Z2ggbm90ZSB0aGF0IGV4 Y2VwdCBmb3IgZG1lc2cgbm9pc2Ugd2UgY3VycmVudGx5IHRocm93CnRoZW0gYXdheSksIGFuZCBJ IGFncmVlIHRoYXQgbW9kZV92YWxpZCBtYWtlcyBzZW5zZSBmb3Igc2ltcGxlIGRyaXZlcnMsCmVz cGVjaWFsbHkgd2l0aCBhbGwgdGhlIHJlZmFjdG9yaW5nIHdlJ3ZlIGRvbmUgdG8gY2FsbCBtb2Rl X3ZhbGlkIGJvdGggaW4KdGhlIGNvbm5lY3RvciBwcm9iZSBhbmQgYXRvbWljX2NoZWNrIHBhdGhz LiBPbiB0aGUgcmVzcHVuIHBhdGNoIChJJ20KYmVoaW5kIG9uIG1haWxzIC4uLik6CgpSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gCj4gPiArCWVu dW0gZHJtX21vZGVfc3RhdHVzICgqbW9kZV92YWxpZCkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ ID4gKwkJCQkJICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpOwo+ID4gKwo+ ID4gIAkvKioKPiA+ICAJICogQGVuYWJsZToKPiA+ICAJICoKPiA+IC0tIAo+ID4gMi4xNC4zCgoK Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=