From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v1] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC Date: Thu, 22 Feb 2018 17:11:28 +0100 Message-ID: <20180222161128.GC6419@phenom.ffwll.local> References: <1519279759-7803-1-git-send-email-andr2000@gmail.com> <1f051697-468d-76b9-a2be-16a281f57249@epam.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CAD76EE7B for ; Thu, 22 Feb 2018 16:11:34 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id m207so4140502wma.2 for ; Thu, 22 Feb 2018 08:11:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <1f051697-468d-76b9-a2be-16a281f57249@epam.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oleksandr Andrushchenko Cc: Oleksandr Andrushchenko , daniel.vetter@intel.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBGZWIgMjIsIDIwMTggYXQgMDg6MTI6NDhBTSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1 c2hjaGVua28gd3JvdGU6Cj4gT24gMDIvMjIvMjAxOCAwODowOSBBTSwgT2xla3NhbmRyIEFuZHJ1 c2hjaGVua28gd3JvdGU6Cj4gPiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3Nh bmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+Cj4gPiAKPiA+IEl0IGlzIHBvc3NpYmxlIHRoYXQg ZHJtX3NpbXBsZV9rbXNfcGxhbmVfYXRvbWljX2NoZWNrIGNhbGxlZAo+ID4gd2l0aCBubyBDUlRD IHNldCwgZS5nLiB3aGVuIHVzZXItc3BhY2UgYXBwbGljYXRpb24gc2V0cyBDUlRDX0lEL0ZCX0lE Cj4gPiB0byAwIGJlZm9yZSBkb2luZyBhbnkgYWN0dWFsIGRyYXdpbmcuIFRoaXMgbGVhZHMgdG8g TlVMTCBwb2ludGVyCj4gPiBkZXJlZmVyZW5jZSBiZWNhdXNlIGluIHRoaXMgY2FzZSBuZXcgQ1JU QyBzdGF0ZSBpcyBOVUxMIGFuZCBtdXN0IGJlCj4gPiBjaGVja2VkIGJlZm9yZSBhY2Nlc3Npbmcu Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gCj4gPiAtLS0KPiA+IENoYW5nZXMgc2luY2Ug aW5pdGlhbDoKPiA+IC0gcmUtd29ya2VkIGNoZWNrcyBmb3IgbnVsbCBDUlRDIGFzIHN1Z2dlc3Rl ZCBieSBEYW5pZWwgVmV0dGVyCj4gPiAtLS0KPiA+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9zaW1w bGVfa21zX2hlbHBlci5jIHwgMTAgKysrLS0tLS0tLQo+ID4gICAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9z aW1wbGVfa21zX2hlbHBlci5jCj4gPiBpbmRleCA5Y2E4YTRhNTliNzQuLjRhMWRiZDg4YjFlYyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gPiBAQCAt MTIxLDEyICsxMjEsNiBAQCBzdGF0aWMgaW50IGRybV9zaW1wbGVfa21zX3BsYW5lX2F0b21pY19j aGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAgCXBpcGUgPSBjb250YWluZXJfb2Yo cGxhbmUsIHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSwgcGxhbmUpOwo+ID4gICAJY3J0 Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHBsYW5lX3N0YXRlLT5zdGF0 ZSwKPiA+ICAgCQkJCQkJICAgJnBpcGUtPmNydGMpOwo+ID4gLQlpZiAoIWNydGNfc3RhdGUtPmVu YWJsZSkKPiA+IC0JCXJldHVybiAwOyAvKiBub3RoaW5nIHRvIGNoZWNrIHdoZW4gZGlzYWJsaW5n IG9yIGRpc2FibGVkICovCj4gPiAtCj4gPiAtCWlmIChjcnRjX3N0YXRlLT5lbmFibGUpCj4gPiAt CQlkcm1fbW9kZV9nZXRfaHZfdGltaW5nKCZjcnRjX3N0YXRlLT5tb2RlLAo+ID4gLQkJCQkgICAg ICAgJmNsaXAueDIsICZjbGlwLnkyKTsKPiA+ICAgCXJldCA9IGRybV9hdG9taWNfaGVscGVyX2No ZWNrX3BsYW5lX3N0YXRlKHBsYW5lX3N0YXRlLCBjcnRjX3N0YXRlLAo+ID4gICAJCQkJCQkgICZj bGlwLAo+ID4gQEAgLTEzNyw3ICsxMzEsOSBAQCBzdGF0aWMgaW50IGRybV9zaW1wbGVfa21zX3Bs YW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAgCQlyZXR1cm4g cmV0Owo+ID4gICAJaWYgKCFwbGFuZV9zdGF0ZS0+dmlzaWJsZSkKPiA+IC0JCXJldHVybiAtRUlO VkFMOwo+IERhbmllbCwgSSBoYXZlIHB1dCB5b3VyIFItYiB0YWcsIGJ1dCBJIGhhZCByZW1vdmVk IHN1Z2dlc3RlZAo+ICJXQVJOX09OKGNydGNfc3RhdGUgJiYgY3J0Y19zdGF0ZS0+ZW5hYmxlKTsi Cj4gaGVyZSBhcyBpdCBmaXJlcyBlYWNoIHRpbWUgd2hlbiBjcnRjX3N0YXRlIGlzIG5vdCBOVUxM Lgo+IFBsZWFzZSBsZXQgbWUga25vdyBpZiB0aGlzIGlzIG5vdCBvayBhbmQgeW91IHdhbnQgbWUg dG8gcmVtb3ZlCj4geW91ciBSLWIgdGFnLgoKSSdtIGEgYml0IGNvbmZ1c2VkIHdoeSB0aGF0IGZp cmVzLCBidXQgb2ggd2VsbC4gQXBwbGllZCwgdGhhbmtzIGZvciB5b3VyCnBhdGNoLgotRGFuaWVs Cgo+ID4gKwkJcmV0dXJuIDA7Cj4gPiArCj4gPiArCWRybV9tb2RlX2dldF9odl90aW1pbmcoJmNy dGNfc3RhdGUtPm1vZGUsICZjbGlwLngyLCAmY2xpcC55Mik7Cj4gPiAgIAlpZiAoIXBpcGUtPmZ1 bmNzIHx8ICFwaXBlLT5mdW5jcy0+Y2hlY2spCj4gPiAgIAkJcmV0dXJuIDA7Cj4gVGhhbmsgeW91 LAo+IE9sZWtzYW5kcgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=