dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Jyri Sarha <jsarha@ti.com>
Cc: airlied@linux.ie, tomi.valkeinen@ti.com,
	thierry.reding@gmail.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/panel: Add device_link from panel device to drm device
Date: Fri, 23 Feb 2018 07:58:45 +0100	[thread overview]
Message-ID: <20180223065845.GA19515@wunner.de> (raw)
In-Reply-To: <acfd3eb48a180c88e7463798505aadacc004f28f.1519319383.git.jsarha@ti.com>

On Thu, Feb 22, 2018 at 07:46:27PM +0200, Jyri Sarha wrote:
> Add device_link from panel device (supplier) to drm device (consumer)
> with DL_FLAG_AUTOREMOVE when drm_panel_attach() is called. Currently
> the master drm driver is not protected against the attached. The
> device_link with DL_FLAG_AUTOREMOVE should make sure the drm device is
> unbound before the panel driver becomes unavailable.
> 
> The device_link is removed when drm_panel_detach() is called. The
> drm_panel_detach() should be called by the panel driver it self when
> it is removed. Otherwise the both driver are racing to delete the same
> link.

Unfortunately you haven't addressed any of my comments on the previous
version of this patch:

https://www.spinics.net/lists/dri-devel/msg166320.html

Please respin with my comments addressed.  Thanks,

Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-23  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 17:46 [PATCH 0/2] drm/panel: Add device link in drm_panel_attach() Jyri Sarha
2018-02-22 17:46 ` [PATCH 1/2] drm/panel: Remove drm_panel_detach() calls from all panel drives Jyri Sarha
2018-02-22 17:46 ` [PATCH 2/2] drm/panel: Add device_link from panel device to drm device Jyri Sarha
2018-02-23  6:58   ` Lukas Wunner [this message]
2018-02-23 10:43     ` Jyri Sarha
2018-02-23 13:10       ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223065845.GA19515@wunner.de \
    --to=lukas@wunner.de \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox