From: Lukas Wunner <lukas@wunner.de>
To: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
Daniel Vetter <daniel.vetter@intel.com>,
kernel@martin.sperl.org
Subject: Re: [PATCH v2 2/2] spi/spi-bcm2835: Add bcm2835_spi_transfer_one_message in spi-bcm2835.c
Date: Sun, 25 Feb 2018 17:49:03 +0100 [thread overview]
Message-ID: <20180225164903.GA7348@wunner.de> (raw)
In-Reply-To: <91a77832e7d4c5ca5f5ec6f81251922ee8019e77.1519492575.git.meghana.madhyastha@gmail.com>
On Sat, Feb 24, 2018 at 06:17:12PM +0000, Meghana Madhyastha wrote:
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1003,7 +1003,7 @@ static int spi_map_msg(struct spi_controller *ctlr, struct spi_message *msg)
> * drivers which implement a transfer_one() operation. It provides
> * standard handling of delays and chip select management.
> */
> -static int spi_transfer_one_message(struct spi_controller *ctlr,
> +int spi_transfer_one_message(struct spi_controller *ctlr,
An alternative to exporting this function would be to have it check
if any of the transfers in the message exceed ctlr->max_dma_len,
and automatically split those. That's for Mark to decide.
> if (xfer->tx_buf || xfer->rx_buf) {
> reinit_completion(&ctlr->xfer_completion);
> -
Spurious deleted newline.
> /* calculate how many we have to replace */
> count = DIV_ROUND_UP(xfer->len, maxsize);
> -
Another one.
Thanks,
Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-25 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 18:15 [PATCH v2 0/2] Chunk splitting of spi transfers Meghana Madhyastha
2018-02-24 18:16 ` [PATCH v2 1/2] drm/tinydrm: Remove chunk splitting in tinydrm_spi_transfer Meghana Madhyastha
2018-02-25 17:03 ` Lukas Wunner
2018-02-27 17:39 ` Noralf Trønnes
2018-02-24 18:17 ` [PATCH v2 2/2] spi/spi-bcm2835: Add bcm2835_spi_transfer_one_message in spi-bcm2835.c Meghana Madhyastha
2018-02-25 16:49 ` Lukas Wunner [this message]
2018-02-25 13:19 ` [PATCH v2 0/2] Chunk splitting of spi transfers Lukas Wunner
2018-02-27 17:40 ` Noralf Trønnes
2018-03-02 11:11 ` Meghana Madhyastha
2018-03-04 17:38 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225164903.GA7348@wunner.de \
--to=lukas@wunner.de \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@martin.sperl.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=meghana.madhyastha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox