From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk()
Date: Mon, 26 Feb 2018 17:42:33 +0200 [thread overview]
Message-ID: <20180226154233.GT5453@intel.com> (raw)
In-Reply-To: <44779bf0-be10-b70e-9588-1c7c1693b274@redhat.com>
On Mon, Feb 26, 2018 at 03:35:34PM +0100, Hans de Goede wrote:
> Hi,
>
> On 26-02-18 15:24, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > sparse complains:
> > drivers/gpu/drm/drm_panel_orientation_quirks.c:133:5: warning: symbol 'drm_get_panel_orientation_quirk' was not declared. Should it be static?
> >
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Good catch:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Thanks. Pushed to drm-misc-next.
>
> Regards,
>
> Hans
>
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 1f2af707ce03..902cc1a71e45 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -11,6 +11,7 @@
> > #include <linux/dmi.h>
> > #include <linux/module.h>
> > #include <drm/drm_connector.h>
> > +#include <drm/drm_utils.h>
> >
> > #ifdef CONFIG_DMI
> >
> >
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-02-26 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 14:24 [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk() Ville Syrjala
2018-02-26 14:35 ` Hans de Goede
2018-02-26 15:42 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226154233.GT5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox