From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/5] drm/prime: make the pages array optional for
 drm_prime_sg_to_page_addr_arrays
Date: Tue, 6 Mar 2018 10:21:02 +0100
Message-ID: <20180306092102.GM22212@phenom.ffwll.local>
References: <20180227115000.4105-1-christian.koenig@amd.com>
 <20180227115000.4105-2-christian.koenig@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com
 [IPv6:2a00:1450:400c:c09::241])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6A5E18987A
 for <dri-devel@lists.freedesktop.org>; Tue,  6 Mar 2018 09:21:06 +0000 (UTC)
Received: by mail-wm0-x241.google.com with SMTP id s206so17033728wme.0
 for <dri-devel@lists.freedesktop.org>; Tue, 06 Mar 2018 01:21:06 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20180227115000.4105-2-christian.koenig@amd.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Christian =?iso-8859-1?Q?K=F6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMTI6NDk6NTdQTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5p
ZyB3cm90ZToKPiBNb3N0IG9mIHRoZSB0aW1lIHdlIG9ubHkgbmVlZCB0aGUgZG1hIGFkZHJlc3Nl
cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmln
QGFtZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYyB8IDIwICsrKysr
KysrKystLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMCBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5j
IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gaW5kZXggYzM4ZGFjZGE2MTE5Li43ODU2
YTliM2Y4YTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gQEAgLTkyMiw0MCArOTIyLDQwIEBAIEVY
UE9SVF9TWU1CT0woZHJtX3ByaW1lX3BhZ2VzX3RvX3NnKTsKPiAgLyoqCj4gICAqIGRybV9wcmlt
ZV9zZ190b19wYWdlX2FkZHJfYXJyYXlzIC0gY29udmVydCBhbiBzZyB0YWJsZSBpbnRvIGEgcGFn
ZSBhcnJheQo+ICAgKiBAc2d0OiBzY2F0dGVyLWdhdGhlciB0YWJsZSB0byBjb252ZXJ0Cj4gLSAq
IEBwYWdlczogYXJyYXkgb2YgcGFnZSBwb2ludGVycyB0byBzdG9yZSB0aGUgcGFnZSBhcnJheSBp
bgo+ICsgKiBAcGFnZXM6IG9wdGlvbmFsIGFycmF5IG9mIHBhZ2UgcG9pbnRlcnMgdG8gc3RvcmUg
dGhlIHBhZ2UgYXJyYXkgaW4KPiAgICogQGFkZHJzOiBvcHRpb25hbCBhcnJheSB0byBzdG9yZSB0
aGUgZG1hIGJ1cyBhZGRyZXNzIG9mIGVhY2ggcGFnZQo+IC0gKiBAbWF4X3BhZ2VzOiBzaXplIG9m
IGJvdGggdGhlIHBhc3NlZC1pbiBhcnJheXMKPiArICogQG1heF9lbnRyaWVzOiBzaXplIG9mIGJv
dGggdGhlIHBhc3NlZC1pbiBhcnJheXMKPiAgICoKPiAgICogRXhwb3J0cyBhbiBzZyB0YWJsZSBp
bnRvIGFuIGFycmF5IG9mIHBhZ2VzIGFuZCBhZGRyZXNzZXMuIFRoaXMgaXMgY3VycmVudGx5Cj4g
ICAqIHJlcXVpcmVkIGJ5IHRoZSBUVE0gZHJpdmVyIGluIG9yZGVyIHRvIGRvIGNvcnJlY3QgZmF1
bHQgaGFuZGxpbmcuCj4gICAqLwoKQ2FuJ3Qgd2UganVzdCB0ZWFjaCB0dG0gdG8gdXNlIHNndHMg
d2hlcmV2ZXIgbmVlZGVkLCBhbmQgZGVwcmVjYXRlCmV4cG9ydGluZyBkbWEtYnVmcyB0byBwYWdl
IGFycmF5cyAod2hpY2ggcmVhbGx5IGJyZWFrcyB0aGUgYWJzdHJhY3Rpb24KZW50aXJlbHkgYW5k
IHdhcyBqdXN0IGEgcXVpY2sgaGFjayB0byBnZXQgdGhpbmdzIGdvaW5nIHRoYXQgc3R1Y2sgYXJv
dW5kCmZvciB5ZWFycykuIExhc3QgdGltZSBJIGxvb2tlZCBpbnRvIHR0bSB0aGUgb25seSB0aGlu
ZyBpdCBkaWQgaXMgY29udmVydAppdCBiYWNrIHRvIHNndHMgYWdhaW4gKGFmdGVyIGNhbGxpbmcg
ZG1hX21hcCBvbmNlIG1vcmUsIHdoaWNoIHRoZSBleHBvcnRlcgpzaG91bGQgaGF2ZSBkb25lIGFs
cmVhZHkgZm9yIHlvdSkuCi1EYW5pZWwKCj4gIGludCBkcm1fcHJpbWVfc2dfdG9fcGFnZV9hZGRy
X2FycmF5cyhzdHJ1Y3Qgc2dfdGFibGUgKnNndCwgc3RydWN0IHBhZ2UgKipwYWdlcywKPiAtCQkJ
CSAgICAgZG1hX2FkZHJfdCAqYWRkcnMsIGludCBtYXhfcGFnZXMpCj4gKwkJCQkgICAgIGRtYV9h
ZGRyX3QgKmFkZHJzLCBpbnQgbWF4X2VudHJpZXMpCj4gIHsKPiAgCXVuc2lnbmVkIGNvdW50Owo+
ICAJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZzsKPiAgCXN0cnVjdCBwYWdlICpwYWdlOwo+IC0JdTMy
IGxlbjsKPiAtCWludCBwZ19pbmRleDsKPiArCXUzMiBsZW4sIGluZGV4Owo+ICAJZG1hX2FkZHJf
dCBhZGRyOwo+ICAKPiAtCXBnX2luZGV4ID0gMDsKPiArCWluZGV4ID0gMDsKPiAgCWZvcl9lYWNo
X3NnKHNndC0+c2dsLCBzZywgc2d0LT5uZW50cywgY291bnQpIHsKPiAgCQlsZW4gPSBzZy0+bGVu
Z3RoOwo+ICAJCXBhZ2UgPSBzZ19wYWdlKHNnKTsKPiAgCQlhZGRyID0gc2dfZG1hX2FkZHJlc3Mo
c2cpOwo+ICAKPiAgCQl3aGlsZSAobGVuID4gMCkgewo+IC0JCQlpZiAoV0FSTl9PTihwZ19pbmRl
eCA+PSBtYXhfcGFnZXMpKQo+ICsJCQlpZiAoV0FSTl9PTihpbmRleCA+PSBtYXhfZW50cmllcykp
Cj4gIAkJCQlyZXR1cm4gLTE7Cj4gLQkJCXBhZ2VzW3BnX2luZGV4XSA9IHBhZ2U7Cj4gKwkJCWlm
IChwYWdlcykKPiArCQkJCXBhZ2VzW2luZGV4XSA9IHBhZ2U7Cj4gIAkJCWlmIChhZGRycykKPiAt
CQkJCWFkZHJzW3BnX2luZGV4XSA9IGFkZHI7Cj4gKwkJCQlhZGRyc1tpbmRleF0gPSBhZGRyOwo+
ICAKPiAgCQkJcGFnZSsrOwo+ICAJCQlhZGRyICs9IFBBR0VfU0laRTsKPiAgCQkJbGVuIC09IFBB
R0VfU0laRTsKPiAtCQkJcGdfaW5kZXgrKzsKPiArCQkJaW5kZXgrKzsKPiAgCQl9Cj4gIAl9Cj4g
IAlyZXR1cm4gMDsKPiAtLSAKPiAyLjE0LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2
ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu
Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs
aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK