From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC][PATCH 07/11] drm/probe-helper: Avoid iterating the list twice on ww backoff Date: Tue, 6 Mar 2018 10:49:43 +0100 Message-ID: <20180306094943.GV22212@phenom.ffwll.local> References: <20180227125700.6527-1-ville.syrjala@linux.intel.com> <20180227125700.6527-8-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180227125700.6527-8-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMDI6NTY6NTZQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IElmIHdlIGhhdmUgdG8gYmFja29mZiB0aGVyZSdzIG5vIHBvaW50IGluIGdvaW5n IG92ZXIgdGhlIG1vZGUgbGlzdCBhZ2Fpbgo+IHRvIG1hcmsgYWxsIHRoZSBtb2RlcyBhcyBzdGFs ZS4gV2UgY2FuIGRlZmVyIHRoYXQgdW50aWwgd2UncmUgcmVhZHkgdG8KPiByZWZyZXNoIHRoZSBt b2RlIGxpc3QuIEF2b2lkcyBtdWx0aXBsZSBsaXN0IHdhbGtzIGlmIHdlIGhhdmUgdG8gZG8gdGhl Cj4gbG9ja2luZyBiYWNrb2ZmLgo+IAo+IENjOiBLZWl0aCBQYWNrYXJkIDxrZWl0aHBAa2VpdGhw LmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWdu ZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t PgoKU29tZSBkcml2ZXJzIGFkZCBtb2RlcyBmcm9tIHRoZWlyIC0+ZGV0ZWN0IGNhbGxiYWNrcyBJ IHRoaW5rLCB3b24ndCB0aGlzCmJyZWFrIHRoZW0/IEF0IGxlYXN0IEknbSBuZXZlciBzdXJlIGFi b3V0IHdoYXQgZGlmZmVyZW50IGRyaXZlcnMgYXJlCnN1cHBvc2VkIHRvIGRvIGluIGVhY2ggY2Fz ZS4KCk90b2ggdGhlIGtlcm5lbGRvYyBpcyBmYWlybHkgY2xlYXIsIGFuZCB0aGlzIHBhdGNoIGlz IGVhc3kgdG8gcmV2ZXJ0LCBhbmQKaXQgbWlnaHQgaGVscCBpbiBmb3JjaW5nIGRyaXZlcnMgdG8g YmUgbW9yZSBjb25zaXN0ZW50LgoKSWYgeW91IGFkZCBhIG5vdGUgYWJvdXQgbXkgY29uY2VybnMg KGFzIGEgaGludCBpbiBjYXNlIHdlIGJpc2VjdCBhCnJlZ3Jlc3Npb24gdG8gdGhpcyBwYXRjaCks IHRoZW4gdGhpcyBpczoKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMg fCA4ICsrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gaW5kZXggNTI3NzQzMzk0 MTUwLi43ZGM3ZTYzNWQ3ZTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9i ZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiBA QCAtNDE1LDEwICs0MTUsNiBAQCBpbnQgZHJtX2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9y X21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAl9IGVsc2UKPiAgCQlX QVJOX09OKHJldCA8IDApOwo+ICAKPiAtCS8qIHNldCBhbGwgb2xkIG1vZGVzIHRvIHRoZSBzdGFs ZSBzdGF0ZSAqLwo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeShtb2RlLCAmY29ubmVjdG9yLT5tb2Rl cywgaGVhZCkKPiAtCQltb2RlLT5zdGF0dXMgPSBNT0RFX1NUQUxFOwo+IC0KPiAgCW9sZF9zdGF0 dXMgPSBjb25uZWN0b3ItPnN0YXR1czsKPiAgCj4gIAlpZiAoY29ubmVjdG9yLT5mb3JjZSkgewo+ IEBAIC00NzIsNiArNDY4LDEwIEBAIGludCBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0 b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCj4gIAlkZXYtPm1v ZGVfY29uZmlnLnBvbGxfcnVubmluZyA9IGRybV9rbXNfaGVscGVyX3BvbGw7Cj4gIAo+ICsJLyog c2V0IGFsbCBvbGQgbW9kZXMgdG8gdGhlIHN0YWxlIHN0YXRlICovCj4gKwlsaXN0X2Zvcl9lYWNo X2VudHJ5KG1vZGUsICZjb25uZWN0b3ItPm1vZGVzLCBoZWFkKQo+ICsJCW1vZGUtPnN0YXR1cyA9 IE1PREVfU1RBTEU7Cj4gKwo+ICAJaWYgKGNvbm5lY3Rvci0+c3RhdHVzID09IGNvbm5lY3Rvcl9z dGF0dXNfZGlzY29ubmVjdGVkKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygiW0NPTk5FQ1RPUjolZDol c10gZGlzY29ubmVjdGVkXG4iLAo+ICAJCQljb25uZWN0b3ItPmJhc2UuaWQsIGNvbm5lY3Rvci0+ bmFtZSk7Cj4gLS0gCj4gMi4xMy42Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==