From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 1/3] drm: Make sure at least one plane supports the fb format Date: Tue, 6 Mar 2018 11:35:15 +0100 Message-ID: <20180306103515.GI22212@phenom.ffwll.local> References: <20180305144919.2881-1-ville.syrjala@linux.intel.com> <87y3j6utm3.fsf@anholt.net> <20180305211500.GY5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CE1A6E664 for ; Tue, 6 Mar 2018 10:35:19 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id i3so21150163wmi.4 for ; Tue, 06 Mar 2018 02:35:19 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Harry Wentland Cc: Intel Graphics Development , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXIgMDUsIDIwMTggYXQgMDU6NDQ6MTZQTSAtMDUwMCwgSGFycnkgV2VudGxhbmQg d3JvdGU6Cj4gT24gMjAxOC0wMy0wNSAwNDozMyBQTSwgQWxleCBEZXVjaGVyIHdyb3RlOgo+ID4g T24gTW9uLCBNYXIgNSwgMjAxOCBhdCA0OjE1IFBNLCBWaWxsZSBTeXJqw6Rsw6QKPiA+IDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPj4gT24gTW9uLCBNYXIgMDUsIDIw MTggYXQgMTI6NTk6MDBQTSAtMDgwMCwgRXJpYyBBbmhvbHQgd3JvdGU6Cj4gPj4+IFZpbGxlIFN5 cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cml0ZXM6Cj4gPj4+Cj4gPj4+ PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ ID4+Pj4KPiA+Pj4+IFRvIG1ha2UgbGlmZSBlYXNpZXIgZm9yIGRyaXZlcnMsIGxldCdzIGhhdmUg dGhlIGNvcmUgY2hlY2sgdGhhdCB0aGUKPiA+Pj4+IHJlcXVlc3RlZCBwaXhlbCBmb3JtYXQgaXMg c3VwcG9ydGVkIGJ5IGF0IGxlYXN0IG9uZSBwbGFuZSB3aGVuIGNyZWF0aW5nCj4gPj4+PiBhIG5l dyBmcmFtZWJ1ZmZlci4KPiA+Pj4+Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4+Pj4gLS0tCj4gPj4+PiAgZHJp dmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIHwgMjYgKysrKysrKysrKysrKysrKysrKysr KysrKysKPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQo+ID4+Pj4KPiA+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiA+Pj4+IGluZGV4IGMwNTMwYTFhZjVlMy4u MTU1YjIxZTU3OWM0IDEwMDY0NAo+ID4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFt ZWJ1ZmZlci5jCj4gPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMK PiA+Pj4+IEBAIC0xNTIsNiArMTUyLDIzIEBAIHN0YXRpYyBpbnQgZmJfcGxhbmVfaGVpZ2h0KGlu dCBoZWlnaHQsCj4gPj4+PiAgICAgcmV0dXJuIERJVl9ST1VORF9VUChoZWlnaHQsIGZvcm1hdC0+ dnN1Yik7Cj4gPj4+PiAgfQo+ID4+Pj4KPiA+Pj4+ICtzdGF0aWMgYm9vbCBwbGFuZXNfaGF2ZV9m b3JtYXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdTMyIGZvcm1hdCkKPiA+Pj4+ICt7Cj4gPj4+ PiArICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gPj4+PiArCj4gPj4+PiArICAgLyogVE9E TzogbWF5YmUgbWFpbnRhaW4gYSBkZXZpY2UgbGV2ZWwgZm9ybWF0IGxpc3Q/ICovCj4gPj4+PiAr ICAgZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpIHsKPiA+Pj4+ICsgICAgICAgICAgIGlu dCBpOwo+ID4+Pj4gKwo+ID4+Pj4gKyAgICAgICAgICAgZm9yIChpID0gMDsgaSA8IHBsYW5lLT5m b3JtYXRfY291bnQ7IGkrKykgewo+ID4+Pj4gKyAgICAgICAgICAgICAgICAgICBpZiAocGxhbmUt PmZvcm1hdF90eXBlc1tpXSA9PSBmb3JtYXQpCj4gPj4+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIHRydWU7Cj4gPj4+PiArICAgICAgICAgICB9Cj4gPj4+PiArICAgfQo+ID4+ Pj4gKwo+ID4+Pj4gKyAgIHJldHVybiBmYWxzZTsKPiA+Pj4+ICt9Cj4gPj4+PiArCj4gPj4+PiAg c3RhdGljIGludCBmcmFtZWJ1ZmZlcl9jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ Pj4gICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQy ICpyKQo+ID4+Pj4gIHsKPiA+Pj4+IEBAIC0xNjgsNiArMTg1LDE1IEBAIHN0YXRpYyBpbnQgZnJh bWVidWZmZXJfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+Pj4+ICAgICAgICAgICAg IHJldHVybiAtRUlOVkFMOwo+ID4+Pj4gICAgIH0KPiA+Pj4+Cj4gPj4+PiArICAgaWYgKCFwbGFu ZXNfaGF2ZV9mb3JtYXQoZGV2LCByLT5waXhlbF9mb3JtYXQpKSB7Cj4gPj4+PiArICAgICAgICAg ICBzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1lX2J1ZiBmb3JtYXRfbmFtZTsKPiA+Pj4+ICsKPiA+Pj4+ ICsgICAgICAgICAgIERSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIGZyYW1lYnVmZmVyIGZvcm1h dCAlc1xuIiwKPiA+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgZHJtX2dldF9mb3JtYXRf bmFtZShyLT5waXhlbF9mb3JtYXQsCj4gPj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJmZvcm1hdF9uYW1lKSk7Cj4gPj4+PiArICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiA+Pj4+ICsgICB9Cj4gPj4+PiArCj4gPj4+Cj4gPj4+IFdvbid0IHRoaXMg YnJlYWsgS01TIG9uIHRoaW5ncyBsaWtlIHRoZSByYWRlb24gZHJpdmVyLCB3aGljaCBkb2Vzbid0 IGRvCj4gPj4+IHBsYW5lcz8gIE1heWJlIGNoZWNrIGlmIGFueSB1bml2ZXJzYWwgcGxhbmVzIGhh dmUgYmVlbiByZWdpc3RlcmVkIGFuZAo+ID4+PiBvbmx5IGRvIHRoZSBjaGVjayBpbiB0aGF0IGNh c2U/Cj4gPj4KPiA+PiBIbW0uIEkgdGhvdWdodCB3ZSBhZGQgdGhlIGltcGxpY2l0IHBsYW5lcyBh bHdheXMuIEFwcGFyZW50bHkKPiA+PiBkcm1fY3J0Y19pbml0KCkgYWRkcyBhIHByaW1hcnkgd2l0 aCBYL0FSR0I4ODg4LCBidXQgbm8gbW9yZS4gU28KPiA+PiB0aGlzIHdvdWxkIGJyZWFrIGFsbCBv dGhlciBmb3JtYXRzLCB3aGljaCBpcyBwcm9iYWJseSBhIGJpdCB0b28KPiA+PiBhZ2dyZXNzaXZl Lgo+ID4+Cj4gPj4gSSBndWVzcyBJIGNvdWxkIGp1c3Qgc2tpcCB0aGUgY2hlY2sgaW4gY2FzZSBh bnkgcGxhbmUgaGFzCj4gPj4gcGxhbmUtPmZvcm1hdF9kZWZhdWx0IHNldC4gVGhhdCBzaG91bGQg YmUgaW5kaWNhdGluZyB0aGF0IHRoZSBkcml2ZXIKPiA+PiBkb2Vzbid0IGRvIHBsYW5lcyBmdWxs eS4gT2gsIHdoeSBleGFjdGx5IGlzIGFtZ2dwdSBzZXR0aW5nIHRoYXQgZmxhZz8KPiA+PiBIYXJy eT8KPiA+IAo+ID4gUHJvYmFibHkgbGVmdG92ZXIgZnJvbSBEQyBicmluZ3VwPwo+IAo+IEknbSBu b3Qgc3VyZSBpZiBJJ20gZm9sbG93aW5nLiBXaGljaCBmbGFnIGFyZSB3ZSB0YWxraW5nIGFib3V0 Pwo+IAo+IElzIHRoZSBjb25jZXJuIHRoZSBEQyBkcml2ZXIgb3IgYW1kZ3B1IHdpdGggREMgKG9y IHJhZGVvbik/Cj4gCj4gREMgZG9lcyBub3QgY2FsbCBkcm1fY3J0Y19pbml0KCkuIEl0IGluaXRp YWxpemVzIHVuaXZlcnNhbCBwbGFuZXMgaW4gYW1kZ3B1X2RtX2luaXRpYWxpemVfZHJtX2Rldmlj ZSgpIC0+IGFtZGdwdV9kbV9wbGFuZV9pbml0KCkuCj4gCj4gRnJvbSBhIHF1aWNrIGdsYW5jZSB0 aGlzIHBhdGNoIGxvb2tzIGZpbmUgYnkgbWUuCgpGcm9tIGFtZGdwdV9kbV9wbGFuZV9pbml0OgoK CQlhcGxhbmUtPmJhc2UuZm9ybWF0X2RlZmF1bHQgPSB0cnVlOwpeXiB0aGlzIGlzIGVudGlyZWx5 IGJvZ3VzLCBwbHMgcmVtb3ZlLgoKCQlyZXMgPSBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQoCgkJ CQlkbS0+YWRldi0+ZGRldiwKCQkJCSZhcGxhbmUtPmJhc2UsCgkJCQlwb3NzaWJsZV9jcnRjcywK CQkJCSZkbV9wbGFuZV9mdW5jcywKCQkJCXJnYl9mb3JtYXRzLAoJCQkJQVJSQVlfU0laRShyZ2Jf Zm9ybWF0cyksCgkJCQlOVUxMLCBhcGxhbmUtPmJhc2UudHlwZSwgTlVMTCk7CgoKV3J0IGRpc2N1 c3Npb25zOiBBbHNvIGNoZWNraW5nIHdoZXRoZXIgYW55IHBsYW5lIGhhcyBzZXQKcGxhbmUtPmZv cm1hdF9kZWZhdWx0IGFuZCBhYm9ydGluZyB0aGUgY2hlY2sgc2hvdWxkIGtlZXAgb2xkIGttcyBk cml2ZXJzCndvcmtpbmcgSSBob3BlLgoKQ2hlZXJzLCBEYW5pZWwKCj4gCj4gSGFycnkKPiAKPiA+ IAo+ID4gQWxleAo+ID4gCj4gPj4KPiA+Pj4KPiA+Pj4gQWxzbywgImFueV9wbGFuZXNfaGF2ZV9m b3JtYXQoKSIgbWlnaHQgYmUgc2xpZ2h0bHkgbW9yZSBkZXNjcmlwdGl2ZS4KPiA+Pgo+ID4+IE9y IGFueV9wbGFuZV9oYXNfZm9ybWF0KCk/IElzIHRoYXQgbW9yZSBlbmdsaXNoeT8gOikKPiA+Pgo+ ID4+IC0tCj4gPj4gVmlsbGUgU3lyasOkbMOkCj4gPj4gSW50ZWwgT1RDCj4gPj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+PiBkcmktZGV2ZWwgbWFp bGluZyBsaXN0Cj4gPj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==