From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: [PATCH] drm/vc4: Fix oops dereferencing DPI's connector since panel_bridge. Date: Fri, 9 Mar 2018 15:32:56 -0800 Message-ID: <20180309233256.1667-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 400586E034 for ; Fri, 9 Mar 2018 23:33:00 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Boris Brezillon List-Id: dri-devel@lists.freedesktop.org SW4gdGhlIGNsZWFudXAsIEkgZGlkbid0IG5vdGljZSB0aGF0IHdlIG5lZWRlZCB0byBkZXJlZmVy ZW5jZSB0aGUKY29ubmVjdG9yIGZvciB0aGUgYnVzX2Zvcm1hdC4gIEZpeCB0aGUgcmVncmVzc2lv biBieSBsb29raW5nIHVwIHRoZQpmaXJzdCAoYW5kIG9ubHkpIGNvbm5lY3RvciBhdHRhY2hlZCB0 byB1cywgYW5kIGFzc3VtZSB0aGF0IGl0cwpidXNfZm9ybWF0IGlzIHdoYXQgd2Ugd2FudC4gIFNv bWUgZGF5IGl0IHdvdWxkIGJlIGdvb2QgdG8gaGF2ZSB0aGF0CnBhcnQgb2YgZGlzcGxheV9pbmZv IGF0dGFjaGVkIHRvIHRoZSBicmlkZ2UsIGluc3RlYWQuCgpTaWduZWQtb2ZmLWJ5OiBFcmljIEFu aG9sdCA8ZXJpY0BhbmhvbHQubmV0PgpGaXhlczogN2IxMjk4ZTA1MzEwICgiZHJtL3ZjNDogU3dp dGNoIERQSSB0byB1c2luZyB0aGUgcGFuZWwtYnJpZGdlIGhlbHBlci4iKQpDYzogQm9yaXMgQnJl emlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJt L3ZjNC92YzRfZHBpLmMgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKy0tLS0KIDEgZmlsZSBj aGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS92YzQvdmM0X2RwaS5jIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHBp LmMKaW5kZXggNzJjOWRiZDgxZDdmLi44ODc4M2UxNDNjYzIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv Z3B1L2RybS92YzQvdmM0X2RwaS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2RwaS5j CkBAIC05Niw3ICs5Niw2IEBAIHN0cnVjdCB2YzRfZHBpIHsKIAlzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2OwogCiAJc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyOwotCXN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3I7CiAKIAl2b2lkIF9faW9tZW0gKnJlZ3M7CiAKQEAgLTE2NCwx NCArMTYzLDMxIEBAIHN0YXRpYyB2b2lkIHZjNF9kcGlfZW5jb2Rlcl9kaXNhYmxlKHN0cnVjdCBk cm1fZW5jb2RlciAqZW5jb2RlcikKIAogc3RhdGljIHZvaWQgdmM0X2RwaV9lbmNvZGVyX2VuYWJs ZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCiB7CisJc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGVuY29kZXItPmRldjsKIAlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSA9ICZlbmNv ZGVyLT5jcnRjLT5tb2RlOwogCXN0cnVjdCB2YzRfZHBpX2VuY29kZXIgKnZjNF9lbmNvZGVyID0g dG9fdmM0X2RwaV9lbmNvZGVyKGVuY29kZXIpOwogCXN0cnVjdCB2YzRfZHBpICpkcGkgPSB2YzRf ZW5jb2Rlci0+ZHBpOworCXN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlciBjb25uX2l0ZXI7 CisJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciA9IE5VTEwsICpjb25uZWN0b3Jfc2Nh bjsKIAl1MzIgZHBpX2MgPSBEUElfRU5BQkxFIHwgRFBJX09VVFBVVF9FTkFCTEVfTU9ERTsKIAlp bnQgcmV0OwogCi0JaWYgKGRwaS0+Y29ubmVjdG9yLT5kaXNwbGF5X2luZm8ubnVtX2J1c19mb3Jt YXRzKSB7Ci0JCXUzMiBidXNfZm9ybWF0ID0gZHBpLT5jb25uZWN0b3ItPmRpc3BsYXlfaW5mby5i dXNfZm9ybWF0c1swXTsKKwkvKiBMb29rIHVwIHRoZSBjb25uZWN0b3IgYXR0YWNoZWQgdG8gRFBJ IHNvIHdlIGNhbiBnZXQgdGhlCisJICogYnVzX2Zvcm1hdC4gIElkZWFsbHkgdGhlIGJyaWRnZSB3 b3VsZCB0ZWxsIHVzIHRoZQorCSAqIGJ1c19mb3JtYXQgd2Ugd2FudCwgYnV0IGl0IGRvZXNuJ3Qg eWV0LCBzbyBhc3N1bWUgdGhhdCBpdCdzCisJICogdW5pZm9ybSB0aHJvdWdob3V0IHRoZSBicmlk Z2UgY2hhaW4uCisJICovCisJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfYmVnaW4oZGV2LCAmY29u bl9pdGVyKTsKKwlkcm1fZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIoY29ubmVjdG9yX3NjYW4sICZj b25uX2l0ZXIpIHsKKwkJaWYgKGNvbm5lY3Rvcl9zY2FuLT5lbmNvZGVyID09IGVuY29kZXIpIHsK KwkJCWNvbm5lY3RvciA9IGNvbm5lY3Rvcl9zY2FuOworCQkJYnJlYWs7CisJCX0KKwl9CisJZHJt X2Nvbm5lY3Rvcl9saXN0X2l0ZXJfZW5kKCZjb25uX2l0ZXIpOworCisJaWYgKGNvbm5lY3RvciAm JiBjb25uZWN0b3ItPmRpc3BsYXlfaW5mby5udW1fYnVzX2Zvcm1hdHMpIHsKKwkJdTMyIGJ1c19m b3JtYXQgPSBjb25uZWN0b3ItPmRpc3BsYXlfaW5mby5idXNfZm9ybWF0c1swXTsKIAogCQlzd2l0 Y2ggKGJ1c19mb3JtYXQpIHsKIAkJY2FzZSBNRURJQV9CVVNfRk1UX1JHQjg4OF8xWDI0OgpAQCAt MTk5LDYgKzIxNSw5IEBAIHN0YXRpYyB2b2lkIHZjNF9kcGlfZW5jb2Rlcl9lbmFibGUoc3RydWN0 IGRybV9lbmNvZGVyICplbmNvZGVyKQogCQkJRFJNX0VSUk9SKCJVbmtub3duIG1lZGlhIGJ1cyBm b3JtYXQgJWRcbiIsIGJ1c19mb3JtYXQpOwogCQkJYnJlYWs7CiAJCX0KKwl9IGVsc2UgeworCQkv KiBEZWZhdWx0IHRvIDI0Yml0IGlmIG5vIGNvbm5lY3RvciBmb3VuZC4gKi8KKwkJZHBpX2MgfD0g VkM0X1NFVF9GSUVMRChEUElfRk9STUFUXzI0QklUXzg4OF9SR0IsIERQSV9GT1JNQVQpOwogCX0K IAogCWlmIChtb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfTkhTWU5DKQpAQCAtMjY0LDcgKzI4 Myw3IEBAIHN0YXRpYyBpbnQgdmM0X2RwaV9pbml0X2JyaWRnZShzdHJ1Y3QgdmM0X2RwaSAqZHBp KQogCQkJcmV0dXJuIHJldDsKIAl9CiAKLQlpZiAocGFuZWwpCisJaWYgKHBhbmVsKSAKIAkJYnJp ZGdlID0gZHJtX3BhbmVsX2JyaWRnZV9hZGQocGFuZWwsIERSTV9NT0RFX0NPTk5FQ1RPUl9EUEkp OwogCiAJcmV0dXJuIGRybV9icmlkZ2VfYXR0YWNoKGRwaS0+ZW5jb2RlciwgYnJpZGdlLCBOVUxM KTsKLS0gCjIuMTYuMgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==